From: sashiko-bot@kernel.org
To: rofikkerneldev <rofikcoga@gmail.com>
Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-input@vger.kernel.org, robh@kernel.org,
conor+dt@kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH v1 06/11] dt-bindings: input: touchscreen: add Silicon Works SW42902
Date: Tue, 17 Nov 2026 12:51:13 +0000 [thread overview]
Message-ID: <sashiko-outbox-218806@kernel.org> (raw)
In-Reply-To: <20261117123946.668557-7-rofikcoga@gmail.com>
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [High] dt-bindings: input: touchscreen: username handle used in
sign-off and maintainer
- [Medium] dt-bindings: input: lg,sw42902: power rails modeled as GPIOs
instead of supplies
--
commit c2a344c3130db163c68195828fdefbdfd36cd07a
Author: rofikkerneldev <rofikcoga@gmail.com>
> dt-bindings: input: touchscreen: add Silicon Works SW42902
>
> Document the I2C touchscreen and its interrupt, reset, power-enable,
> and panel-size properties.
>
> Signed-off-by: rofikkerneldev <rofikcoga@gmail.com>
[Severity: High]
The Developer's Certificate of Origin requires a real human name (known
identity) rather than an account handle or pseudonym in Signed-off-by
trailers, the commit Author header, the binding's maintainers list, and
MAINTAINERS.
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/lg,sw42902.yaml b/Documentation/devicetree/bindings/input/touchscreen/lg,sw42902.yaml
> new file mode 100644
> index 0000000000000..c56cfb8530eeb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/touchscreen/lg,sw42902.yaml
> @@ -0,0 +1,74 @@
[ ... ]
> + vcl-gpios:
> + maxItems: 1
> + description: Active-high enable for the 3.3 V rail
> +
> + vdd-gpios:
> + maxItems: 1
> + description: Active-high enable for the 1.8 V rail
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - reset-gpios
> + - vcl-gpios
> + - vdd-gpios
[Severity: Medium]
Should the 3.3 V VCL and 1.8 V VDD power inputs be described as
vcl-supply and vdd-supply regulator properties instead of vcl-gpios and
vdd-gpios?
VCL and VDD are power supply rails on the SW42902 controller rather than
GPIO pins, so requiring GPIO properties in the binding prevents it from
describing boards powered by PMIC regulators or always-on supplies.
GPIO-switched rails on a specific board can be modeled as regulator-fixed
nodes in the board DTS connected to vcl-supply and vdd-supply.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117123946.668557-1-rofikcoga@gmail.com?part=6
next prev parent reply other threads:[~2026-11-17 12:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 12:39 [PATCH v1 00/11] arm64: qcom: Add initial support for LG V60 ThinQ 5G (timelm) rofikkerneldev
2026-11-17 12:39 ` [PATCH v1 01/11] dt-bindings: arm: qcom: add " rofikkerneldev
2026-11-17 12:47 ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 02/11] arm64: dts: qcom: add LG V60 ThinQ 5G (timelm) support rofikkerneldev
2026-11-17 12:39 ` [PATCH v1 03/11] arm64: dts: qcom: sm8250-lge-timelm: add reserved memory regions rofikkerneldev
2026-11-17 12:57 ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 04/11] dt-bindings: display: panel: add LG SW43103 rofikkerneldev
2026-11-17 12:51 ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 05/11] drm/panel: add LG SW43103 panel driver rofikkerneldev
2026-11-17 12:39 ` [PATCH v1 06/11] dt-bindings: input: touchscreen: add Silicon Works SW42902 rofikkerneldev
2026-11-17 12:51 ` sashiko-bot [this message]
2026-11-17 12:39 ` [PATCH v1 07/11] Input: touchscreen: add Silicon Works SW42902 support rofikkerneldev
2026-11-17 13:01 ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 08/11] arm64: dts: qcom: sm8250-lge-timelm: enable SW43103 panel rofikkerneldev
2026-11-17 12:39 ` [PATCH v1 09/11] arm64: dts: qcom: sm8250-lge-timelm: add SW42902 touchscreen rofikkerneldev
2026-11-17 12:56 ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 10/11] arm64: dts: qcom: sm8250-lge-timelm: enable USB Type-C rofikkerneldev
2026-11-17 12:39 ` [PATCH v1 11/11] arm64: dts: qcom: sm8250-lge-timelm: add QCA6390 Bluetooth rofikkerneldev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-218806@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-input@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rofikcoga@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox