Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: rofikkerneldev <rofikcoga@gmail.com>
Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-input@vger.kernel.org, robh@kernel.org,
	conor+dt@kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH v1 04/11] dt-bindings: display: panel: add LG SW43103
Date: Tue, 17 Nov 2026 12:51:41 +0000	[thread overview]
Message-ID: <sashiko-outbox-218810@kernel.org> (raw)
In-Reply-To: <20261117123946.668557-5-rofikcoga@gmail.com>

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [High] dt-bindings: display: panel: lg,sw43103: handle used instead of
  real name
- [Low] MAINTAINERS: LG SW43103 PANEL DRIVER added out of alphabetical
  order
--

commit 8f35306c3ad9479ca0f821358a8333dce583f152
Author: rofikkerneldev <rofikcoga@gmail.com>

> dt-bindings: display: panel: add LG SW43103
>
> Document the SW43103 FHD+ AMOLED panel used by the LG V60. The panel
> uses DSI command mode with DSC and DCS backlight control.
>
> Signed-off-by: rofikkerneldev <rofikcoga@gmail.com>
> ---
>  .../bindings/display/panel/lg,sw43103.yaml    | 70 +++++++++++++++++++
>  MAINTAINERS                                   |  5 ++
>  2 files changed, 75 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/lg,sw43103.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/panel/lg,sw43103.yaml b/Documentation/devicetree/bindings/display/panel/lg,sw43103.yaml
> new file mode 100644
> index 0000000000000..edd007e2c0d76
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/lg,sw43103.yaml
> @@ -0,0 +1,70 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/lg,sw43103.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: LG / BOE SW43103 1080x2460 DSI cmd mode panel
> +
> +maintainers:
> +  - rofikkerneldev <rofikcoga@gmail.com>

[Severity: High]
The commit Author, Signed-off-by trailer, DT binding schema maintainers
entry, and MAINTAINERS M: entry all use the handle "rofikkerneldev" instead
of a full real name.  Under the Developer's Certificate of Origin in
Documentation/process/submitting-patches.rst and the MAINTAINERS file
requirements, these must use a real name in the form
"FullName <address@domain>".

[ ... ]

> diff --git a/MAINTAINERS b/MAINTAINERS
> index c88fc0e019296..e7e32c23ba2fd 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -15231,6 +15231,11 @@ Q:	http://patchwork.linuxtv.org/project/linux-media/list/
>  T:	git git://linuxtv.org/mkrufky/tuners.git
>  F:	drivers/media/dvb-frontends/lgdt3305.*
>  
> +LG SW43103 PANEL DRIVER
> +M:	rofikkerneldev <rofikcoga@gmail.com>
> +S:	Maintained
> +F:	Documentation/devicetree/bindings/display/panel/lg,sw43103.yaml
> +

[Severity: Low]
This new section is out of alphabetical order in MAINTAINERS, which causes
scripts/parse-maintainers.pl --order to warn.  Since a space sorts before
digits and letters, "LG SW43103 PANEL DRIVER" should be placed after
"LG LAPTOP EXTRAS" and before "LG2160 MEDIA DRIVER".

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117123946.668557-1-rofikcoga@gmail.com?part=4

  reply	other threads:[~2026-11-17 12:51 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 12:39 [PATCH v1 00/11] arm64: qcom: Add initial support for LG V60 ThinQ 5G (timelm) rofikkerneldev
2026-11-17 12:39 ` [PATCH v1 01/11] dt-bindings: arm: qcom: add " rofikkerneldev
2026-11-17 12:47   ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 02/11] arm64: dts: qcom: add LG V60 ThinQ 5G (timelm) support rofikkerneldev
2026-11-17 12:39 ` [PATCH v1 03/11] arm64: dts: qcom: sm8250-lge-timelm: add reserved memory regions rofikkerneldev
2026-11-17 12:57   ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 04/11] dt-bindings: display: panel: add LG SW43103 rofikkerneldev
2026-11-17 12:51   ` sashiko-bot [this message]
2026-11-17 12:39 ` [PATCH v1 05/11] drm/panel: add LG SW43103 panel driver rofikkerneldev
2026-11-17 12:39 ` [PATCH v1 06/11] dt-bindings: input: touchscreen: add Silicon Works SW42902 rofikkerneldev
2026-11-17 12:51   ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 07/11] Input: touchscreen: add Silicon Works SW42902 support rofikkerneldev
2026-11-17 13:01   ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 08/11] arm64: dts: qcom: sm8250-lge-timelm: enable SW43103 panel rofikkerneldev
2026-11-17 12:39 ` [PATCH v1 09/11] arm64: dts: qcom: sm8250-lge-timelm: add SW42902 touchscreen rofikkerneldev
2026-11-17 12:56   ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 10/11] arm64: dts: qcom: sm8250-lge-timelm: enable USB Type-C rofikkerneldev
2026-11-17 12:39 ` [PATCH v1 11/11] arm64: dts: qcom: sm8250-lge-timelm: add QCA6390 Bluetooth rofikkerneldev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-218810@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-input@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=rofikcoga@gmail.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox