From: sashiko-bot@kernel.org
To: rofikkerneldev <rofikcoga@gmail.com>
Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-input@vger.kernel.org, robh@kernel.org,
conor+dt@kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH v1 09/11] arm64: dts: qcom: sm8250-lge-timelm: add SW42902 touchscreen
Date: Tue, 17 Nov 2026 12:56:27 +0000 [thread overview]
Message-ID: <sashiko-outbox-218812@kernel.org> (raw)
In-Reply-To: <20261117123946.668557-10-rofikcoga@gmail.com>
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [High] arm64: dts: qcom: Signed-off-by and Author use handle instead
of real name
- [Low] arm64: dts: qcom: sm8250-lge-timelm: i2c13 and tlmm nodes out of
order
--
commit c8220e43d297448ae1467ca0fc69fcaa8385a92a
Author: rofikkerneldev <rofikcoga@gmail.com>
> arm64: dts: qcom: sm8250-lge-timelm: add SW42902 touchscreen
>
> Describe the SW42902 on GENI I2C13 with its interrupt, reset,
> power-enable GPIOs, pinctrl, and native 1080x2460 touch area.
>
> Signed-off-by: rofikkerneldev <rofikcoga@gmail.com>
[Severity: High]
Both the commit Author and the Signed-off-by trailer use the account
handle "rofikkerneldev" instead of a real human name. Under the
Developer Certificate of Origin in
Documentation/process/submitting-patches.rst, patches must be authored
and signed off using a known real name rather than a pseudonym or
username.
> diff --git a/arch/arm64/boot/dts/qcom/sm8250-lge-timelm.dts b/arch/arm64/boot/dts/qcom/sm8250-lge-timelm.dts
> index fca48472f5dfe..a094aa81ad225 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250-lge-timelm.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8250-lge-timelm.dts
> @@ -596,3 +596,39 @@ &mdss_dsi0_phy {
> phy-type = <PHY_TYPE_DPHY>;
> status = "okay";
> };
> +
> +&i2c13 {
> + clock-frequency = <400000>;
> + status = "okay";
> +
> + touchscreen@28 {
> + compatible = "lg,sw42902";
> + reg = <0x28>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&touch_reset_default &touch_irq_default>;
> + interrupt-parent = <&tlmm>;
> + interrupts = <39 IRQ_TYPE_LEVEL_LOW>;
> + reset-gpios = <&tlmm 38 GPIO_ACTIVE_LOW>;
> + vcl-gpios = <&tlmm 67 GPIO_ACTIVE_HIGH>;
> + vdd-gpios = <&tlmm 68 GPIO_ACTIVE_HIGH>;
> + touchscreen-size-x = <1080>;
> + touchscreen-size-y = <2460>;
> + };
> +};
> +
> +&tlmm {
> + touch_reset_default: touch-reset-default-state {
> + pins = "gpio38";
> + function = "gpio";
> + drive-strength = <6>;
> + bias-pull-up;
> + };
> +
> + touch_irq_default: touch-irq-default-state {
> + pins = "gpio39";
> + function = "gpio";
> + drive-strength = <2>;
> + bias-pull-up;
> + };
> +};
[Severity: Low]
This isn't a bug, but &i2c13 and &tlmm are appended at the bottom of the
file after &mdss_dsi0_phy rather than in alphabetical order (&i2c13
after &gpu and &tlmm before &uart12) as expected by
Documentation/devicetree/bindings/dts-coding-style.rst and the rest of
this board file.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117123946.668557-1-rofikcoga@gmail.com?part=9
next prev parent reply other threads:[~2026-11-17 12:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 12:39 [PATCH v1 00/11] arm64: qcom: Add initial support for LG V60 ThinQ 5G (timelm) rofikkerneldev
2026-11-17 12:39 ` [PATCH v1 01/11] dt-bindings: arm: qcom: add " rofikkerneldev
2026-11-17 12:47 ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 02/11] arm64: dts: qcom: add LG V60 ThinQ 5G (timelm) support rofikkerneldev
2026-11-17 12:39 ` [PATCH v1 03/11] arm64: dts: qcom: sm8250-lge-timelm: add reserved memory regions rofikkerneldev
2026-11-17 12:57 ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 04/11] dt-bindings: display: panel: add LG SW43103 rofikkerneldev
2026-11-17 12:51 ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 05/11] drm/panel: add LG SW43103 panel driver rofikkerneldev
2026-11-17 12:39 ` [PATCH v1 06/11] dt-bindings: input: touchscreen: add Silicon Works SW42902 rofikkerneldev
2026-11-17 12:51 ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 07/11] Input: touchscreen: add Silicon Works SW42902 support rofikkerneldev
2026-11-17 12:39 ` [PATCH v1 08/11] arm64: dts: qcom: sm8250-lge-timelm: enable SW43103 panel rofikkerneldev
2026-11-17 12:39 ` [PATCH v1 09/11] arm64: dts: qcom: sm8250-lge-timelm: add SW42902 touchscreen rofikkerneldev
2026-11-17 12:56 ` sashiko-bot [this message]
2026-11-17 12:39 ` [PATCH v1 10/11] arm64: dts: qcom: sm8250-lge-timelm: enable USB Type-C rofikkerneldev
2026-11-17 12:39 ` [PATCH v1 11/11] arm64: dts: qcom: sm8250-lge-timelm: add QCA6390 Bluetooth rofikkerneldev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-218812@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-input@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rofikcoga@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox