From: Jonathan LoBue <jlobue10@gmail.com>
To: "Hans De Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Platform Driver" <platform-driver-x86@vger.kernel.org>,
"Andy Shevchenko" <andy.shevchenko@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
jagathjog1996@gmail.com, luke@ljones.dev,
benato.denis96@gmail.com, linux-iio@vger.kernel.org,
lkml@antheas.dev, derekjohn.clark@gmail.com
Subject: Re: [PATCH 2/2] iio: imu: bmi323: Add and enable ACPI Match Table
Date: Sun, 11 Feb 2024 23:30:02 -0800 [thread overview]
Message-ID: <13845892.uLZWGnKmhe@nobara-ally-pc> (raw)
In-Reply-To: <CAHp75VcFXSfV4rPDaJcUVC92QGK3U55AqQqPo0WYKmpcKnw+eQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 860 bytes --]
On Sunday, February 11, 2024 9:08:59 AM PST Andy Shevchenko wrote:
>
> No ACPI_PTR() in new code. It's more problematic than helpful.
>
> Above for your information for the future contributions, as I said in
> the other patch comment, I think the better approach is to enumerate
> from an external driver under the PDx86 realm.
Thanks for the constructive feedback. I'm working to fix and re-send via
git send-email. I think the ACPI match table method should be okay and
seems pretty standard for a lot of devices. The problem in this case is
that the identifiers are not currently unique to each chip. This is something
that should be rectified with BOSCH and system builders and then in the
future, the ACPI match table(s) can be updated, and the aborting portion
of loading the bmc150 driver for ASUS ROG ALLY can be removed.
Best Regards,
Jon LoBue
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-02-12 7:30 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-09 16:05 [PATCH] iio: imu: bmi323: Support loading of bmi323 driver for ASUS ROG ALLY Jonathan LoBue
2024-02-10 15:25 ` Jonathan Cameron
2024-02-10 16:23 ` Jonathan LoBue
2024-02-10 16:49 ` Jonathan Cameron
2024-02-10 20:43 ` Jonathan LoBue
2024-02-10 22:32 ` [PATCH 1/2] iio: accel: bmc150: ASUS ROG ALLY Abort Loading Jonathan LoBue
2024-02-11 17:04 ` Andy Shevchenko
2024-02-12 7:21 ` Jonathan LoBue
2024-02-12 9:46 ` Andy Shevchenko
2024-02-13 2:39 ` [PATCH v1] iio: imu: bmi323: Add and enable ACPI Match Table Jonathan LoBue
2024-02-13 10:49 ` Andy Shevchenko
2024-02-13 17:14 ` Jonathan LoBue
2024-02-13 17:29 ` Andy Shevchenko
2024-02-13 22:38 ` [PATCH v2 1/2] iio: accel: bmc150: Duplicate ACPI entries Jonathan LoBue
2024-02-14 9:35 ` Andy Shevchenko
2024-02-14 15:07 ` Jonathan LoBue
2024-02-14 15:39 ` Andy Shevchenko
2024-02-14 16:16 ` Jonathan Cameron
2024-02-13 22:39 ` [PATCH v2 2/2] iio: imu: bmi323: Add and enable ACPI Match Table Jonathan LoBue
2024-02-14 9:39 ` Andy Shevchenko
2024-02-14 15:15 ` Jonathan LoBue
2024-02-14 15:31 ` Andy Shevchenko
2024-02-14 17:35 ` Jonathan LoBue
2024-02-14 18:21 ` Andy Shevchenko
2024-02-14 16:19 ` Jonathan Cameron
2024-02-13 2:47 ` [PATCH 1/2] iio: accel: bmc150: ASUS ROG ALLY Abort Loading Jonathan LoBue
2024-02-10 22:34 ` [PATCH 2/2] iio: imu: bmi323: Add and enable ACPI Match Table Jonathan LoBue
2024-02-11 16:31 ` Jonathan Cameron
2024-02-11 17:08 ` Andy Shevchenko
2024-02-12 7:30 ` Jonathan LoBue [this message]
2024-02-12 9:50 ` Andy Shevchenko
2024-02-12 17:33 ` Jonathan LoBue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13845892.uLZWGnKmhe@nobara-ally-pc \
--to=jlobue10@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=benato.denis96@gmail.com \
--cc=derekjohn.clark@gmail.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jagathjog1996@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=lkml@antheas.dev \
--cc=luke@ljones.dev \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox