Re: [PATCH 1/2] iio: accel: bmc150: ASUS ROG ALLY Abort Loading

[Jonathan LoBue <jlobue10@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1054 bytes --]

On Monday, February 12, 2024 1:46:21 AM PST Andy Shevchenko wrote:
> Even if fixed (which has to be done anyway) it can be undone in old
> firmwares — there is no solution to make all affected users update
> firmware. Do we have real products on the market with the wrong ID (I
> assume we do)?

After some conversations with other devs today, we retested and confirmed
that the DMI quirks to abort loading of bmc150 is actually unnecessary.
There was some confusion among us about why they had tried that approach
in the past. The bmc150 driver does in fact start to load on ASUS ROG ALLY
with a "BOSC0200" ACPI match, but when it gets to the chip id check portion
it correctly aborts loading the driver for mismatched chip ID. This allows
the bmi323 driver to pick it up properly with the "BOSC0200" ACPI match
table match. Tested and confirmed working on my end with the submitted
v1 patch. The DMI quirks and any modifications to bmc150 driver has been
dropped. Thanks all for the feedback and help.

Best Regards,
Jon LoBue



[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 488 bytes --]