From: Jonathan LoBue <jlobue10@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: jagathjog1996@gmail.com, luke@ljones.dev,
benato.denis96@gmail.com, linux-iio@vger.kernel.org,
Andy Shevchenko <andy.shevchenko@gmail.com>,
lkml@antheas.dev
Subject: Re: [PATCH] iio: imu: bmi323: Support loading of bmi323 driver for ASUS ROG ALLY
Date: Sat, 10 Feb 2024 12:43:23 -0800 [thread overview]
Message-ID: <4923946.31r3eYUQgx@nobara-ally-pc> (raw)
In-Reply-To: <20240210164956.3d29e3ee@jic23-huawei>
[-- Attachment #1: Type: text/plain, Size: 1094 bytes --]
> It needs to be a compliant ACPI ID. BOSC is Bosch's valid manufacturer ID.
> The code after that tends to just be allocated by someone inside the company
> who keeps a bit list of IDs (I have access to the list of HiSilicon HISIXXXX ones for
> example but no idea how Bosch manages this.)
Understood. So if there isn't already a valid and unique identifier for
the BMI323 chip, then BOSCH must come up with one in that BOSCXXXX format.
Then ASUS should update the ACPI table with a BIOS update to use the
proper code for the BOSCH BMI323 chip. This is certainly the better long-term
solution. As it stands now, this proposed patch will get around the current
problem. If and when BOSCH and ASUS update the identifier, then the first
portion of this patch (unhooking from bmc150) could be removed. Then the
ACPI match table added in the BMI323 driver would just need to be updated
to reflect the proper code for the BOSCH BMI323 chip.
> Sure. Please also wrap your emails to the mailing list to under 80 chars (roughly).
Yes, sorry. Thank you for the guidance.
Best Regards,
Jon LoBue
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-02-10 20:43 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-09 16:05 [PATCH] iio: imu: bmi323: Support loading of bmi323 driver for ASUS ROG ALLY Jonathan LoBue
2024-02-10 15:25 ` Jonathan Cameron
2024-02-10 16:23 ` Jonathan LoBue
2024-02-10 16:49 ` Jonathan Cameron
2024-02-10 20:43 ` Jonathan LoBue [this message]
2024-02-10 22:32 ` [PATCH 1/2] iio: accel: bmc150: ASUS ROG ALLY Abort Loading Jonathan LoBue
2024-02-11 17:04 ` Andy Shevchenko
2024-02-12 7:21 ` Jonathan LoBue
2024-02-12 9:46 ` Andy Shevchenko
2024-02-13 2:39 ` [PATCH v1] iio: imu: bmi323: Add and enable ACPI Match Table Jonathan LoBue
2024-02-13 10:49 ` Andy Shevchenko
2024-02-13 17:14 ` Jonathan LoBue
2024-02-13 17:29 ` Andy Shevchenko
2024-02-13 22:38 ` [PATCH v2 1/2] iio: accel: bmc150: Duplicate ACPI entries Jonathan LoBue
2024-02-14 9:35 ` Andy Shevchenko
2024-02-14 15:07 ` Jonathan LoBue
2024-02-14 15:39 ` Andy Shevchenko
2024-02-14 16:16 ` Jonathan Cameron
2024-02-13 22:39 ` [PATCH v2 2/2] iio: imu: bmi323: Add and enable ACPI Match Table Jonathan LoBue
2024-02-14 9:39 ` Andy Shevchenko
2024-02-14 15:15 ` Jonathan LoBue
2024-02-14 15:31 ` Andy Shevchenko
2024-02-14 17:35 ` Jonathan LoBue
2024-02-14 18:21 ` Andy Shevchenko
2024-02-14 16:19 ` Jonathan Cameron
2024-02-13 2:47 ` [PATCH 1/2] iio: accel: bmc150: ASUS ROG ALLY Abort Loading Jonathan LoBue
2024-02-10 22:34 ` [PATCH 2/2] iio: imu: bmi323: Add and enable ACPI Match Table Jonathan LoBue
2024-02-11 16:31 ` Jonathan Cameron
2024-02-11 17:08 ` Andy Shevchenko
2024-02-12 7:30 ` Jonathan LoBue
2024-02-12 9:50 ` Andy Shevchenko
2024-02-12 17:33 ` Jonathan LoBue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4923946.31r3eYUQgx@nobara-ally-pc \
--to=jlobue10@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=benato.denis96@gmail.com \
--cc=jagathjog1996@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=lkml@antheas.dev \
--cc=luke@ljones.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox