Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan LoBue <jlobue10@gmail.com>
To: andy.shevchenko@gmail.com
Cc: hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com,
	jic23@kernel.org, jagathjog1996@gmail.com, luke@ljones.dev,
	benato.denis96@gmail.com, linux-iio@vger.kernel.org,
	lkml@antheas.dev, derekjohn.clark@gmail.com,
	Jonathan LoBue <jlobue10@gmail.com>
Subject: [PATCH v2 1/2] iio: accel: bmc150: Duplicate ACPI entries
Date: Tue, 13 Feb 2024 14:38:06 -0800	[thread overview]
Message-ID: <20240213223806.27056-1-jlobue10@gmail.com> (raw)
In-Reply-To: <CAHp75VfcHnswdXnqdtOkX31LbULu8Pa0WjM5EC96OuOBrZGTxA@mail.gmail.com>

This patch adds a description of the duplicate ACPI identifier issue
between devices using bmc150 and bmi323.

Co-developed-by: Jonathan LoBue <jlobue10@gmail.com>
Signed-off-by: Jonathan LoBue <jlobue10@gmail.com>
Co-developed-by: Luke D. Jones <luke@ljones.dev>
Signed-off-by: Luke D. Jones <luke@ljones.dev>
Co-developed-by: Denis Benato <benato.denis96@gmail.com>
Signed-off-by: Denis Benato <benato.denis96@gmail.com>
Co-developed-by: Antheas Kapenekakis <lkml@antheas.dev>
Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
---

Comment describing the duplicate ACPI identifier issue has been added
before the "BOSC0200" entry here.

 drivers/iio/accel/bmc150-accel-i2c.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/iio/accel/bmc150-accel-i2c.c b/drivers/iio/accel/bmc150-accel-i2c.c
index ee1ba134ad42..c831642a0e3d 100644
--- a/drivers/iio/accel/bmc150-accel-i2c.c
+++ b/drivers/iio/accel/bmc150-accel-i2c.c
@@ -13,6 +13,18 @@
 
 #include "bmc150-accel.h"
 
+/*
+ * The "BOSC0200" ACPI identifier used here in the bmc150 driver is not
+ * unique to devices using bmc150. The same "BOSC0200" identifier is found
+ * in the ACPI tables of the ASUS ROG ALLY and Ayaneo AIR Plus which both
+ * use a Bosch BMI323 chip. This creates a conflict with duplicate ACPI
+ * identifiers which multiple drivers want to use. Fortunately, when the
+ * bmc150 driver starts to load on the ASUS ROG ALLY, the chip id check
+ * portion fails (correctly) and a dmesg output similar to this:
+ * "bmc150_accel_i2c i2c-BOSC0200:00: Invalid chip 0" can be seen.
+ * This allows the bmi323 driver to take over for ASUS ROG ALLY.
+ */
+
 #ifdef CONFIG_ACPI
 static const struct acpi_device_id bmc150_acpi_dual_accel_ids[] = {
 	{"BOSC0200"},
-- 
2.43.0


  reply	other threads:[~2024-02-13 22:38 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-09 16:05 [PATCH] iio: imu: bmi323: Support loading of bmi323 driver for ASUS ROG ALLY Jonathan LoBue
2024-02-10 15:25 ` Jonathan Cameron
2024-02-10 16:23   ` Jonathan LoBue
2024-02-10 16:49     ` Jonathan Cameron
2024-02-10 20:43       ` Jonathan LoBue
2024-02-10 22:32         ` [PATCH 1/2] iio: accel: bmc150: ASUS ROG ALLY Abort Loading Jonathan LoBue
2024-02-11 17:04           ` Andy Shevchenko
2024-02-12  7:21             ` Jonathan LoBue
2024-02-12  9:46               ` Andy Shevchenko
2024-02-13  2:39                 ` [PATCH v1] iio: imu: bmi323: Add and enable ACPI Match Table Jonathan LoBue
2024-02-13 10:49                   ` Andy Shevchenko
2024-02-13 17:14                     ` Jonathan LoBue
2024-02-13 17:29                       ` Andy Shevchenko
2024-02-13 22:38                         ` Jonathan LoBue [this message]
2024-02-14  9:35                           ` [PATCH v2 1/2] iio: accel: bmc150: Duplicate ACPI entries Andy Shevchenko
2024-02-14 15:07                             ` Jonathan LoBue
2024-02-14 15:39                               ` Andy Shevchenko
2024-02-14 16:16                                 ` Jonathan Cameron
2024-02-13 22:39                         ` [PATCH v2 2/2] iio: imu: bmi323: Add and enable ACPI Match Table Jonathan LoBue
2024-02-14  9:39                           ` Andy Shevchenko
2024-02-14 15:15                             ` Jonathan LoBue
2024-02-14 15:31                               ` Andy Shevchenko
2024-02-14 17:35                                 ` Jonathan LoBue
2024-02-14 18:21                                   ` Andy Shevchenko
2024-02-14 16:19                           ` Jonathan Cameron
2024-02-13  2:47                 ` [PATCH 1/2] iio: accel: bmc150: ASUS ROG ALLY Abort Loading Jonathan LoBue
2024-02-10 22:34         ` [PATCH 2/2] iio: imu: bmi323: Add and enable ACPI Match Table Jonathan LoBue
2024-02-11 16:31           ` Jonathan Cameron
2024-02-11 17:08           ` Andy Shevchenko
2024-02-12  7:30             ` Jonathan LoBue
2024-02-12  9:50               ` Andy Shevchenko
2024-02-12 17:33                 ` Jonathan LoBue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240213223806.27056-1-jlobue10@gmail.com \
    --to=jlobue10@gmail.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=benato.denis96@gmail.com \
    --cc=derekjohn.clark@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jagathjog1996@gmail.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=lkml@antheas.dev \
    --cc=luke@ljones.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox