[PATCH] [PATCH] iio: chemical: sgp30: cleanup codestyle warning

[PATCH] [PATCH] iio: chemical: sgp30: cleanup codestyle warning

[Adi Nata]

Reported by checkpatch:
FILE: drivers/iio/chemical/sgp30.c
WARNING: Prefer __packed over __attribute__((__packed__))
+} __attribute__((__packed__));

Signed-off-by: Adi Nata <adinata.softwareengineer@gmail.com>
---
 drivers/iio/chemical/sgp30.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/chemical/sgp30.c b/drivers/iio/chemical/sgp30.c
index f10bbebc29e4..c33592a1e0c9 100644
--- a/drivers/iio/chemical/sgp30.c
+++ b/drivers/iio/chemical/sgp30.c
@@ -82,7 +82,7 @@ struct sgp_version {
 struct sgp_crc_word {
 	__be16 value;
 	u8 crc8;
-} __attribute__((__packed__));
+} __packed;
 
 union sgp_reading {
 	u8 start;
-- 
2.47.3

Re: [PATCH] [PATCH] iio: chemical: sgp30: cleanup codestyle warning

[Joshua Crofts]

On Fri, 24 Jul 2026 00:18:49 +0800
Adi Nata <adinata.softwareengineer@gmail.com> wrote:

> Reported by checkpatch:
> FILE: drivers/iio/chemical/sgp30.c
> WARNING: Prefer __packed over __attribute__((__packed__))
> +} __attribute__((__packed__));
> 
> Signed-off-by: Adi Nata <adinata.softwareengineer@gmail.com>
> ---

Same issues as with your previous patch. Additionally, the
subject contains two [PATCH] tags, perhaps you've used git
format-patch or git send-email incorrectly?

After fixing:

Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>

-- 
Kind regards,
Joshua Crofts

[PATCH v2] iio: chemical: sgp30: fix checkpatch warn to prefer __packed

[Adi Nata]

Change instance of __attribute__((__packed__)) to __packed per checkpatch.pl warning

Reported by checkpatch:
FILE: drivers/iio/chemical/sgp30.c
WARNING: Prefer __packed over __attribute__((__packed__))
+} __attribute__((__packed__));

Signed-off-by: Adi Nata <adinata.softwareengineer@gmail.com>

Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>

v2:
- Rename commit title and message

---
 drivers/iio/chemical/sgp30.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/chemical/sgp30.c b/drivers/iio/chemical/sgp30.c
index f10bbebc29e4..c33592a1e0c9 100644
--- a/drivers/iio/chemical/sgp30.c
+++ b/drivers/iio/chemical/sgp30.c
@@ -82,7 +82,7 @@ struct sgp_version {
 struct sgp_crc_word {
 	__be16 value;
 	u8 crc8;
-} __attribute__((__packed__));
+} __packed;
 
 union sgp_reading {
 	u8 start;
-- 
2.47.3

Re: [PATCH v2] iio: chemical: sgp30: fix checkpatch warn to prefer __packed

[Uwe Kleine-König]

[-- Attachment #1: Type: text/plain, Size: 1293 bytes --]

Hello,

Just a few nitpicks. These might not justify a v3, as Jonathan sometimes
fixes up such thing while applying.

On Sun, Aug 02, 2026 at 10:51:31AM +0800, Adi Nata wrote:
> Change instance of __attribute__((__packed__)) to __packed per checkpatch.pl warning
> 
> Reported by checkpatch:
> FILE: drivers/iio/chemical/sgp30.c
> WARNING: Prefer __packed over __attribute__((__packed__))
> +} __attribute__((__packed__));
> 
> Signed-off-by: Adi Nata <adinata.softwareengineer@gmail.com>
> 
> Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>

No empty lines in the S-o-B block, and please put your S-o-b last.

> v2:
> - Rename commit title and message

the v2 changelog belongs after the tripple dash.

> 
> ---
>  drivers/iio/chemical/sgp30.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/chemical/sgp30.c b/drivers/iio/chemical/sgp30.c
> index f10bbebc29e4..c33592a1e0c9 100644
> --- a/drivers/iio/chemical/sgp30.c
> +++ b/drivers/iio/chemical/sgp30.c
> @@ -82,7 +82,7 @@ struct sgp_version {
>  struct sgp_crc_word {
>  	__be16 value;
>  	u8 crc8;
> -} __attribute__((__packed__));
> +} __packed;

Otherwise looks fine.

Acked-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]