Linux Input/HID development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: rofikkerneldev <rofikcoga@gmail.com>
Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-input@vger.kernel.org, robh@kernel.org,
	conor+dt@kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH v1 03/11] arm64: dts: qcom: sm8250-lge-timelm: add reserved memory regions
Date: Tue, 17 Nov 2026 12:57:40 +0000	[thread overview]
Message-ID: <sashiko-outbox-218814@kernel.org> (raw)
In-Reply-To: <20261117123946.668557-4-rofikcoga@gmail.com>

Thank you for your contribution! Sashiko AI review found 4 potential
issues to consider:
- [High] arm64: dts: qcom: Signed-off-by and Author use handle instead
  of real name
- [Medium] arm64: dts: qcom: sm8250-lge-timelm: ramoops sub-buffers
  leave 0 bytes for dmesg
- [Low] arm64: dts: qcom: sm8250-lge-timelm: changelog omits
  cont_splash_mem and ramoops
- [Low] arm64: dts: qcom: sm8250-lge-timelm: reserved-memory nodes not
  sorted by address
--

commit d0da8e8448ef005db2a8bdee2ccfef831c824926
Author: rofikkerneldev <rofikcoga@gmail.com>

> arm64: dts: qcom: sm8250-lge-timelm: add reserved memory regions
>
> Reserve the XBL/UEFI log and DFPS data regions used by the firmware.
> Keep these regions protected from kernel reuse.
>
> Signed-off-by: rofikkerneldev <rofikcoga@gmail.com>

[Severity: High]
The Author header, Signed-off-by trailer, and file copyright header in
sm8250-lge-timelm.dts use the handle "rofikkerneldev" instead of a real
human name, which does not meet the Developer's Certificate of Origin
requirements in Documentation/process/submitting-patches.rst.

> diff --git a/arch/arm64/boot/dts/qcom/sm8250-lge-timelm.dts b/arch/arm64/boot/dts/qcom/sm8250-lge-timelm.dts
> index 74b673ebbeb9d..ecbff27976fc2 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250-lge-timelm.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8250-lge-timelm.dts
> @@ -103,6 +103,12 @@ ramoops: ramoops@b0000000 {
>  			console-size = <0x40000>;
>  			ftrace-size = <0x40000>;
>  			pmsg-size = <0x200000>;
> +			no-map;
> +		};

[Severity: Medium]
Does ramoops@b0000000 leave any space for record-size = <0x1000>?

The node sets reg = <0x0 0xb0000000 0x0 0x280000>, and console-size
(0x40000), ftrace-size (0x40000), and pmsg-size (0x200000) already sum to
the full 0x280000 bytes. In ramoops_probe(), dump_mem_sz is computed as
cxt->size - cxt->console_size - cxt->ftrace_size - cxt->pmsg_size, which
evaluates to 0 and causes ramoops_init_przs() to skip registering dmesg
crash dump zones (PSTORE_FLAGS_DMESG).

> +
> +		res_xbl_uefi_log_region: memory@80880000 {
> +			reg = <0x0 0x80880000 0x0 0x14000>;
> +			no-map;
>  		};
>  
>  		adsp_mem: memory@8a100000 {

[Severity: Low]
This isn't a bug, but ramoops@b0000000 is placed ahead of memory@80880000
and the other lower-addressed child nodes under /reserved-memory instead
of being sorted in ascending unit-address order.

> @@ -119,6 +125,16 @@ cdsp_secure_heap: memory@8c700000 {
>  			reg = <0x0 0x8c700000 0x0 0x4600000>;
>  			no-map;
>  		};
> +
> +		cont_splash_mem: memory@9c000000 {
> +			reg = <0x0 0x9c000000 0x0 0x1200000>;
> +			no-map;
> +		};
> +
> +		dfps_data_mem: memory@9e300000 {
> +			reg = <0x0 0x9e300000 0x0 0x100000>;
> +			no-map;
> +		};
>  	};
>  
>  	vph_pwr: vph-pwr-regulator {

[Severity: Low]
The commit message mentions only the XBL/UEFI log and DFPS data regions,
omitting the addition of cont_splash_mem: memory@9c000000 and the no-map
property on ramoops@b0000000. In addition, both /chosen/framebuffer@9c000000
and ramoops@b0000000 were introduced in the preceding commit "arm64: dts:
qcom: add LG V60 ThinQ 5G (timelm) support", so folding these reservations
(and referencing &cont_splash_mem from framebuffer@9c000000) into the
initial board commit would avoid leaving the framebuffer unreserved across
commits in the series.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117123946.668557-1-rofikcoga@gmail.com?part=3

  reply	other threads:[~2026-11-17 12:57 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 12:39 [PATCH v1 00/11] arm64: qcom: Add initial support for LG V60 ThinQ 5G (timelm) rofikkerneldev
2026-11-17 12:39 ` [PATCH v1 01/11] dt-bindings: arm: qcom: add " rofikkerneldev
2026-11-17 12:47   ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 02/11] arm64: dts: qcom: add LG V60 ThinQ 5G (timelm) support rofikkerneldev
2026-11-17 13:06   ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 03/11] arm64: dts: qcom: sm8250-lge-timelm: add reserved memory regions rofikkerneldev
2026-11-17 12:57   ` sashiko-bot [this message]
2026-11-17 12:39 ` [PATCH v1 04/11] dt-bindings: display: panel: add LG SW43103 rofikkerneldev
2026-11-17 12:51   ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 05/11] drm/panel: add LG SW43103 panel driver rofikkerneldev
2026-11-17 13:04   ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 06/11] dt-bindings: input: touchscreen: add Silicon Works SW42902 rofikkerneldev
2026-11-17 12:51   ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 07/11] Input: touchscreen: add Silicon Works SW42902 support rofikkerneldev
2026-11-17 13:01   ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 08/11] arm64: dts: qcom: sm8250-lge-timelm: enable SW43103 panel rofikkerneldev
2026-11-17 13:12   ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 09/11] arm64: dts: qcom: sm8250-lge-timelm: add SW42902 touchscreen rofikkerneldev
2026-11-17 12:56   ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 10/11] arm64: dts: qcom: sm8250-lge-timelm: enable USB Type-C rofikkerneldev
2026-11-17 13:12   ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 11/11] arm64: dts: qcom: sm8250-lge-timelm: add QCA6390 Bluetooth rofikkerneldev
2026-11-17 13:09   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-218814@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-input@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=rofikcoga@gmail.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox