Linux Input/HID development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: rofikkerneldev <rofikcoga@gmail.com>
Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-input@vger.kernel.org, robh@kernel.org,
	conor+dt@kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH v1 02/11] arm64: dts: qcom: add LG V60 ThinQ 5G (timelm) support
Date: Tue, 17 Nov 2026 13:06:14 +0000	[thread overview]
Message-ID: <sashiko-outbox-218836@kernel.org> (raw)
In-Reply-To: <20261117123946.668557-3-rofikcoga@gmail.com>

Thank you for your contribution! Sashiko AI review found 8 potential
issues to consider:
- [High] arm64: dts: qcom: timelm: enabling gpu without gmu fails
  a6xx_gmu_init()
- [High] arm64: dts: qcom: timelm: invalid 1.05V constraint on PM8009
  ldo4
- [High] arm64: dts: qcom: handle used instead of real name in DCO and
  MAINTAINERS
- [Medium] arm64: dts: qcom: timelm: swapped vdda-phy and vdda-pll on
  usb_1_qmpphy
- [Medium] arm64: dts: qcom: timelm: missing pinctrl states on sdhc_2
  node
- [Medium] arm64: dts: qcom: ramoops sub-buffers exhaust region and
  disable dmesg dumps
- [Low] arm64: dts: qcom: missing DRMS properties on UFS supply
  regulators
- [Low] arm64: dts: qcom: unused dt-bindings headers in
  sm8250-lge-timelm.dts
--

commit e0c6ddf610453315a993fcf369aad59d6f783910
Author: rofikkerneldev <rofikcoga@gmail.com>

arm64: dts: qcom: add LG V60 ThinQ 5G (timelm) support

This commit adds initial device tree support and a MAINTAINERS entry for
the Qualcomm SM8250-based LG V60 ThinQ 5G (timelm) smartphone.

> diff --git a/MAINTAINERS b/MAINTAINERS
> index 222b7fc2c3aab..c88fc0e019296 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -15231,6 +15231,12 @@ Q:	http://patchwork.linuxtv.org/project/linux-media/list/
>  T:	git git://linuxtv.org/mkrufky/tuners.git
>  F:	drivers/media/dvb-frontends/lgdt3305.*
>  
> +LG V60 THINQ 5G (TIMELM) SUPPORT
> +M:	rofikkerneldev <rofikcoga@gmail.com>
> +L:	linux-arm-msm@vger.kernel.org
> +S:	Maintained
> +F:	arch/arm64/boot/dts/qcom/sm8250-lge-timelm*
> +
>  LIBATA PATA ARASAN COMPACT FLASH CONTROLLER
>  M:	Viresh Kumar <vireshk@kernel.org>
>  L:	linux-ide@vger.kernel.org

[Severity: High]
The MAINTAINERS entry, commit author, Signed-off-by trailer, and
sm8250-lge-timelm.dts copyright header use the account handle
rofikkerneldev instead of a real name, which does not satisfy the
Developer's Certificate of Origin in
Documentation/process/submitting-patches.rst.

> diff --git a/arch/arm64/boot/dts/qcom/sm8250-lge-timelm.dts b/arch/arm64/boot/dts/qcom/sm8250-lge-timelm.dts
> new file mode 100644
> index 0000000000000..74b673ebbeb9d
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sm8250-lge-timelm.dts
> @@ -0,0 +1,543 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2026 rofikkerneldev <rofikcoga@gmail.com>
> + * Device Tree for LG V60 ThinQ 5G (timelm / LM-V600)
> + */
> +
> +/dts-v1/;
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/input/input.h>
> +#include <dt-bindings/leds/common.h>
> +#include <dt-bindings/phy/phy.h>
> +#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> +#include <dt-bindings/sound/qcom,q6afe.h>
> +#include <dt-bindings/sound/qcom,q6asm.h>
> +#include <dt-bindings/usb/pd.h>

[Severity: Low]
This isn't a bug, but dt-bindings/leds/common.h,
dt-bindings/sound/qcom,q6afe.h, and dt-bindings/sound/qcom,q6asm.h are
unused throughout the series, while dt-bindings/phy/phy.h and
dt-bindings/usb/pd.h are only needed starting in commit "arm64: dts: qcom:
sm8250-lge-timelm: enable SW43103 panel" and commit "arm64: dts: qcom:
sm8250-lge-timelm: enable USB Type-C".

[ ... ]

> +	reserved-memory {
> +		ramoops: ramoops@b0000000 {
> +			compatible = "ramoops";
> +			reg = <0x0 0xb0000000 0x0 0x280000>;
> +			record-size = <0x1000>;
> +			console-size = <0x40000>;
> +			ftrace-size = <0x40000>;
> +			pmsg-size = <0x200000>;
> +		};

[Severity: Medium]
Does ramoops@b0000000 leave any space for record-size?

console-size (0x40000), ftrace-size (0x40000), and pmsg-size (0x200000)
consume the entire 0x280000 region, so ramoops_probe() computes
dump_mem_sz as 0 and disables dmesg oops and panic dumps.  While commit
"arm64: dts: qcom: sm8250-lge-timelm: add reserved memory regions" adds
no-map to this node, the sizes remain unchanged.

[ ... ]

> +	regulators-2 {
> +		compatible = "qcom,pm8009-rpmh-regulators";
> +		qcom,pmic-id = "f";
> +
> +		vdd-s1-supply = <&vph_pwr>;
> +		vdd-s2-supply = <&vreg_bob>;
> +		vdd-l2-supply = <&vreg_s8c_1p2>;
> +		vdd-l5-l6-supply = <&vreg_bob>;
> +		vdd-l7-supply = <&vreg_s4a_1p8>;
> +
> +		vreg_s1f_1p2: smps1 {
> +			regulator-name = "vreg_s1f_1p2";
> +			regulator-min-microvolt = <1200000>;
> +			regulator-max-microvolt = <1200000>;
> +			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> +		};
> +
> +		vreg_s2f_0p5: smps2 {
> +			regulator-name = "vreg_s2f_0p5";
> +			regulator-min-microvolt = <512000>;
> +			regulator-max-microvolt = <1100000>;
> +			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> +		};
> +
> +		vreg_l2f_1p3: ldo2 {
> +			regulator-name = "vreg_l2f_1p3";
> +			regulator-min-microvolt = <1304000>;
> +			regulator-max-microvolt = <1304000>;
> +			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> +		};
> +
> +		vreg_l4f_1p05: ldo4 {
> +			regulator-name = "vreg_l4f_1p05";
> +			regulator-min-microvolt = <1050000>;
> +			regulator-max-microvolt = <1050000>;
> +			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> +		};

[Severity: High]
Does vreg_l4f_1p05 cause rpmh_regulator_probe() to fail for the entire
regulators-2 node?

In pm8009_vreg_data, ldo4 uses pmic5_nldo, which has a 320000 uV base and
an 8000 uV step.  Because 1050000 uV lies between the 1048000 uV and
1056000 uV steps, machine_constraints_voltage() returns -EINVAL and aborts
registration of all PM8009 regulators in regulators-2.  In addition,
regulators-2 omits vdd-l4-supply.

[ ... ]

> +&gpu {
> +	status = "okay";
> +
> +	zap-shader {
> +		memory-region = <&gpu_mem>;
> +		firmware-name = "qcom/sm8250/a650_zap.mbn";
> +	};
> +};

[Severity: High]
Does enabling &gpu without enabling &gmu cause GPU initialization to fail?

In sm8250.dtsi, gmu has status = "disabled" by default, so no platform
device is created for it and a6xx_gpu_init() -> a6xx_gmu_init() returns
-ENODEV.  Also, memory-region = <&gpu_mem> is already set on
gpu_zap_shader in sm8250.dtsi.

[ ... ]

> +&ufs_mem_hc {
> +	status = "okay";
> +
> +	vcc-supply = <&vreg_l17a_3p0>;
> +	vcc-max-microamp = <800000>;
> +	vccq-supply = <&vreg_l6a_1p2>;
> +	vccq-max-microamp = <800000>;
> +	vccq2-supply = <&vreg_s4a_1p8>;
> +	vccq2-max-microamp = <800000>;
> +};

[Severity: Low]
Should vreg_l17a_3p0, vreg_l6a_1p2, and vreg_s4a_1p8 set
regulator-allow-set-load and regulator-allowed-modes?

Without those properties on the regulator nodes, the max-microamp limits
here have no effect when ufshcd calls regulator_set_load(), leaving the
three UFS rails in RPMH_REGULATOR_MODE_HPM during UFS low-power states.

[ ... ]

> +&sdhc_2 {
> +	status = "okay";
> +
> +	cd-gpios = <&tlmm 77 GPIO_ACTIVE_LOW>;
> +	vmmc-supply = <&vreg_l9c_2p9>;
> +	vqmmc-supply = <&vreg_l6c_2p9>;
> +	bus-width = <4>;
> +	no-sdio;
> +	no-mmc;
> +};

[Severity: Medium]
Should &sdhc_2 configure default and sleep pinctrl states?

sdhc_2 in sm8250.dtsi does not define pinctrl properties, so the SDCC2
pads (sdc2_clk, sdc2_cmd, sdc2_data) and card-detect pin (gpio77) are left
unconfigured by the kernel and will not transition to sdc2_sleep_state
across suspend and resume.

[ ... ]

> +&usb_1_qmpphy {
> +	status = "okay";
> +
> +	vdda-phy-supply = <&vreg_l9a_1p2>;
> +	vdda-pll-supply = <&vreg_l18a_0p9>;
> +};

[Severity: Medium]
Are vdda-phy-supply and vdda-pll-supply swapped on &usb_1_qmpphy?

On SM8250, the QMP PHY core rail (vdda-phy-supply) is powered by the 0.9V
vreg_l18a_0p9 regulator and the PLL rail (vdda-pll-supply) is powered by
the 1.2V vreg_l9a_1p2 regulator; swapping them applies the driver's
21800 uA and 36000 uA load votes to the wrong LDOs.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117123946.668557-1-rofikcoga@gmail.com?part=2

  reply	other threads:[~2026-11-17 13:06 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 12:39 [PATCH v1 00/11] arm64: qcom: Add initial support for LG V60 ThinQ 5G (timelm) rofikkerneldev
2026-11-17 12:39 ` [PATCH v1 01/11] dt-bindings: arm: qcom: add " rofikkerneldev
2026-11-17 12:47   ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 02/11] arm64: dts: qcom: add LG V60 ThinQ 5G (timelm) support rofikkerneldev
2026-11-17 13:06   ` sashiko-bot [this message]
2026-11-17 12:39 ` [PATCH v1 03/11] arm64: dts: qcom: sm8250-lge-timelm: add reserved memory regions rofikkerneldev
2026-11-17 12:57   ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 04/11] dt-bindings: display: panel: add LG SW43103 rofikkerneldev
2026-11-17 12:51   ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 05/11] drm/panel: add LG SW43103 panel driver rofikkerneldev
2026-11-17 13:04   ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 06/11] dt-bindings: input: touchscreen: add Silicon Works SW42902 rofikkerneldev
2026-11-17 12:51   ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 07/11] Input: touchscreen: add Silicon Works SW42902 support rofikkerneldev
2026-11-17 13:01   ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 08/11] arm64: dts: qcom: sm8250-lge-timelm: enable SW43103 panel rofikkerneldev
2026-11-17 13:12   ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 09/11] arm64: dts: qcom: sm8250-lge-timelm: add SW42902 touchscreen rofikkerneldev
2026-11-17 12:56   ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 10/11] arm64: dts: qcom: sm8250-lge-timelm: enable USB Type-C rofikkerneldev
2026-11-17 13:12   ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 11/11] arm64: dts: qcom: sm8250-lge-timelm: add QCA6390 Bluetooth rofikkerneldev
2026-11-17 13:09   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-218836@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-input@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=rofikcoga@gmail.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox