Linux Input/HID development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: rofikkerneldev <rofikcoga@gmail.com>
Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-input@vger.kernel.org, robh@kernel.org,
	conor+dt@kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH v1 11/11] arm64: dts: qcom: sm8250-lge-timelm: add QCA6390 Bluetooth
Date: Tue, 17 Nov 2026 13:09:13 +0000	[thread overview]
Message-ID: <sashiko-outbox-218840@kernel.org> (raw)
In-Reply-To: <20261117123946.668557-12-rofikcoga@gmail.com>

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [High] arm64: dts: qcom: non-real-name handle in Signed-off-by trailer
- [High] arm64: dts: qcom: sm8250-lge-timelm: under-volted QCA6390 PMU
  supplies
--

commit c689e882729fccea2deb0c720da66bf756537580
Author: rofikkerneldev <rofikcoga@gmail.com>

> arm64: dts: qcom: sm8250-lge-timelm: add QCA6390 Bluetooth
>
> Describe the QCA6390 power sequencer and its PMU regulators. Enable the
> Bluetooth HCI controller on GENI UART6 with the supplies provided by the
> PMU.
>
> Signed-off-by: rofikkerneldev <rofikcoga@gmail.com>

[Severity: High]
The Author header and Signed-off-by trailer use an account handle
(rofikkerneldev) instead of a known real human name, which does not meet
the Developer's Certificate of Origin requirements in
Documentation/process/submitting-patches.rst.

> diff --git a/arch/arm64/boot/dts/qcom/sm8250-lge-timelm.dts b/arch/arm64/boot/dts/qcom/sm8250-lge-timelm.dts
> index 6b57c658cf918..38816268fcf53 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250-lge-timelm.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8250-lge-timelm.dts
> @@ -95,6 +95,67 @@ key-assistant {
>  		};
>  	};
>  
> +	qca6390-pmu {
> +		compatible = "qcom,qca6390-pmu";
> +
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&bt_en_state>, <&wlan_en_state>;
> +
> +		vddaon-supply = <&vreg_s6a_0p6>;
> +		vddpmu-supply = <&vreg_s6a_0p6>;
> +		vddrfa0p95-supply = <&vreg_s6a_0p6>;
> +		vddrfa1p3-supply = <&vreg_s8c_1p2>;
> +		vddrfa1p9-supply = <&vreg_s5a_1p9>;
> +		vddpcie1p3-supply = <&vreg_s8c_1p2>;
> +		vddpcie1p9-supply = <&vreg_s5a_1p9>;
> +		vddio-supply = <&vreg_s4a_1p8>;

[Severity: High]
Does wiring vddaon-supply, vddpmu-supply and vddrfa0p95-supply to
vreg_s6a_0p6, and vddrfa1p3-supply and vddpcie1p3-supply to vreg_s8c_1p2,
under-volt the QCA6390 PMU?

pwrseq-qcom-wcn only enables these regulators without calling
regulator_set_voltage(), so the RPMh regulator driver initializes them to
their regulator-min-microvolt constraints when enabled.  In this board DT,
vreg_s6a_0p6 has regulator-min-microvolt = <600000> and vreg_s8c_1p2 has
regulator-min-microvolt = <1200000>, with no other consumer voting a higher
voltage.  That drives the 0.95V PMU inputs at 0.6V (below the PMU's own
0.8V and 0.85V LDO outputs) and the 1.35V inputs at 1.2V.  Should the
minimum voltages on smps6 and smps8 be raised to ~950000 uV and ~1350000 uV
like on other SM8250 QCA6390 boards?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117123946.668557-1-rofikcoga@gmail.com?part=11

      reply	other threads:[~2026-11-17 13:09 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 12:39 [PATCH v1 00/11] arm64: qcom: Add initial support for LG V60 ThinQ 5G (timelm) rofikkerneldev
2026-11-17 12:39 ` [PATCH v1 01/11] dt-bindings: arm: qcom: add " rofikkerneldev
2026-11-17 12:47   ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 02/11] arm64: dts: qcom: add LG V60 ThinQ 5G (timelm) support rofikkerneldev
2026-11-17 13:06   ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 03/11] arm64: dts: qcom: sm8250-lge-timelm: add reserved memory regions rofikkerneldev
2026-11-17 12:57   ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 04/11] dt-bindings: display: panel: add LG SW43103 rofikkerneldev
2026-11-17 12:51   ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 05/11] drm/panel: add LG SW43103 panel driver rofikkerneldev
2026-11-17 13:04   ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 06/11] dt-bindings: input: touchscreen: add Silicon Works SW42902 rofikkerneldev
2026-11-17 12:51   ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 07/11] Input: touchscreen: add Silicon Works SW42902 support rofikkerneldev
2026-11-17 13:01   ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 08/11] arm64: dts: qcom: sm8250-lge-timelm: enable SW43103 panel rofikkerneldev
2026-11-17 13:12   ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 09/11] arm64: dts: qcom: sm8250-lge-timelm: add SW42902 touchscreen rofikkerneldev
2026-11-17 12:56   ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 10/11] arm64: dts: qcom: sm8250-lge-timelm: enable USB Type-C rofikkerneldev
2026-11-17 13:12   ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 11/11] arm64: dts: qcom: sm8250-lge-timelm: add QCA6390 Bluetooth rofikkerneldev
2026-11-17 13:09   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-218840@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-input@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=rofikcoga@gmail.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox