From: sashiko-bot@kernel.org
To: rofikkerneldev <rofikcoga@gmail.com>
Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-input@vger.kernel.org, robh@kernel.org,
conor+dt@kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH v1 08/11] arm64: dts: qcom: sm8250-lge-timelm: enable SW43103 panel
Date: Tue, 17 Nov 2026 13:12:36 +0000 [thread overview]
Message-ID: <sashiko-outbox-218846@kernel.org> (raw)
In-Reply-To: <20261117123946.668557-9-rofikcoga@gmail.com>
Thank you for your contribution! Sashiko AI review found 5 potential
issues to consider:
- [High] arm64: dts: qcom: Signed-off-by and Author use handle
rofikkerneldev
- [High] arm64: dts: qcom: enabling mdss with gmu disabled breaks
a6xx_gmu_init()
- [Medium] arm64: dts: qcom: missing enable-gpios in sm8250-lge-timelm
panel@0 node
- [Medium] drm/panel: sw43103_remove() calls sw43103_unprepare()
unconditionally
- [Low] arm64: dts: qcom: redundant dispcc status and unsorted mdss
nodes
--
commit 3038d85d6373aad3b6104c371b0b0d8abde1a320
Author: rofikkerneldev <rofikcoga@gmail.com>
> arm64: dts: qcom: sm8250-lge-timelm: enable SW43103 panel
>
> Enable DISPCC, MDSS, DSI0, and its PHY. Attach the SW43103 panel with
> its power rails, reset GPIO, and four-lane DSI link.
>
> Signed-off-by: rofikkerneldev <rofikcoga@gmail.com>
[Severity: High]
The Author header and Signed-off-by trailer use an account handle
(rofikkerneldev) instead of a real human name, which does not meet the
Developer Certificate of Origin requirements in
Documentation/process/submitting-patches.rst.
> diff --git a/arch/arm64/boot/dts/qcom/sm8250-lge-timelm.dts b/arch/arm64/boot/dts/qcom/sm8250-lge-timelm.dts
> index ecbff27976fc2..fca48472f5dfe 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250-lge-timelm.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8250-lge-timelm.dts
> @@ -557,3 +557,42 @@ &usb_1_qmpphy {
> vdda-phy-supply = <&vreg_l9a_1p2>;
> vdda-pll-supply = <&vreg_l18a_0p9>;
> };
> +
> +&dispcc {
> + status = "okay";
> +};
[Severity: Low]
This isn't a bug, but dispcc in arch/arm64/boot/dts/qcom/sm8250.dtsi is
already enabled by default, so this status override is redundant. Also,
board-level label overrides in Qualcomm device trees are sorted
alphabetically, so the &mdss* nodes below belong between &gpu and
&pm8150_gpios rather than after &usb_1_qmpphy.
> +
> +&mdss {
> + status = "okay";
> +};
[Severity: High]
Does enabling &mdss fail to bind the DRM device because &gmu is still
disabled?
In sm8250-lge-timelm.dts, &gpu is enabled, while gmu in sm8250.dtsi
defaults to status = "disabled" and is never enabled by the board DTS.
When dpu_dev_probe() calls msm_drv_probe(), add_gpu_components() includes
the GPU in the DRM component master match list alongside mdss_dsi0.
During component_bind_all() in msm_drm_init(), adreno_bind() ->
a6xx_gpu_init() -> a6xx_gmu_init() looks up the GMU platform device via
of_find_device_by_node(), which returns NULL because the gmu node is
disabled. a6xx_gmu_init() returns -ENODEV, aborting component_bind_all()
and preventing both the display controller and the SW43103 panel from
initializing unless &gmu is also enabled.
> +
> +&mdss_dsi0 {
> + vdda-supply = <&vreg_l9a_1p2>;
> + status = "okay";
> +
> + panel@0 {
> + compatible = "lg,sw43103";
[Severity: Medium]
Does instantiating "lg,sw43103" expose an unbalanced regulator disable in
sw43103_remove() on driver unbind or module unload?
drivers/gpu/drm/panel/panel-lg-sw43103.c:sw43103_remove() {
ret = sw43103_unprepare(&ctx->base);
if (ret < 0)
dev_err(&dsi->dev, "failed to unprepare panel: %d\n", ret);
ret = mipi_dsi_detach(dsi);
if (ret < 0)
dev_err(&dsi->dev, "failed to detach from DSI host: %d\n", ret);
drm_panel_remove(&ctx->base);
}
Calling the raw sw43103_unprepare() callback directly bypasses
drm_panel_unprepare() and ctx->base.prepared tracking, unconditionally
calling regulator_bulk_disable() on vddi and vpnl. If the panel is
already unprepared, this underflows the regulator enable count and
triggers a WARN in _regulator_disable(). If the panel is prepared and
enabled, sw43103_unprepare() asserts reset and cuts power while
ctx->base.prepared remains true, before mipi_dsi_detach() triggers DRM
atomic shutdown to send MIPI DSI commands and call drm_panel_unprepare()
a second time.
> + reg = <0>;
> +
> + vddi-supply = <&vreg_l14a_1p8>;
> + vpnl-supply = <&vreg_l11c_3p0>;
> + reset-gpios = <&tlmm 75 GPIO_ACTIVE_LOW>;
[Severity: Medium]
Should this panel node also specify enable-gpios = <&pm8150l_gpios 4
GPIO_ACTIVE_HIGH>?
The binding example for the timelm panel in
Documentation/devicetree/bindings/display/panel/lg,sw43103.yaml specifies
that GPIO alongside the same vddi-supply, vpnl-supply, and reset-gpios.
Without enable-gpios here, devm_gpiod_get_optional(dev, "enable",
GPIOD_OUT_LOW) in panel-lg-sw43103 returns NULL, and sw43103_prepare() and
sw43103_unprepare() never toggle the panel's PM8150L GPIO 4 enable line
across display power cycles.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117123946.668557-1-rofikcoga@gmail.com?part=8
next prev parent reply other threads:[~2026-11-17 13:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 12:39 [PATCH v1 00/11] arm64: qcom: Add initial support for LG V60 ThinQ 5G (timelm) rofikkerneldev
2026-11-17 12:39 ` [PATCH v1 01/11] dt-bindings: arm: qcom: add " rofikkerneldev
2026-11-17 12:47 ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 02/11] arm64: dts: qcom: add LG V60 ThinQ 5G (timelm) support rofikkerneldev
2026-11-17 13:06 ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 03/11] arm64: dts: qcom: sm8250-lge-timelm: add reserved memory regions rofikkerneldev
2026-11-17 12:57 ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 04/11] dt-bindings: display: panel: add LG SW43103 rofikkerneldev
2026-11-17 12:51 ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 05/11] drm/panel: add LG SW43103 panel driver rofikkerneldev
2026-11-17 13:04 ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 06/11] dt-bindings: input: touchscreen: add Silicon Works SW42902 rofikkerneldev
2026-11-17 12:51 ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 07/11] Input: touchscreen: add Silicon Works SW42902 support rofikkerneldev
2026-11-17 13:01 ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 08/11] arm64: dts: qcom: sm8250-lge-timelm: enable SW43103 panel rofikkerneldev
2026-11-17 13:12 ` sashiko-bot [this message]
2026-11-17 12:39 ` [PATCH v1 09/11] arm64: dts: qcom: sm8250-lge-timelm: add SW42902 touchscreen rofikkerneldev
2026-11-17 12:56 ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 10/11] arm64: dts: qcom: sm8250-lge-timelm: enable USB Type-C rofikkerneldev
2026-11-17 13:12 ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 11/11] arm64: dts: qcom: sm8250-lge-timelm: add QCA6390 Bluetooth rofikkerneldev
2026-11-17 13:09 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-218846@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-input@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rofikcoga@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox