Re: [PATCH v5 07/14] iommu/amd: Add support for page response

[Jason Gunthorpe <jgg@ziepe.ca>]

On Thu, Jan 18, 2024 at 07:33:32AM +0000, Vasant Hegde wrote:

> diff --git a/drivers/iommu/amd/ppr.c b/drivers/iommu/amd/ppr.c
> index 1eb0b737afb5..b1751eb495fd 100644
> --- a/drivers/iommu/amd/ppr.c
> +++ b/drivers/iommu/amd/ppr.c
> @@ -148,3 +148,18 @@ void amd_iommu_iopf_uninit(struct amd_iommu *iommu)
>  
>  	raw_spin_unlock_irqrestore(&iommu->lock, flags);
>  }
> +
> +int amd_iommu_page_response(struct device *dev,
> +			    struct iopf_fault *evt,
> +			    struct iommu_page_response *resp)
> +{
> +	struct pci_dev *pdev;
> +
> +	if (!dev || !dev_is_pci(dev))
> +		return -ENODEV;
> +
> +	pdev = to_pci_dev(dev);
> +
> +	return amd_iommu_complete_ppr(pdev, resp->pasid, resp->code,
> +				      resp->grpid);

Converting this to a pci_dev seems pointless? Nothing reaches into the
PCI struct. Why do it?

We don't need sanity checking here on the fast path..

Jason