Re: [PATCH v2 11/16] iommu/amd: Rename ats related variables

[Vasant Hegde <vasant.hegde@amd.com>]

Hi Jason,

On 7/28/2023 7:57 PM, Jason Gunthorpe wrote:
> On Fri, Jul 28, 2023 at 05:36:04AM +0000, Vasant Hegde wrote:
>> Remove nested structure and make it as 'ats_{enable/qdep}'.
>>
>> No functional changes intended.
>>
>> Signed-off-by: Vasant Hegde <vasant.hegde@amd.com>
>> ---
>>  drivers/iommu/amd/amd_iommu_types.h |  6 ++----
>>  drivers/iommu/amd/iommu.c           | 26 +++++++++++++-------------
>>  2 files changed, 15 insertions(+), 17 deletions(-)
>>
>> diff --git a/drivers/iommu/amd/amd_iommu_types.h b/drivers/iommu/amd/amd_iommu_types.h
>> index bbb5ac4f0d39..a066f375ba87 100644
>> --- a/drivers/iommu/amd/amd_iommu_types.h
>> +++ b/drivers/iommu/amd/amd_iommu_types.h
>> @@ -816,10 +816,8 @@ struct iommu_dev_data {
>>  	struct device *dev;
>>  	u16 devid;			  /* PCI Device ID */
>>  	bool iommu_v2;			  /* Device can make use of IOMMUv2 */
>> -	struct {
>> -		bool enabled;
>> -		int qdep;
>> -	} ats;				  /* ATS state */
>> +	int  ats_qdep;
>> +	bool ats_enabled;		  /* ATS state */
>>  	bool pri_tlp;			  /* PASID TLB required for
>>  					     PPR completions */
>>  	bool use_vapic;			  /* Enable device to use vapic mode */
> 
> Linus does not like lists of bools like this, you should try to write
> it as
> 
> u8 ats_enabled:1;
> u8 pri_tlp:1;\

Ack. Will fix it in next version.

Thanks
-Vasant

> 
> etc
> 
> Otherwise it looks good
> 
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
> 
> Jason