public inbox for linux-kernel-mentees@lists.linux-foundation.org
 help / color / mirror / Atom feed
* [PATCH] hwmon: Documentation: Fix grammar in fan speed trip points explanation
@ 2024-11-07  1:38 Abhinav Saxena
  2024-11-08  0:52 ` Guenter Roeck
  0 siblings, 1 reply; 2+ messages in thread
From: Abhinav Saxena @ 2024-11-07  1:38 UTC (permalink / raw)
  To: linux-kernel-mentees, linux-hwmon, linux-doc, linux-kernel
  Cc: Jean Delvare, Guenter Roeck, Jonathan Corbet, Abhinav Saxena

Fix several grammatical issues in the fan speed trip points documentation:
- Replace awkward "which % the fan should run at at" construction with
 clearer "that specify the percentage at which"
- Fix incorrect "is chip depended" to "are chip dependent" for correct
 verb agreement and adjective form
- Improve readability by reorganizing first sentence and separating the
 complex explanation into simpler parts
- Add hyphen before "see" to improve readability
- Remove redundant "at" in temperature description

No functional changes, documentation only.

Signed-off-by: Abhinav Saxena <xandfury@gmail.com>
---
 Documentation/hwmon/f71882fg.rst | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/Documentation/hwmon/f71882fg.rst b/Documentation/hwmon/f71882fg.rst
index 38e30fbd4806..53d32bf06b70 100644
--- a/Documentation/hwmon/f71882fg.rst
+++ b/Documentation/hwmon/f71882fg.rst
@@ -178,10 +178,11 @@ Writing an unsupported mode will result in an invalid parameter error.
   available on the F71858FG / F8000 if the fan channel is in RPM mode.
 
 * 2: Normal auto mode
-  You can define a number of temperature/fan speed trip points, which % the
-  fan should run at at this temp and which temp a fan should follow using the
-  standard sysfs interface. The number and type of trip points is chip
-  depended, see which files are available in sysfs.
+  You can define a number of temperature/fan speed trip points that specify
+  the percentage at which the fan should run at each temperature, and which
+  temperature sensor a fan should follow, using the standard sysfs interface.
+  The number and type of trip points are chip dependent - see the available
+  files in sysfs.
   Fan/PWM channel 3 of the F8000 is always in this mode!
 
 * 3: Thermostat mode (Only available on the F8000 when in duty cycle mode)
-- 
2.37.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] hwmon: Documentation: Fix grammar in fan speed trip points explanation
  2024-11-07  1:38 [PATCH] hwmon: Documentation: Fix grammar in fan speed trip points explanation Abhinav Saxena
@ 2024-11-08  0:52 ` Guenter Roeck
  0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2024-11-08  0:52 UTC (permalink / raw)
  To: Abhinav Saxena
  Cc: linux-kernel-mentees, linux-hwmon, linux-doc, linux-kernel,
	Jean Delvare, Jonathan Corbet

On Wed, Nov 06, 2024 at 06:38:49PM -0700, Abhinav Saxena wrote:
> Fix several grammatical issues in the fan speed trip points documentation:
> - Replace awkward "which % the fan should run at at" construction with
>  clearer "that specify the percentage at which"
> - Fix incorrect "is chip depended" to "are chip dependent" for correct
>  verb agreement and adjective form
> - Improve readability by reorganizing first sentence and separating the
>  complex explanation into simpler parts
> - Add hyphen before "see" to improve readability
> - Remove redundant "at" in temperature description
> 
> No functional changes, documentation only.
> 
> Signed-off-by: Abhinav Saxena <xandfury@gmail.com>

Applied, after fixing the subject (which needs to include the affected
driver).

Thanks,
Guenter

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-11-08  0:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-07  1:38 [PATCH] hwmon: Documentation: Fix grammar in fan speed trip points explanation Abhinav Saxena
2024-11-08  0:52 ` Guenter Roeck

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox