From: Pavel Machek <pavel@ucw.cz>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: Marek Behun <marek.behun@nic.cz>, linux-leds@vger.kernel.org
Subject: Re: [PATCH RFC leds-next] leds: initial support for Turris Omnia LEDs
Date: Mon, 6 Apr 2020 23:08:03 +0200 [thread overview]
Message-ID: <20200406210802.GB12611@amd.ucw.cz> (raw)
In-Reply-To: <00b6737b-47f8-7ea4-74b7-eee3d2aefdf3@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1883 bytes --]
Hi!
> > I decided to abandon the microcontroller driver path.
> > But nonetheless there is still one thing I would like to solve.
> >
> > The front button on Omnia is used to control the global brightness of
> > the RGB LEDs, so that user can change it if the LEDs glow too much.
> > The microcontroller does this as such: there is another PWM on top of
> > all the LED PWMs, and this value can be manipulated via the same i2c
> > interface as the LEDs, but via another command.
> >
> > The thing is that I would like to somehow export this global brightness
> > setting to userspace, because otherwise it gets reset after reboot, and
> > I want the user to be able to set this global brightness by software,
> > so that they won't have to change it after every reboot manually by
> > pressing the front button.
> >
> > I am wondering how to do this. Last year I proposed this by adding a
> > sysfs attribute file to the device which is parent to the LEDs, but you
> > did not agree :(
This is really special feature, with button interaction. I don't
expect to see it elsewhere. Can you put it into /sys somewhere close
to the other controls for your platform? I have /proc/acpi/ibm on this
machine. It should not be /proc in new code, but you get the idea...
> I already proposed adding a "luma" LED class device for similar
> case [0], but didn't here any feedback from Pavel so far.
I dislike that. Luma is not really a color. Plus, this is different
case AFAICT, as global brightness affects all the LEDs at the same
time.
> [0]
> https://lore.kernel.org/linux-leds/1583502010-16210-1-git-send-email-nbelin@baylibre.com/T/#mf52c8d4f68260a445223c26957c61e6267e0932d
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2020-04-06 21:08 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 18:16 [PATCH RFC leds-next] leds: initial support for Turris Omnia LEDs Marek Behún
2020-03-21 15:33 ` Pavel Machek
2020-03-28 12:08 ` Jacek Anaszewski
2020-03-28 12:27 ` Marek Behun
2020-03-28 12:36 ` Marek Behun
2020-03-28 13:01 ` Jacek Anaszewski
2020-03-28 17:20 ` Marek Behun
2020-03-29 12:53 ` Jacek Anaszewski
2020-04-02 14:29 ` Marek Behun
2020-04-02 20:19 ` Jacek Anaszewski
2020-04-02 20:57 ` Marek Behun
2020-04-02 21:00 ` Jacek Anaszewski
2020-04-06 21:10 ` Pavel Machek
2020-04-06 21:08 ` Pavel Machek [this message]
2020-04-06 20:42 ` Pavel Machek
2020-03-21 15:34 ` Pavel Machek
2020-03-21 18:01 ` Jacek Anaszewski
2020-03-21 20:50 ` Marek Behun
2020-03-22 15:51 ` Jacek Anaszewski
2020-04-06 8:34 ` Pavel Machek
2020-04-06 13:53 ` Marek Behun
2020-03-21 18:55 ` Jacek Anaszewski
2020-03-21 20:44 ` Marek Behun
2020-03-22 15:28 ` Jacek Anaszewski
2020-03-21 21:53 ` Marek Behun
2020-03-21 22:16 ` Pavel Machek
2020-03-21 22:36 ` Marek Behun
2020-03-22 15:50 ` Dan Murphy
2020-04-06 8:40 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200406210802.GB12611@amd.ucw.cz \
--to=pavel@ucw.cz \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=marek.behun@nic.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox