From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: "Pavel Machek" <pavel@ucw.cz>, "Marek Behún" <marek.behun@nic.cz>
Cc: linux-leds@vger.kernel.org
Subject: Re: [PATCH RFC leds-next] leds: initial support for Turris Omnia LEDs
Date: Sat, 28 Mar 2020 13:08:02 +0100 [thread overview]
Message-ID: <943a5770-ea9c-24ac-5ab3-a9a24fc6a856@gmail.com> (raw)
In-Reply-To: <20200321153325.GD8386@duo.ucw.cz>
Hi Pavel.
On 3/21/20 4:33 PM, Pavel Machek wrote:
> Hi!
>
>> This adds basic support for LEDs on the front side of CZ.NIC's Turris
>> Omnia router.
>
> Looks good, I had to apply it by hand, by I took it. I realize that
> dts interface may not be final, but I do not want to solve Makefile
> rejects in future.
I don't think it is a good idea to merge it without bindings,
and with DT parser that will certainly undergo essential changes.
Besides, you appear as the commit author in your tree and moreover
the patch has a broken title. Also the commit message contains
DT bindings that will have different shape eventually.
NACK for merging this patch in this shape.
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2020-03-28 12:08 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 18:16 [PATCH RFC leds-next] leds: initial support for Turris Omnia LEDs Marek Behún
2020-03-21 15:33 ` Pavel Machek
2020-03-28 12:08 ` Jacek Anaszewski [this message]
2020-03-28 12:27 ` Marek Behun
2020-03-28 12:36 ` Marek Behun
2020-03-28 13:01 ` Jacek Anaszewski
2020-03-28 17:20 ` Marek Behun
2020-03-29 12:53 ` Jacek Anaszewski
2020-04-02 14:29 ` Marek Behun
2020-04-02 20:19 ` Jacek Anaszewski
2020-04-02 20:57 ` Marek Behun
2020-04-02 21:00 ` Jacek Anaszewski
2020-04-06 21:10 ` Pavel Machek
2020-04-06 21:08 ` Pavel Machek
2020-04-06 20:42 ` Pavel Machek
2020-03-21 15:34 ` Pavel Machek
2020-03-21 18:01 ` Jacek Anaszewski
2020-03-21 20:50 ` Marek Behun
2020-03-22 15:51 ` Jacek Anaszewski
2020-04-06 8:34 ` Pavel Machek
2020-04-06 13:53 ` Marek Behun
2020-03-21 18:55 ` Jacek Anaszewski
2020-03-21 20:44 ` Marek Behun
2020-03-22 15:28 ` Jacek Anaszewski
2020-03-21 21:53 ` Marek Behun
2020-03-21 22:16 ` Pavel Machek
2020-03-21 22:36 ` Marek Behun
2020-03-22 15:50 ` Dan Murphy
2020-04-06 8:40 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=943a5770-ea9c-24ac-5ab3-a9a24fc6a856@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=marek.behun@nic.cz \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox