From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Marek Behun <marek.behun@nic.cz>
Cc: Pavel Machek <pavel@ucw.cz>, linux-leds@vger.kernel.org
Subject: Re: [PATCH RFC leds-next] leds: initial support for Turris Omnia LEDs
Date: Sun, 22 Mar 2020 16:51:02 +0100 [thread overview]
Message-ID: <e6f20e72-0bfc-5fc1-839e-1283d8f15394@gmail.com> (raw)
In-Reply-To: <20200321215030.08b75ccc@nic.cz>
Marek,
On 3/21/20 9:50 PM, Marek Behun wrote:
> On Sat, 21 Mar 2020 19:01:15 +0100
> Jacek Anaszewski <jacek.anaszewski@gmail.com> wrote:
>
>>> How will this look in the /sys/class/leds?
>>>
>>> We don't want to see omnia:xxx:xx there. For the ethernet activity
>>> leds, it would be nice to get something like eth0:red:activity...?
>>
>> devicename and devicename_mandatory should be removed.
>>
>
> Without this I have:
>
> omnialeds /sys/class/leds # ls
> blue:power red:power white:lan-2 white:pci-1 white:user-1
> green:power white:lan-0 white:lan-3 white:pci-2 white:user-2
> mmc0:: white:lan-1 white:lan-4 white:pci-3 white:wan
You might want to associate the LED with actual eth interface,
as Pavel mentioned, but that would require some more work.
Anyway, "omnia" alone doesn't allow to tell the location of the
LED either.
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2020-03-22 15:51 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 18:16 [PATCH RFC leds-next] leds: initial support for Turris Omnia LEDs Marek Behún
2020-03-21 15:33 ` Pavel Machek
2020-03-28 12:08 ` Jacek Anaszewski
2020-03-28 12:27 ` Marek Behun
2020-03-28 12:36 ` Marek Behun
2020-03-28 13:01 ` Jacek Anaszewski
2020-03-28 17:20 ` Marek Behun
2020-03-29 12:53 ` Jacek Anaszewski
2020-04-02 14:29 ` Marek Behun
2020-04-02 20:19 ` Jacek Anaszewski
2020-04-02 20:57 ` Marek Behun
2020-04-02 21:00 ` Jacek Anaszewski
2020-04-06 21:10 ` Pavel Machek
2020-04-06 21:08 ` Pavel Machek
2020-04-06 20:42 ` Pavel Machek
2020-03-21 15:34 ` Pavel Machek
2020-03-21 18:01 ` Jacek Anaszewski
2020-03-21 20:50 ` Marek Behun
2020-03-22 15:51 ` Jacek Anaszewski [this message]
2020-04-06 8:34 ` Pavel Machek
2020-04-06 13:53 ` Marek Behun
2020-03-21 18:55 ` Jacek Anaszewski
2020-03-21 20:44 ` Marek Behun
2020-03-22 15:28 ` Jacek Anaszewski
2020-03-21 21:53 ` Marek Behun
2020-03-21 22:16 ` Pavel Machek
2020-03-21 22:36 ` Marek Behun
2020-03-22 15:50 ` Dan Murphy
2020-04-06 8:40 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6f20e72-0bfc-5fc1-839e-1283d8f15394@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=marek.behun@nic.cz \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox