From: Marek Behun <marek.behun@nic.cz>
To: linux-leds@vger.kernel.org
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH RFC leds-next] leds: initial support for Turris Omnia LEDs
Date: Sat, 21 Mar 2020 22:53:42 +0100 [thread overview]
Message-ID: <20200321225342.7651547b@nic.cz> (raw)
In-Reply-To: <20200319181604.2425-1-marek.behun@nic.cz>
Hmm.
The microcontroller on Turris Omnia supports more settings than just
LEDs (usb3 port power and input button for example).
I am wondering if this approach (registering LED driver to
communicate with the microcontroller) is correct, since the
microcontroller can do other things.
For Turris Mox firmware I created a driver in
drivers/firmware/turris-mox-rwtm.c.
Maybe I should create I driver in drivers/firmware/ for the Omnia
microcontroller, and then the LED driver could use functions exported
by the microcontroller driver to manipulate LEDs.
What do you think?
Marek
next prev parent reply other threads:[~2020-03-21 21:53 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 18:16 [PATCH RFC leds-next] leds: initial support for Turris Omnia LEDs Marek Behún
2020-03-21 15:33 ` Pavel Machek
2020-03-28 12:08 ` Jacek Anaszewski
2020-03-28 12:27 ` Marek Behun
2020-03-28 12:36 ` Marek Behun
2020-03-28 13:01 ` Jacek Anaszewski
2020-03-28 17:20 ` Marek Behun
2020-03-29 12:53 ` Jacek Anaszewski
2020-04-02 14:29 ` Marek Behun
2020-04-02 20:19 ` Jacek Anaszewski
2020-04-02 20:57 ` Marek Behun
2020-04-02 21:00 ` Jacek Anaszewski
2020-04-06 21:10 ` Pavel Machek
2020-04-06 21:08 ` Pavel Machek
2020-04-06 20:42 ` Pavel Machek
2020-03-21 15:34 ` Pavel Machek
2020-03-21 18:01 ` Jacek Anaszewski
2020-03-21 20:50 ` Marek Behun
2020-03-22 15:51 ` Jacek Anaszewski
2020-04-06 8:34 ` Pavel Machek
2020-04-06 13:53 ` Marek Behun
2020-03-21 18:55 ` Jacek Anaszewski
2020-03-21 20:44 ` Marek Behun
2020-03-22 15:28 ` Jacek Anaszewski
2020-03-21 21:53 ` Marek Behun [this message]
2020-03-21 22:16 ` Pavel Machek
2020-03-21 22:36 ` Marek Behun
2020-03-22 15:50 ` Dan Murphy
2020-04-06 8:40 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200321225342.7651547b@nic.cz \
--to=marek.behun@nic.cz \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox