Linux Media Controller development
 help / color / mirror / Atom feed
From: Daniel Oakley <daniel.oakley@ideasonboard.com>
To: linux-media@vger.kernel.org,
	Shuah Khan <skhan@linuxfoundation.org>,
	Kieran Bingham <kieran.bingham@ideasonboard.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Daniel Oakley <daniel.oakley@ideasonboard.com>
Subject: [PATCH 0/3] Vimc code readability improvements
Date: Thu, 16 Jun 2022 11:07:44 +0100	[thread overview]
Message-ID: <20220616100747.48124-1-daniel.oakley@ideasonboard.com> (raw)

These patches are supposed to be applied on top of the not yet merged
vimc ancillary patch (65b957cb0a926ee178100f4af8fea0e516fc7604).

While the vimc ancillary lens patch series was being reviewed, it was made
apparent that there were a few issues with the vimc code clarity:
 - The data link entity names were unclear, leading to a possible confusion
   with len and lens, e.g. vimc_len_type refers to the lens.
 - Raw index numbers in the VIMC_DATA_LINK declarations made understanding
   that code hard.

This patch series aims to solve these problems.


Link to lens patch review:
https://lore.kernel.org/r/165037056336.2548121.16870543641391713634@Monstersaurus

Daniel Oakley (3):
  media: vimc: expand the names of vimc entity types
  media: vimc: enumerate data link entities for clarity
  media: vimc: use data link entities enum to index the ent_config array

 .../media/test-drivers/vimc/vimc-capture.c    | 270 ++++++------
 drivers/media/test-drivers/vimc/vimc-common.h |  10 +-
 drivers/media/test-drivers/vimc/vimc-core.c   |  80 ++--
 .../media/test-drivers/vimc/vimc-debayer.c    | 393 +++++++++---------
 drivers/media/test-drivers/vimc/vimc-lens.c   |  82 ++--
 drivers/media/test-drivers/vimc/vimc-scaler.c | 216 +++++-----
 drivers/media/test-drivers/vimc/vimc-sensor.c | 307 +++++++-------
 7 files changed, 691 insertions(+), 667 deletions(-)


base-commit: 65b957cb0a926ee178100f4af8fea0e516fc7604
-- 
2.36.1


             reply	other threads:[~2022-06-16 10:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-16 10:07 Daniel Oakley [this message]
2022-06-16 10:07 ` [PATCH 1/3] media: vimc: expand the names of vimc entity types Daniel Oakley
2022-06-16 14:29   ` Shuah Khan
2022-06-16 14:41     ` Shuah Khan
2022-06-16 21:24       ` Kieran Bingham
2022-06-16 21:57         ` Shuah Khan
2022-06-17  7:05           ` Kieran Bingham
2022-06-16 10:07 ` [PATCH 2/3] media: vimc: enumerate data link entities for clarity Daniel Oakley
2022-06-16 14:30   ` Shuah Khan
2022-06-16 10:07 ` [PATCH 3/3] media: vimc: use data link entities enum to index the ent_config array Daniel Oakley
2022-06-16 14:31   ` Shuah Khan
2022-06-28 20:05     ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220616100747.48124-1-daniel.oakley@ideasonboard.com \
    --to=daniel.oakley@ideasonboard.com \
    --cc=kieran.bingham@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox