Linux Media Controller development
 help / color / mirror / Atom feed
From: Daniel Oakley <daniel.oakley@ideasonboard.com>
To: linux-media@vger.kernel.org,
	Shuah Khan <skhan@linuxfoundation.org>,
	Kieran Bingham <kieran.bingham@ideasonboard.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Daniel Oakley <daniel.oakley@ideasonboard.com>
Subject: [PATCH 3/3] media: vimc: use data link entities enum to index the ent_config array
Date: Thu, 16 Jun 2022 11:07:47 +0100	[thread overview]
Message-ID: <20220616100747.48124-4-daniel.oakley@ideasonboard.com> (raw)
In-Reply-To: <20220616100747.48124-1-daniel.oakley@ideasonboard.com>

Future additions to the ent_config[] could break the association between
the index of the struct vimc_ent_config entries in the ent_config[] array,
and the index defined by the enum proposed in the previous patch. Using
designated initializers solves this by linking the 2 together clearly in
code and prevents the array not reflecting the enum. There is no
functional change intended.

Suggested-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Signed-off-by: Daniel Oakley <daniel.oakley@ideasonboard.com>
---
 drivers/media/test-drivers/vimc/vimc-core.c | 22 ++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/drivers/media/test-drivers/vimc/vimc-core.c b/drivers/media/test-drivers/vimc/vimc-core.c
index f3437d4408ff..c73f91947f44 100644
--- a/drivers/media/test-drivers/vimc/vimc-core.c
+++ b/drivers/media/test-drivers/vimc/vimc-core.c
@@ -82,48 +82,48 @@ struct vimc_pipeline_config {
  */
 
 static struct vimc_ent_config ent_config[] = {
-	{
+	[SENSOR_A] = {
 		.name = "Sensor A",
 		.type = &vimc_sensor_type
 	},
-	{
+	[SENSOR_B] = {
 		.name = "Sensor B",
 		.type = &vimc_sensor_type
 	},
-	{
+	[DEBAYER_A] = {
 		.name = "Debayer A",
 		.type = &vimc_debayer_type
 	},
-	{
+	[DEBAYER_B] = {
 		.name = "Debayer B",
 		.type = &vimc_debayer_type
 	},
-	{
+	[RAW_CAPTURE_0] = {
 		.name = "Raw Capture 0",
 		.type = &vimc_capture_type
 	},
-	{
+	[RAW_CAPTURE_1] = {
 		.name = "Raw Capture 1",
 		.type = &vimc_capture_type
 	},
-	{
+	[RGB_YUV_INPUT] = {
 		/* TODO: change this to vimc-input when it is implemented */
 		.name = "RGB/YUV Input",
 		.type = &vimc_sensor_type
 	},
-	{
+	[SCALER] = {
 		.name = "Scaler",
 		.type = &vimc_scaler_type
 	},
-	{
+	[RGB_YUV_CAPTURE] = {
 		.name = "RGB/YUV Capture",
 		.type = &vimc_capture_type
 	},
-	{
+	[LENS_A] = {
 		.name = "Lens A",
 		.type = &vimc_lens_type
 	},
-	{
+	[LENS_B] = {
 		.name = "Lens B",
 		.type = &vimc_lens_type
 	},
-- 
2.36.1


  parent reply	other threads:[~2022-06-16 10:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-16 10:07 [PATCH 0/3] Vimc code readability improvements Daniel Oakley
2022-06-16 10:07 ` [PATCH 1/3] media: vimc: expand the names of vimc entity types Daniel Oakley
2022-06-16 14:29   ` Shuah Khan
2022-06-16 14:41     ` Shuah Khan
2022-06-16 21:24       ` Kieran Bingham
2022-06-16 21:57         ` Shuah Khan
2022-06-17  7:05           ` Kieran Bingham
2022-06-16 10:07 ` [PATCH 2/3] media: vimc: enumerate data link entities for clarity Daniel Oakley
2022-06-16 14:30   ` Shuah Khan
2022-06-16 10:07 ` Daniel Oakley [this message]
2022-06-16 14:31   ` [PATCH 3/3] media: vimc: use data link entities enum to index the ent_config array Shuah Khan
2022-06-28 20:05     ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220616100747.48124-4-daniel.oakley@ideasonboard.com \
    --to=daniel.oakley@ideasonboard.com \
    --cc=kieran.bingham@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox