Re: [PATCH 3/3] media: vimc: use data link entities enum to index the ent_config array

[Shuah Khan <skhan@linuxfoundation.org>]

On 6/16/22 8:31 AM, Shuah Khan wrote:
> On 6/16/22 4:07 AM, Daniel Oakley wrote:
>> Future additions to the ent_config[] could break the association between
>> the index of the struct vimc_ent_config entries in the ent_config[] array,
>> and the index defined by the enum proposed in the previous patch. Using
>> designated initializers solves this by linking the 2 together clearly in
>> code and prevents the array not reflecting the enum. There is no
>> functional change intended.
>>
>> Suggested-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
>> Signed-off-by: Daniel Oakley <daniel.oakley@ideasonboard.com>
>> ---
>>   drivers/media/test-drivers/vimc/vimc-core.c | 22 ++++++++++-----------
>>   1 file changed, 11 insertions(+), 11 deletions(-)
>>
> 
> Thank you for the patch to improve code readability. Looks good to me.
> 
> Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
> 
> thanks,
> -- Shuah

These 3 patches are now queued for vimc pull request for Linux 5.20-rc1
to be send to Mauro Chehab.

https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux.git/log/?h=vimc

thanks,
-- Shuah