Re: [PATCH 1/3] media: vimc: expand the names of vimc entity types

[Kieran Bingham <kieran.bingham@ideasonboard.com>]

Quoting Shuah Khan (2022-06-16 22:57:36)
> On 6/16/22 3:24 PM, Kieran Bingham wrote:
> > Quoting Shuah Khan (2022-06-16 15:41:45)
> >> On 6/16/22 8:29 AM, Shuah Khan wrote:
> >>> On 6/16/22 4:07 AM, Daniel Oakley wrote:
> >>>> When introducing the lens controller, it became apparent that the vimc
> >>>> entity type names were hard to understand, e.g. vimc_len_type refers to the
> >>>> lens. The names of the vimc entity types have been expanded to make the
> >>>> code easier to understand. There is no functional change intended.
> >>>>
> >>>> Suggested-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> >>>> Signed-off-by: Daniel Oakley <daniel.oakley@ideasonboard.com>
> >>>> ---
> >>>>    .../media/test-drivers/vimc/vimc-capture.c    | 270 ++++++------
> >>>>    drivers/media/test-drivers/vimc/vimc-common.h |  10 +-
> >>>>    drivers/media/test-drivers/vimc/vimc-core.c   |  22 +-
> >>>>    .../media/test-drivers/vimc/vimc-debayer.c    | 393 +++++++++---------
> >>>>    drivers/media/test-drivers/vimc/vimc-lens.c   |  82 ++--
> >>>>    drivers/media/test-drivers/vimc/vimc-scaler.c | 216 +++++-----
> >>>>    drivers/media/test-drivers/vimc/vimc-sensor.c | 307 +++++++-------
> >>>>    7 files changed, 652 insertions(+), 648 deletions(-)
> >>>>
> >>>
> >>> Thank you for the patch to improve code readability. Looks good to me.
> >>>
> >>> Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
> >>>
> >>
> >>
> >> Reviewed all three patches
> >>
> >> Mauro,
> >>
> >> Would you like me to send a pull request for these patches?
> > 
> > Hi Shuah,
> > 
> > Please note that I believe these patches are based on top of Yunke's not
> > yet accepted patches for the vimc-lens.
> > 
> 
> Yes. I am aware of that. I will make sure they are applied in the right
> order.
> 
Aha, perfect, thanks - I had missed that you had already reviewed
Yunke's patches before this.

--
Kieran


> thanks,
> -- Shuah
>