From: Shuah Khan <skhan@linuxfoundation.org>
To: Daniel Oakley <daniel.oakley@ideasonboard.com>,
linux-media@vger.kernel.org,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH 2/3] media: vimc: enumerate data link entities for clarity
Date: Thu, 16 Jun 2022 08:30:46 -0600 [thread overview]
Message-ID: <8a72c313-4624-022c-2845-fb902890d81d@linuxfoundation.org> (raw)
In-Reply-To: <20220616100747.48124-3-daniel.oakley@ideasonboard.com>
On 6/16/22 4:07 AM, Daniel Oakley wrote:
> The data_links array was hard to read and understand. By implementing
> enumerated vimc data link entities, clarity has been improved when
> defining data_links. This therefore should help new programmers to
> understand the codebase better. There is no functional change intended.
>
> Suggested-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> Signed-off-by: Daniel Oakley <daniel.oakley@ideasonboard.com>
> ---
> drivers/media/test-drivers/vimc/vimc-core.c | 36 ++++++++++++++++-----
> 1 file changed, 28 insertions(+), 8 deletions(-)
>
Thank you for the patch to improve code readability. Looks good to me.
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
next prev parent reply other threads:[~2022-06-16 14:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 10:07 [PATCH 0/3] Vimc code readability improvements Daniel Oakley
2022-06-16 10:07 ` [PATCH 1/3] media: vimc: expand the names of vimc entity types Daniel Oakley
2022-06-16 14:29 ` Shuah Khan
2022-06-16 14:41 ` Shuah Khan
2022-06-16 21:24 ` Kieran Bingham
2022-06-16 21:57 ` Shuah Khan
2022-06-17 7:05 ` Kieran Bingham
2022-06-16 10:07 ` [PATCH 2/3] media: vimc: enumerate data link entities for clarity Daniel Oakley
2022-06-16 14:30 ` Shuah Khan [this message]
2022-06-16 10:07 ` [PATCH 3/3] media: vimc: use data link entities enum to index the ent_config array Daniel Oakley
2022-06-16 14:31 ` Shuah Khan
2022-06-28 20:05 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a72c313-4624-022c-2845-fb902890d81d@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=daniel.oakley@ideasonboard.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox