From: Dave Stevenson <dave.stevenson@raspberrypi.com>
To: Tianshu Qiu <tian.shu.qiu@intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
David Heidelberg <david@ixit.cz>,
20260414-imx355-24mhz-v1-1-9ae77bc6e7ec@ixit.cz,
Dave Stevenson <dave.stevenson@raspberrypi.com>
Subject: [PATCH 04/13] media: imx355: Remove the duplication between width/height and x/y_out_size
Date: Wed, 06 May 2026 19:23:42 +0100 [thread overview]
Message-ID: <20260506-media-imx355-v1-4-660685030455@raspberrypi.com> (raw)
In-Reply-To: <20260506-media-imx355-v1-0-660685030455@raspberrypi.com>
The register settings x_out_size and y_out_size are just width and
height, so drop the values.
Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
---
drivers/media/i2c/imx355.c | 34 ++--------------------------------
1 file changed, 2 insertions(+), 32 deletions(-)
diff --git a/drivers/media/i2c/imx355.c b/drivers/media/i2c/imx355.c
index 6179fe74c897..589bad6c58e4 100644
--- a/drivers/media/i2c/imx355.c
+++ b/drivers/media/i2c/imx355.c
@@ -114,8 +114,6 @@ struct imx355_mode {
u16 y_add_start;
u16 x_add_end;
u16 y_add_end;
- u16 x_out_size;
- u16 y_out_size;
};
struct imx355_clk_params {
@@ -440,8 +438,6 @@ static const struct imx355_mode supported_modes[] = {
.y_add_start = 0x0000,
.x_add_end = 0x0ccf,
.y_add_end = 0x099f,
- .x_out_size = 0x0cd0,
- .y_out_size = 0x09a0,
},
{
.width = 3268,
@@ -458,8 +454,6 @@ static const struct imx355_mode supported_modes[] = {
.y_add_start = 0x0008,
.x_add_end = 0x0ccb,
.y_add_end = 0x997,
- .x_out_size = 0x0cc4,
- .y_out_size = 0x0990,
},
{
.width = 3264,
@@ -476,8 +470,6 @@ static const struct imx355_mode supported_modes[] = {
.y_add_start = 0x0008,
.x_add_end = 0x0cc7,
.y_add_end = 0x0997,
- .x_out_size = 0x0cc0,
- .y_out_size = 0x0990,
},
{
.width = 1940,
@@ -494,8 +486,6 @@ static const struct imx355_mode supported_modes[] = {
.y_add_start = 0x02ac,
.x_add_end = 0x0a33,
.y_add_end = 0x06f3,
- .x_out_size = 0x0794,
- .y_out_size = 0x0448,
},
{
.width = 1936,
@@ -512,8 +502,6 @@ static const struct imx355_mode supported_modes[] = {
.y_add_start = 0x02ac,
.x_add_end = 0x0a2f,
.y_add_end = 0x06f3,
- .x_out_size = 0x0790,
- .y_out_size = 0x0448,
},
{
.width = 1924,
@@ -530,8 +518,6 @@ static const struct imx355_mode supported_modes[] = {
.y_add_start = 0x02b4,
.x_add_end = 0x0a2b,
.y_add_end = 0x06eb,
- .x_out_size = 0x0784,
- .y_out_size = 0x0438,
},
{
.width = 1920,
@@ -548,8 +534,6 @@ static const struct imx355_mode supported_modes[] = {
.y_add_start = 0x02b4,
.x_add_end = 0x0a27,
.y_add_end = 0x06eb,
- .x_out_size = 0x0780,
- .y_out_size = 0x0438,
},
{
.width = 1640,
@@ -566,8 +550,6 @@ static const struct imx355_mode supported_modes[] = {
.y_add_start = 0x0000,
.x_add_end = 0x0ccf,
.y_add_end = 0x099f,
- .x_out_size = 0x0668,
- .y_out_size = 0x04d0,
},
{
.width = 1640,
@@ -584,8 +566,6 @@ static const struct imx355_mode supported_modes[] = {
.y_add_start = 0x0130,
.x_add_end = 0x0ccf,
.y_add_end = 0x0863,
- .x_out_size = 0x0668,
- .y_out_size = 0x039a,
},
{
.width = 1300,
@@ -602,8 +582,6 @@ static const struct imx355_mode supported_modes[] = {
.y_add_start = 0x01f0,
.x_add_end = 0x0b7f,
.y_add_end = 0x07af,
- .x_out_size = 0x0514,
- .y_out_size = 0x02e0,
},
{
.width = 1296,
@@ -620,8 +598,6 @@ static const struct imx355_mode supported_modes[] = {
.y_add_start = 0x01f0,
.x_add_end = 0x0b77,
.y_add_end = 0x07af,
- .x_out_size = 0x0510,
- .y_out_size = 0x02e0,
},
{
.width = 1284,
@@ -638,8 +614,6 @@ static const struct imx355_mode supported_modes[] = {
.y_add_start = 0x0200,
.x_add_end = 0x0b6f,
.y_add_end = 0x079f,
- .x_out_size = 0x0504,
- .y_out_size = 0x02d0,
},
{
.width = 1280,
@@ -656,8 +630,6 @@ static const struct imx355_mode supported_modes[] = {
.y_add_start = 0x0200,
.x_add_end = 0x0b67,
.y_add_end = 0x079f,
- .x_out_size = 0x0500,
- .y_out_size = 0x02d0,
},
{
.width = 820,
@@ -674,8 +646,6 @@ static const struct imx355_mode supported_modes[] = {
.y_add_start = 0x0000,
.x_add_end = 0x0ccf,
.y_add_end = 0x099f,
- .x_out_size = 0x0334,
- .y_out_size = 0x0268,
},
};
@@ -1044,11 +1014,11 @@ static int imx355_start_streaming(struct imx355 *imx355)
if (ret)
return ret;
ret = imx355_write_reg(imx355, IMX355_REG_X_OUT_SIZE, 2,
- mode->x_out_size);
+ mode->width);
if (ret)
return ret;
ret = imx355_write_reg(imx355, IMX355_REG_Y_OUT_SIZE, 2,
- mode->y_out_size);
+ mode->height);
if (ret)
return ret;
--
2.34.1
next prev parent reply other threads:[~2026-05-06 18:24 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 18:23 [PATCH 00/13] media/imx355: General code cleanups, and adding support for 2 lane operation Dave Stevenson
2026-05-06 18:23 ` [PATCH 01/13] media: imx355: Remove duplicated registers from the mode tables Dave Stevenson
2026-05-07 13:41 ` Jacopo Mondi
2026-05-06 18:23 ` [PATCH 02/13] media: imx355: Remove setting FRM_LENGTH_LINES in the mode regs Dave Stevenson
2026-05-07 13:50 ` Jacopo Mondi
2026-05-06 18:23 ` [PATCH 03/13] media: imx355: Programmatically set the crop parameters for each mode Dave Stevenson
2026-05-07 14:00 ` Jacopo Mondi
2026-05-07 16:01 ` Dave Stevenson
2026-05-06 18:23 ` Dave Stevenson [this message]
2026-05-06 18:23 ` [PATCH 05/13] media: imx355: Set register LINE_LENGTH_PCK programmatically Dave Stevenson
2026-05-07 14:09 ` Jacopo Mondi
2026-05-07 15:18 ` Dave Stevenson
2026-05-06 18:23 ` [PATCH 06/13] media: imx355: Set binning mode registers programmatically Dave Stevenson
2026-05-07 14:12 ` Jacopo Mondi
2026-05-06 18:23 ` [PATCH 07/13] media: imx355: Remove link_freq_index from each mode as ununsed Dave Stevenson
2026-05-07 14:12 ` Jacopo Mondi
2026-05-06 18:23 ` [PATCH 08/13] media: imx355: pixel_rate never changes, so don't recompute Dave Stevenson
2026-05-07 14:13 ` Jacopo Mondi
2026-05-06 18:23 ` [PATCH 09/13] media: imx355: Remove redundant fll_min, and implement fixed offset Dave Stevenson
2026-05-07 14:29 ` Jacopo Mondi
2026-05-07 15:21 ` Dave Stevenson
2026-05-06 18:23 ` [PATCH 10/13] media: imx355: Add support for get_selection Dave Stevenson
2026-05-07 14:42 ` Jacopo Mondi
2026-05-07 15:02 ` Dave Stevenson
2026-05-06 18:23 ` [PATCH 11/13] media: imx355: Use pm_runtime autosuspend_delay Dave Stevenson
2026-05-07 14:43 ` Jacopo Mondi
2026-05-06 18:23 ` [PATCH 12/13] media: imx355: Convert to new CCI register access helpers Dave Stevenson
2026-05-07 14:49 ` Jacopo Mondi
2026-05-06 18:23 ` [PATCH 13/13] media: imx355: Support 2 lane readout Dave Stevenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260506-media-imx355-v1-4-660685030455@raspberrypi.com \
--to=dave.stevenson@raspberrypi.com \
--cc=20260414-imx355-24mhz-v1-1-9ae77bc6e7ec@ixit.cz \
--cc=david@ixit.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tian.shu.qiu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox