From: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
To: Dave Stevenson <dave.stevenson@raspberrypi.com>
Cc: Tianshu Qiu <tian.shu.qiu@intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
David Heidelberg <david@ixit.cz>,
20260414-imx355-24mhz-v1-1-9ae77bc6e7ec@ixit.cz
Subject: Re: [PATCH 02/13] media: imx355: Remove setting FRM_LENGTH_LINES in the mode regs
Date: Thu, 7 May 2026 15:50:08 +0200 [thread overview]
Message-ID: <afyYhtS5iKYi97Re@zed> (raw)
In-Reply-To: <20260506-media-imx355-v1-2-660685030455@raspberrypi.com>
Hi Dave
On Wed, May 06, 2026 at 07:23:40PM +0100, Dave Stevenson wrote:
> Registers 0x0340 and 0x0341 (FRM_LENGTH_LINES) are already written
> from the set_ctrl(V4L2_CID_VBLANK) handler, so don't write them
> from the mode register list.
>
> Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
> ---
> drivers/media/i2c/imx355.c | 28 ----------------------------
> 1 file changed, 28 deletions(-)
>
> diff --git a/drivers/media/i2c/imx355.c b/drivers/media/i2c/imx355.c
> index a694d4d742ae..8ea510218c7c 100644
> --- a/drivers/media/i2c/imx355.c
> +++ b/drivers/media/i2c/imx355.c
> @@ -256,8 +256,6 @@ static const struct imx355_reg_list imx355_global_setting = {
> static const struct imx355_reg mode_3268x2448_regs[] = {
> { 0x0342, 0x0e },
> { 0x0343, 0x58 },
> - { 0x0340, 0x0a },
> - { 0x0341, 0x37 },
> { 0x0344, 0x00 },
> { 0x0345, 0x08 },
> { 0x0346, 0x00 },
> @@ -280,8 +278,6 @@ static const struct imx355_reg mode_3268x2448_regs[] = {
> static const struct imx355_reg mode_3264x2448_regs[] = {
> { 0x0342, 0x0e },
> { 0x0343, 0x58 },
> - { 0x0340, 0x0a },
> - { 0x0341, 0x37 },
> { 0x0344, 0x00 },
> { 0x0345, 0x08 },
> { 0x0346, 0x00 },
> @@ -304,8 +300,6 @@ static const struct imx355_reg mode_3264x2448_regs[] = {
> static const struct imx355_reg mode_3280x2464_regs[] = {
> { 0x0342, 0x0e },
> { 0x0343, 0x58 },
> - { 0x0340, 0x0a },
> - { 0x0341, 0x37 },
> { 0x0344, 0x00 },
> { 0x0345, 0x00 },
> { 0x0346, 0x00 },
> @@ -328,8 +322,6 @@ static const struct imx355_reg mode_3280x2464_regs[] = {
> static const struct imx355_reg mode_1940x1096_regs[] = {
> { 0x0342, 0x0e },
> { 0x0343, 0x58 },
> - { 0x0340, 0x05 },
> - { 0x0341, 0x1a },
> { 0x0344, 0x02 },
> { 0x0345, 0xa0 },
> { 0x0346, 0x02 },
> @@ -352,8 +344,6 @@ static const struct imx355_reg mode_1940x1096_regs[] = {
> static const struct imx355_reg mode_1936x1096_regs[] = {
> { 0x0342, 0x0e },
> { 0x0343, 0x58 },
> - { 0x0340, 0x05 },
> - { 0x0341, 0x1a },
> { 0x0344, 0x02 },
> { 0x0345, 0xa0 },
> { 0x0346, 0x02 },
> @@ -376,8 +366,6 @@ static const struct imx355_reg mode_1936x1096_regs[] = {
> static const struct imx355_reg mode_1924x1080_regs[] = {
> { 0x0342, 0x0e },
> { 0x0343, 0x58 },
> - { 0x0340, 0x05 },
> - { 0x0341, 0x1a },
> { 0x0344, 0x02 },
> { 0x0345, 0xa8 },
> { 0x0346, 0x02 },
> @@ -400,8 +388,6 @@ static const struct imx355_reg mode_1924x1080_regs[] = {
> static const struct imx355_reg mode_1920x1080_regs[] = {
> { 0x0342, 0x0e },
> { 0x0343, 0x58 },
> - { 0x0340, 0x05 },
> - { 0x0341, 0x1a },
> { 0x0344, 0x02 },
> { 0x0345, 0xa8 },
> { 0x0346, 0x02 },
> @@ -424,8 +410,6 @@ static const struct imx355_reg mode_1920x1080_regs[] = {
> static const struct imx355_reg mode_1640x1232_regs[] = {
> { 0x0342, 0x07 },
> { 0x0343, 0x2c },
> - { 0x0340, 0x05 },
> - { 0x0341, 0x1a },
> { 0x0344, 0x00 },
> { 0x0345, 0x00 },
> { 0x0346, 0x00 },
> @@ -448,8 +432,6 @@ static const struct imx355_reg mode_1640x1232_regs[] = {
> static const struct imx355_reg mode_1640x922_regs[] = {
> { 0x0342, 0x07 },
> { 0x0343, 0x2c },
> - { 0x0340, 0x05 },
> - { 0x0341, 0x1a },
> { 0x0344, 0x00 },
> { 0x0345, 0x00 },
> { 0x0346, 0x01 },
> @@ -472,8 +454,6 @@ static const struct imx355_reg mode_1640x922_regs[] = {
> static const struct imx355_reg mode_1300x736_regs[] = {
> { 0x0342, 0x07 },
> { 0x0343, 0x2c },
> - { 0x0340, 0x05 },
> - { 0x0341, 0x1a },
> { 0x0344, 0x01 },
> { 0x0345, 0x58 },
> { 0x0346, 0x01 },
> @@ -496,8 +476,6 @@ static const struct imx355_reg mode_1300x736_regs[] = {
> static const struct imx355_reg mode_1296x736_regs[] = {
> { 0x0342, 0x07 },
> { 0x0343, 0x2c },
> - { 0x0340, 0x05 },
> - { 0x0341, 0x1a },
> { 0x0344, 0x01 },
> { 0x0345, 0x58 },
> { 0x0346, 0x01 },
> @@ -520,8 +498,6 @@ static const struct imx355_reg mode_1296x736_regs[] = {
> static const struct imx355_reg mode_1284x720_regs[] = {
> { 0x0342, 0x07 },
> { 0x0343, 0x2c },
> - { 0x0340, 0x05 },
> - { 0x0341, 0x1a },
> { 0x0344, 0x01 },
> { 0x0345, 0x68 },
> { 0x0346, 0x02 },
> @@ -544,8 +520,6 @@ static const struct imx355_reg mode_1284x720_regs[] = {
> static const struct imx355_reg mode_1280x720_regs[] = {
> { 0x0342, 0x07 },
> { 0x0343, 0x2c },
> - { 0x0340, 0x05 },
> - { 0x0341, 0x1a },
> { 0x0344, 0x01 },
> { 0x0345, 0x68 },
> { 0x0346, 0x02 },
> @@ -568,8 +542,6 @@ static const struct imx355_reg mode_1280x720_regs[] = {
> static const struct imx355_reg mode_820x616_regs[] = {
> { 0x0342, 0x0e },
> { 0x0343, 0x58 },
> - { 0x0340, 0x02 },
> - { 0x0341, 0x8c },
> { 0x0344, 0x00 },
> { 0x0345, 0x00 },
> { 0x0346, 0x00 },
>
> --
> 2.34.1
>
>
next prev parent reply other threads:[~2026-05-07 13:50 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 18:23 [PATCH 00/13] media/imx355: General code cleanups, and adding support for 2 lane operation Dave Stevenson
2026-05-06 18:23 ` [PATCH 01/13] media: imx355: Remove duplicated registers from the mode tables Dave Stevenson
2026-05-07 13:41 ` Jacopo Mondi
2026-05-06 18:23 ` [PATCH 02/13] media: imx355: Remove setting FRM_LENGTH_LINES in the mode regs Dave Stevenson
2026-05-07 13:50 ` Jacopo Mondi [this message]
2026-05-06 18:23 ` [PATCH 03/13] media: imx355: Programmatically set the crop parameters for each mode Dave Stevenson
2026-05-07 14:00 ` Jacopo Mondi
2026-05-07 16:01 ` Dave Stevenson
2026-05-06 18:23 ` [PATCH 04/13] media: imx355: Remove the duplication between width/height and x/y_out_size Dave Stevenson
2026-05-06 18:23 ` [PATCH 05/13] media: imx355: Set register LINE_LENGTH_PCK programmatically Dave Stevenson
2026-05-07 14:09 ` Jacopo Mondi
2026-05-07 15:18 ` Dave Stevenson
2026-05-06 18:23 ` [PATCH 06/13] media: imx355: Set binning mode registers programmatically Dave Stevenson
2026-05-07 14:12 ` Jacopo Mondi
2026-05-06 18:23 ` [PATCH 07/13] media: imx355: Remove link_freq_index from each mode as ununsed Dave Stevenson
2026-05-07 14:12 ` Jacopo Mondi
2026-05-06 18:23 ` [PATCH 08/13] media: imx355: pixel_rate never changes, so don't recompute Dave Stevenson
2026-05-07 14:13 ` Jacopo Mondi
2026-05-06 18:23 ` [PATCH 09/13] media: imx355: Remove redundant fll_min, and implement fixed offset Dave Stevenson
2026-05-07 14:29 ` Jacopo Mondi
2026-05-07 15:21 ` Dave Stevenson
2026-05-06 18:23 ` [PATCH 10/13] media: imx355: Add support for get_selection Dave Stevenson
2026-05-07 14:42 ` Jacopo Mondi
2026-05-07 15:02 ` Dave Stevenson
2026-05-06 18:23 ` [PATCH 11/13] media: imx355: Use pm_runtime autosuspend_delay Dave Stevenson
2026-05-07 14:43 ` Jacopo Mondi
2026-05-06 18:23 ` [PATCH 12/13] media: imx355: Convert to new CCI register access helpers Dave Stevenson
2026-05-07 14:49 ` Jacopo Mondi
2026-05-06 18:23 ` [PATCH 13/13] media: imx355: Support 2 lane readout Dave Stevenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afyYhtS5iKYi97Re@zed \
--to=jacopo.mondi@ideasonboard.com \
--cc=20260414-imx355-24mhz-v1-1-9ae77bc6e7ec@ixit.cz \
--cc=dave.stevenson@raspberrypi.com \
--cc=david@ixit.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tian.shu.qiu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox