From: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
To: Dave Stevenson <dave.stevenson@raspberrypi.com>
Cc: Tianshu Qiu <tian.shu.qiu@intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
David Heidelberg <david@ixit.cz>,
20260414-imx355-24mhz-v1-1-9ae77bc6e7ec@ixit.cz
Subject: Re: [PATCH 01/13] media: imx355: Remove duplicated registers from the mode tables
Date: Thu, 7 May 2026 15:41:20 +0200 [thread overview]
Message-ID: <afyWYG_idVPEF7RD@zed> (raw)
In-Reply-To: <20260506-media-imx355-v1-1-660685030455@raspberrypi.com>
Hi Dave,
On Wed, May 06, 2026 at 07:23:39PM +0100, Dave Stevenson wrote:
> A large number of registers are identical within all the modes.
> Move those to imx355_global_regs.
>
> Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Indeed all the factored-out registers have the same value in all modes
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Thanks
j
> ---
> drivers/media/i2c/imx355.c | 314 +++------------------------------------------
> 1 file changed, 20 insertions(+), 294 deletions(-)
>
> diff --git a/drivers/media/i2c/imx355.c b/drivers/media/i2c/imx355.c
> index f9ec13bb27d1..a694d4d742ae 100644
> --- a/drivers/media/i2c/imx355.c
> +++ b/drivers/media/i2c/imx355.c
> @@ -226,6 +226,26 @@ static const struct imx355_reg imx355_global_regs[] = {
> { 0x68b0, 0x00 },
> { 0x3058, 0x00 },
> { 0x305a, 0x00 },
> + { 0x0112, 0x0a },
> + { 0x0113, 0x0a },
> + { 0x0114, 0x03 },
> + { 0x0301, 0x05 },
> + { 0x0303, 0x01 },
> + { 0x0305, 0x02 },
> + { 0x030d, 0x02 },
> + { 0x0310, 0x00 },
> + { 0x0220, 0x00 },
> + { 0x0222, 0x01 },
> + { 0x0820, 0x0b },
> + { 0x0821, 0x40 },
> + { 0x3088, 0x04 },
> + { 0x6813, 0x02 },
> + { 0x6835, 0x07 },
> + { 0x6836, 0x01 },
> + { 0x6837, 0x04 },
> + { 0x684d, 0x07 },
> + { 0x684e, 0x01 },
> + { 0x684f, 0x04 },
> };
>
> static const struct imx355_reg_list imx355_global_setting = {
> @@ -234,9 +254,6 @@ static const struct imx355_reg_list imx355_global_setting = {
> };
>
> static const struct imx355_reg mode_3268x2448_regs[] = {
> - { 0x0112, 0x0a },
> - { 0x0113, 0x0a },
> - { 0x0114, 0x03 },
> { 0x0342, 0x0e },
> { 0x0343, 0x58 },
> { 0x0340, 0x0a },
> @@ -249,8 +266,6 @@ static const struct imx355_reg mode_3268x2448_regs[] = {
> { 0x0349, 0xcb },
> { 0x034a, 0x09 },
> { 0x034b, 0x97 },
> - { 0x0220, 0x00 },
> - { 0x0222, 0x01 },
> { 0x0900, 0x00 },
> { 0x0901, 0x11 },
> { 0x0902, 0x00 },
> @@ -258,30 +273,11 @@ static const struct imx355_reg mode_3268x2448_regs[] = {
> { 0x034d, 0xc4 },
> { 0x034e, 0x09 },
> { 0x034f, 0x90 },
> - { 0x0301, 0x05 },
> - { 0x0303, 0x01 },
> - { 0x0305, 0x02 },
> - { 0x030b, 0x01 },
> - { 0x030d, 0x02 },
> - { 0x0310, 0x00 },
> { 0x0700, 0x00 },
> { 0x0701, 0x10 },
> - { 0x0820, 0x0b },
> - { 0x0821, 0x40 },
> - { 0x3088, 0x04 },
> - { 0x6813, 0x02 },
> - { 0x6835, 0x07 },
> - { 0x6836, 0x01 },
> - { 0x6837, 0x04 },
> - { 0x684d, 0x07 },
> - { 0x684e, 0x01 },
> - { 0x684f, 0x04 },
> };
>
> static const struct imx355_reg mode_3264x2448_regs[] = {
> - { 0x0112, 0x0a },
> - { 0x0113, 0x0a },
> - { 0x0114, 0x03 },
> { 0x0342, 0x0e },
> { 0x0343, 0x58 },
> { 0x0340, 0x0a },
> @@ -294,8 +290,6 @@ static const struct imx355_reg mode_3264x2448_regs[] = {
> { 0x0349, 0xc7 },
> { 0x034a, 0x09 },
> { 0x034b, 0x97 },
> - { 0x0220, 0x00 },
> - { 0x0222, 0x01 },
> { 0x0900, 0x00 },
> { 0x0901, 0x11 },
> { 0x0902, 0x00 },
> @@ -303,30 +297,11 @@ static const struct imx355_reg mode_3264x2448_regs[] = {
> { 0x034d, 0xc0 },
> { 0x034e, 0x09 },
> { 0x034f, 0x90 },
> - { 0x0301, 0x05 },
> - { 0x0303, 0x01 },
> - { 0x0305, 0x02 },
> - { 0x030b, 0x01 },
> - { 0x030d, 0x02 },
> - { 0x0310, 0x00 },
> { 0x0700, 0x00 },
> { 0x0701, 0x10 },
> - { 0x0820, 0x0b },
> - { 0x0821, 0x40 },
> - { 0x3088, 0x04 },
> - { 0x6813, 0x02 },
> - { 0x6835, 0x07 },
> - { 0x6836, 0x01 },
> - { 0x6837, 0x04 },
> - { 0x684d, 0x07 },
> - { 0x684e, 0x01 },
> - { 0x684f, 0x04 },
> };
>
> static const struct imx355_reg mode_3280x2464_regs[] = {
> - { 0x0112, 0x0a },
> - { 0x0113, 0x0a },
> - { 0x0114, 0x03 },
> { 0x0342, 0x0e },
> { 0x0343, 0x58 },
> { 0x0340, 0x0a },
> @@ -339,8 +314,6 @@ static const struct imx355_reg mode_3280x2464_regs[] = {
> { 0x0349, 0xcf },
> { 0x034a, 0x09 },
> { 0x034b, 0x9f },
> - { 0x0220, 0x00 },
> - { 0x0222, 0x01 },
> { 0x0900, 0x00 },
> { 0x0901, 0x11 },
> { 0x0902, 0x00 },
> @@ -348,30 +321,11 @@ static const struct imx355_reg mode_3280x2464_regs[] = {
> { 0x034d, 0xd0 },
> { 0x034e, 0x09 },
> { 0x034f, 0xa0 },
> - { 0x0301, 0x05 },
> - { 0x0303, 0x01 },
> - { 0x0305, 0x02 },
> - { 0x030b, 0x01 },
> - { 0x030d, 0x02 },
> - { 0x0310, 0x00 },
> { 0x0700, 0x00 },
> { 0x0701, 0x10 },
> - { 0x0820, 0x0b },
> - { 0x0821, 0x40 },
> - { 0x3088, 0x04 },
> - { 0x6813, 0x02 },
> - { 0x6835, 0x07 },
> - { 0x6836, 0x01 },
> - { 0x6837, 0x04 },
> - { 0x684d, 0x07 },
> - { 0x684e, 0x01 },
> - { 0x684f, 0x04 },
> };
>
> static const struct imx355_reg mode_1940x1096_regs[] = {
> - { 0x0112, 0x0a },
> - { 0x0113, 0x0a },
> - { 0x0114, 0x03 },
> { 0x0342, 0x0e },
> { 0x0343, 0x58 },
> { 0x0340, 0x05 },
> @@ -384,8 +338,6 @@ static const struct imx355_reg mode_1940x1096_regs[] = {
> { 0x0349, 0x33 },
> { 0x034a, 0x06 },
> { 0x034b, 0xf3 },
> - { 0x0220, 0x00 },
> - { 0x0222, 0x01 },
> { 0x0900, 0x00 },
> { 0x0901, 0x11 },
> { 0x0902, 0x00 },
> @@ -393,30 +345,11 @@ static const struct imx355_reg mode_1940x1096_regs[] = {
> { 0x034d, 0x94 },
> { 0x034e, 0x04 },
> { 0x034f, 0x48 },
> - { 0x0301, 0x05 },
> - { 0x0303, 0x01 },
> - { 0x0305, 0x02 },
> - { 0x030b, 0x01 },
> - { 0x030d, 0x02 },
> - { 0x0310, 0x00 },
> { 0x0700, 0x00 },
> { 0x0701, 0x10 },
> - { 0x0820, 0x0b },
> - { 0x0821, 0x40 },
> - { 0x3088, 0x04 },
> - { 0x6813, 0x02 },
> - { 0x6835, 0x07 },
> - { 0x6836, 0x01 },
> - { 0x6837, 0x04 },
> - { 0x684d, 0x07 },
> - { 0x684e, 0x01 },
> - { 0x684f, 0x04 },
> };
>
> static const struct imx355_reg mode_1936x1096_regs[] = {
> - { 0x0112, 0x0a },
> - { 0x0113, 0x0a },
> - { 0x0114, 0x03 },
> { 0x0342, 0x0e },
> { 0x0343, 0x58 },
> { 0x0340, 0x05 },
> @@ -429,8 +362,6 @@ static const struct imx355_reg mode_1936x1096_regs[] = {
> { 0x0349, 0x2f },
> { 0x034a, 0x06 },
> { 0x034b, 0xf3 },
> - { 0x0220, 0x00 },
> - { 0x0222, 0x01 },
> { 0x0900, 0x00 },
> { 0x0901, 0x11 },
> { 0x0902, 0x00 },
> @@ -438,30 +369,11 @@ static const struct imx355_reg mode_1936x1096_regs[] = {
> { 0x034d, 0x90 },
> { 0x034e, 0x04 },
> { 0x034f, 0x48 },
> - { 0x0301, 0x05 },
> - { 0x0303, 0x01 },
> - { 0x0305, 0x02 },
> - { 0x030b, 0x01 },
> - { 0x030d, 0x02 },
> - { 0x0310, 0x00 },
> { 0x0700, 0x00 },
> { 0x0701, 0x10 },
> - { 0x0820, 0x0b },
> - { 0x0821, 0x40 },
> - { 0x3088, 0x04 },
> - { 0x6813, 0x02 },
> - { 0x6835, 0x07 },
> - { 0x6836, 0x01 },
> - { 0x6837, 0x04 },
> - { 0x684d, 0x07 },
> - { 0x684e, 0x01 },
> - { 0x684f, 0x04 },
> };
>
> static const struct imx355_reg mode_1924x1080_regs[] = {
> - { 0x0112, 0x0a },
> - { 0x0113, 0x0a },
> - { 0x0114, 0x03 },
> { 0x0342, 0x0e },
> { 0x0343, 0x58 },
> { 0x0340, 0x05 },
> @@ -474,8 +386,6 @@ static const struct imx355_reg mode_1924x1080_regs[] = {
> { 0x0349, 0x2b },
> { 0x034a, 0x06 },
> { 0x034b, 0xeb },
> - { 0x0220, 0x00 },
> - { 0x0222, 0x01 },
> { 0x0900, 0x00 },
> { 0x0901, 0x11 },
> { 0x0902, 0x00 },
> @@ -483,30 +393,11 @@ static const struct imx355_reg mode_1924x1080_regs[] = {
> { 0x034d, 0x84 },
> { 0x034e, 0x04 },
> { 0x034f, 0x38 },
> - { 0x0301, 0x05 },
> - { 0x0303, 0x01 },
> - { 0x0305, 0x02 },
> - { 0x030b, 0x01 },
> - { 0x030d, 0x02 },
> - { 0x0310, 0x00 },
> { 0x0700, 0x00 },
> { 0x0701, 0x10 },
> - { 0x0820, 0x0b },
> - { 0x0821, 0x40 },
> - { 0x3088, 0x04 },
> - { 0x6813, 0x02 },
> - { 0x6835, 0x07 },
> - { 0x6836, 0x01 },
> - { 0x6837, 0x04 },
> - { 0x684d, 0x07 },
> - { 0x684e, 0x01 },
> - { 0x684f, 0x04 },
> };
>
> static const struct imx355_reg mode_1920x1080_regs[] = {
> - { 0x0112, 0x0a },
> - { 0x0113, 0x0a },
> - { 0x0114, 0x03 },
> { 0x0342, 0x0e },
> { 0x0343, 0x58 },
> { 0x0340, 0x05 },
> @@ -519,8 +410,6 @@ static const struct imx355_reg mode_1920x1080_regs[] = {
> { 0x0349, 0x27 },
> { 0x034a, 0x06 },
> { 0x034b, 0xeb },
> - { 0x0220, 0x00 },
> - { 0x0222, 0x01 },
> { 0x0900, 0x00 },
> { 0x0901, 0x11 },
> { 0x0902, 0x00 },
> @@ -528,30 +417,11 @@ static const struct imx355_reg mode_1920x1080_regs[] = {
> { 0x034d, 0x80 },
> { 0x034e, 0x04 },
> { 0x034f, 0x38 },
> - { 0x0301, 0x05 },
> - { 0x0303, 0x01 },
> - { 0x0305, 0x02 },
> - { 0x030b, 0x01 },
> - { 0x030d, 0x02 },
> - { 0x0310, 0x00 },
> { 0x0700, 0x00 },
> { 0x0701, 0x10 },
> - { 0x0820, 0x0b },
> - { 0x0821, 0x40 },
> - { 0x3088, 0x04 },
> - { 0x6813, 0x02 },
> - { 0x6835, 0x07 },
> - { 0x6836, 0x01 },
> - { 0x6837, 0x04 },
> - { 0x684d, 0x07 },
> - { 0x684e, 0x01 },
> - { 0x684f, 0x04 },
> };
>
> static const struct imx355_reg mode_1640x1232_regs[] = {
> - { 0x0112, 0x0a },
> - { 0x0113, 0x0a },
> - { 0x0114, 0x03 },
> { 0x0342, 0x07 },
> { 0x0343, 0x2c },
> { 0x0340, 0x05 },
> @@ -564,8 +434,6 @@ static const struct imx355_reg mode_1640x1232_regs[] = {
> { 0x0349, 0xcf },
> { 0x034a, 0x09 },
> { 0x034b, 0x9f },
> - { 0x0220, 0x00 },
> - { 0x0222, 0x01 },
> { 0x0900, 0x01 },
> { 0x0901, 0x22 },
> { 0x0902, 0x00 },
> @@ -573,30 +441,11 @@ static const struct imx355_reg mode_1640x1232_regs[] = {
> { 0x034d, 0x68 },
> { 0x034e, 0x04 },
> { 0x034f, 0xd0 },
> - { 0x0301, 0x05 },
> - { 0x0303, 0x01 },
> - { 0x0305, 0x02 },
> - { 0x030b, 0x01 },
> - { 0x030d, 0x02 },
> - { 0x0310, 0x00 },
> { 0x0700, 0x00 },
> { 0x0701, 0x10 },
> - { 0x0820, 0x0b },
> - { 0x0821, 0x40 },
> - { 0x3088, 0x04 },
> - { 0x6813, 0x02 },
> - { 0x6835, 0x07 },
> - { 0x6836, 0x01 },
> - { 0x6837, 0x04 },
> - { 0x684d, 0x07 },
> - { 0x684e, 0x01 },
> - { 0x684f, 0x04 },
> };
>
> static const struct imx355_reg mode_1640x922_regs[] = {
> - { 0x0112, 0x0a },
> - { 0x0113, 0x0a },
> - { 0x0114, 0x03 },
> { 0x0342, 0x07 },
> { 0x0343, 0x2c },
> { 0x0340, 0x05 },
> @@ -609,8 +458,6 @@ static const struct imx355_reg mode_1640x922_regs[] = {
> { 0x0349, 0xcf },
> { 0x034a, 0x08 },
> { 0x034b, 0x63 },
> - { 0x0220, 0x00 },
> - { 0x0222, 0x01 },
> { 0x0900, 0x01 },
> { 0x0901, 0x22 },
> { 0x0902, 0x00 },
> @@ -618,30 +465,11 @@ static const struct imx355_reg mode_1640x922_regs[] = {
> { 0x034d, 0x68 },
> { 0x034e, 0x03 },
> { 0x034f, 0x9a },
> - { 0x0301, 0x05 },
> - { 0x0303, 0x01 },
> - { 0x0305, 0x02 },
> - { 0x030b, 0x01 },
> - { 0x030d, 0x02 },
> - { 0x0310, 0x00 },
> { 0x0700, 0x00 },
> { 0x0701, 0x10 },
> - { 0x0820, 0x0b },
> - { 0x0821, 0x40 },
> - { 0x3088, 0x04 },
> - { 0x6813, 0x02 },
> - { 0x6835, 0x07 },
> - { 0x6836, 0x01 },
> - { 0x6837, 0x04 },
> - { 0x684d, 0x07 },
> - { 0x684e, 0x01 },
> - { 0x684f, 0x04 },
> };
>
> static const struct imx355_reg mode_1300x736_regs[] = {
> - { 0x0112, 0x0a },
> - { 0x0113, 0x0a },
> - { 0x0114, 0x03 },
> { 0x0342, 0x07 },
> { 0x0343, 0x2c },
> { 0x0340, 0x05 },
> @@ -654,8 +482,6 @@ static const struct imx355_reg mode_1300x736_regs[] = {
> { 0x0349, 0x7f },
> { 0x034a, 0x07 },
> { 0x034b, 0xaf },
> - { 0x0220, 0x00 },
> - { 0x0222, 0x01 },
> { 0x0900, 0x01 },
> { 0x0901, 0x22 },
> { 0x0902, 0x00 },
> @@ -663,30 +489,11 @@ static const struct imx355_reg mode_1300x736_regs[] = {
> { 0x034d, 0x14 },
> { 0x034e, 0x02 },
> { 0x034f, 0xe0 },
> - { 0x0301, 0x05 },
> - { 0x0303, 0x01 },
> - { 0x0305, 0x02 },
> - { 0x030b, 0x01 },
> - { 0x030d, 0x02 },
> - { 0x0310, 0x00 },
> { 0x0700, 0x00 },
> { 0x0701, 0x10 },
> - { 0x0820, 0x0b },
> - { 0x0821, 0x40 },
> - { 0x3088, 0x04 },
> - { 0x6813, 0x02 },
> - { 0x6835, 0x07 },
> - { 0x6836, 0x01 },
> - { 0x6837, 0x04 },
> - { 0x684d, 0x07 },
> - { 0x684e, 0x01 },
> - { 0x684f, 0x04 },
> };
>
> static const struct imx355_reg mode_1296x736_regs[] = {
> - { 0x0112, 0x0a },
> - { 0x0113, 0x0a },
> - { 0x0114, 0x03 },
> { 0x0342, 0x07 },
> { 0x0343, 0x2c },
> { 0x0340, 0x05 },
> @@ -699,8 +506,6 @@ static const struct imx355_reg mode_1296x736_regs[] = {
> { 0x0349, 0x77 },
> { 0x034a, 0x07 },
> { 0x034b, 0xaf },
> - { 0x0220, 0x00 },
> - { 0x0222, 0x01 },
> { 0x0900, 0x01 },
> { 0x0901, 0x22 },
> { 0x0902, 0x00 },
> @@ -708,30 +513,11 @@ static const struct imx355_reg mode_1296x736_regs[] = {
> { 0x034d, 0x10 },
> { 0x034e, 0x02 },
> { 0x034f, 0xe0 },
> - { 0x0301, 0x05 },
> - { 0x0303, 0x01 },
> - { 0x0305, 0x02 },
> - { 0x030b, 0x01 },
> - { 0x030d, 0x02 },
> - { 0x0310, 0x00 },
> { 0x0700, 0x00 },
> { 0x0701, 0x10 },
> - { 0x0820, 0x0b },
> - { 0x0821, 0x40 },
> - { 0x3088, 0x04 },
> - { 0x6813, 0x02 },
> - { 0x6835, 0x07 },
> - { 0x6836, 0x01 },
> - { 0x6837, 0x04 },
> - { 0x684d, 0x07 },
> - { 0x684e, 0x01 },
> - { 0x684f, 0x04 },
> };
>
> static const struct imx355_reg mode_1284x720_regs[] = {
> - { 0x0112, 0x0a },
> - { 0x0113, 0x0a },
> - { 0x0114, 0x03 },
> { 0x0342, 0x07 },
> { 0x0343, 0x2c },
> { 0x0340, 0x05 },
> @@ -744,8 +530,6 @@ static const struct imx355_reg mode_1284x720_regs[] = {
> { 0x0349, 0x6f },
> { 0x034a, 0x07 },
> { 0x034b, 0x9f },
> - { 0x0220, 0x00 },
> - { 0x0222, 0x01 },
> { 0x0900, 0x01 },
> { 0x0901, 0x22 },
> { 0x0902, 0x00 },
> @@ -753,30 +537,11 @@ static const struct imx355_reg mode_1284x720_regs[] = {
> { 0x034d, 0x04 },
> { 0x034e, 0x02 },
> { 0x034f, 0xd0 },
> - { 0x0301, 0x05 },
> - { 0x0303, 0x01 },
> - { 0x0305, 0x02 },
> - { 0x030b, 0x01 },
> - { 0x030d, 0x02 },
> - { 0x0310, 0x00 },
> { 0x0700, 0x00 },
> { 0x0701, 0x10 },
> - { 0x0820, 0x0b },
> - { 0x0821, 0x40 },
> - { 0x3088, 0x04 },
> - { 0x6813, 0x02 },
> - { 0x6835, 0x07 },
> - { 0x6836, 0x01 },
> - { 0x6837, 0x04 },
> - { 0x684d, 0x07 },
> - { 0x684e, 0x01 },
> - { 0x684f, 0x04 },
> };
>
> static const struct imx355_reg mode_1280x720_regs[] = {
> - { 0x0112, 0x0a },
> - { 0x0113, 0x0a },
> - { 0x0114, 0x03 },
> { 0x0342, 0x07 },
> { 0x0343, 0x2c },
> { 0x0340, 0x05 },
> @@ -789,8 +554,6 @@ static const struct imx355_reg mode_1280x720_regs[] = {
> { 0x0349, 0x67 },
> { 0x034a, 0x07 },
> { 0x034b, 0x9f },
> - { 0x0220, 0x00 },
> - { 0x0222, 0x01 },
> { 0x0900, 0x01 },
> { 0x0901, 0x22 },
> { 0x0902, 0x00 },
> @@ -798,30 +561,11 @@ static const struct imx355_reg mode_1280x720_regs[] = {
> { 0x034d, 0x00 },
> { 0x034e, 0x02 },
> { 0x034f, 0xd0 },
> - { 0x0301, 0x05 },
> - { 0x0303, 0x01 },
> - { 0x0305, 0x02 },
> - { 0x030b, 0x01 },
> - { 0x030d, 0x02 },
> - { 0x0310, 0x00 },
> { 0x0700, 0x00 },
> { 0x0701, 0x10 },
> - { 0x0820, 0x0b },
> - { 0x0821, 0x40 },
> - { 0x3088, 0x04 },
> - { 0x6813, 0x02 },
> - { 0x6835, 0x07 },
> - { 0x6836, 0x01 },
> - { 0x6837, 0x04 },
> - { 0x684d, 0x07 },
> - { 0x684e, 0x01 },
> - { 0x684f, 0x04 },
> };
>
> static const struct imx355_reg mode_820x616_regs[] = {
> - { 0x0112, 0x0a },
> - { 0x0113, 0x0a },
> - { 0x0114, 0x03 },
> { 0x0342, 0x0e },
> { 0x0343, 0x58 },
> { 0x0340, 0x02 },
> @@ -834,8 +578,6 @@ static const struct imx355_reg mode_820x616_regs[] = {
> { 0x0349, 0xcf },
> { 0x034a, 0x09 },
> { 0x034b, 0x9f },
> - { 0x0220, 0x00 },
> - { 0x0222, 0x01 },
> { 0x0900, 0x01 },
> { 0x0901, 0x44 },
> { 0x0902, 0x00 },
> @@ -843,24 +585,8 @@ static const struct imx355_reg mode_820x616_regs[] = {
> { 0x034d, 0x34 },
> { 0x034e, 0x02 },
> { 0x034f, 0x68 },
> - { 0x0301, 0x05 },
> - { 0x0303, 0x01 },
> - { 0x0305, 0x02 },
> - { 0x030b, 0x01 },
> - { 0x030d, 0x02 },
> - { 0x0310, 0x00 },
> { 0x0700, 0x02 },
> { 0x0701, 0x78 },
> - { 0x0820, 0x0b },
> - { 0x0821, 0x40 },
> - { 0x3088, 0x04 },
> - { 0x6813, 0x02 },
> - { 0x6835, 0x07 },
> - { 0x6836, 0x01 },
> - { 0x6837, 0x04 },
> - { 0x684d, 0x07 },
> - { 0x684e, 0x01 },
> - { 0x684f, 0x04 },
> };
>
> static const char * const imx355_test_pattern_menu[] = {
>
> --
> 2.34.1
>
>
next prev parent reply other threads:[~2026-05-07 13:41 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 18:23 [PATCH 00/13] media/imx355: General code cleanups, and adding support for 2 lane operation Dave Stevenson
2026-05-06 18:23 ` [PATCH 01/13] media: imx355: Remove duplicated registers from the mode tables Dave Stevenson
2026-05-07 13:41 ` Jacopo Mondi [this message]
2026-05-06 18:23 ` [PATCH 02/13] media: imx355: Remove setting FRM_LENGTH_LINES in the mode regs Dave Stevenson
2026-05-07 13:50 ` Jacopo Mondi
2026-05-06 18:23 ` [PATCH 03/13] media: imx355: Programmatically set the crop parameters for each mode Dave Stevenson
2026-05-07 14:00 ` Jacopo Mondi
2026-05-07 16:01 ` Dave Stevenson
2026-05-06 18:23 ` [PATCH 04/13] media: imx355: Remove the duplication between width/height and x/y_out_size Dave Stevenson
2026-05-06 18:23 ` [PATCH 05/13] media: imx355: Set register LINE_LENGTH_PCK programmatically Dave Stevenson
2026-05-07 14:09 ` Jacopo Mondi
2026-05-07 15:18 ` Dave Stevenson
2026-05-06 18:23 ` [PATCH 06/13] media: imx355: Set binning mode registers programmatically Dave Stevenson
2026-05-07 14:12 ` Jacopo Mondi
2026-05-06 18:23 ` [PATCH 07/13] media: imx355: Remove link_freq_index from each mode as ununsed Dave Stevenson
2026-05-07 14:12 ` Jacopo Mondi
2026-05-06 18:23 ` [PATCH 08/13] media: imx355: pixel_rate never changes, so don't recompute Dave Stevenson
2026-05-07 14:13 ` Jacopo Mondi
2026-05-06 18:23 ` [PATCH 09/13] media: imx355: Remove redundant fll_min, and implement fixed offset Dave Stevenson
2026-05-07 14:29 ` Jacopo Mondi
2026-05-07 15:21 ` Dave Stevenson
2026-05-06 18:23 ` [PATCH 10/13] media: imx355: Add support for get_selection Dave Stevenson
2026-05-07 14:42 ` Jacopo Mondi
2026-05-07 15:02 ` Dave Stevenson
2026-05-06 18:23 ` [PATCH 11/13] media: imx355: Use pm_runtime autosuspend_delay Dave Stevenson
2026-05-07 14:43 ` Jacopo Mondi
2026-05-06 18:23 ` [PATCH 12/13] media: imx355: Convert to new CCI register access helpers Dave Stevenson
2026-05-07 14:49 ` Jacopo Mondi
2026-05-06 18:23 ` [PATCH 13/13] media: imx355: Support 2 lane readout Dave Stevenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afyWYG_idVPEF7RD@zed \
--to=jacopo.mondi@ideasonboard.com \
--cc=20260414-imx355-24mhz-v1-1-9ae77bc6e7ec@ixit.cz \
--cc=dave.stevenson@raspberrypi.com \
--cc=david@ixit.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tian.shu.qiu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox