From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-media@vger.kernel.org
Cc: "Yan, Dongcheng" <dongcheng.yan@intel.com>,
Mehdi Djait <mehdi.djait@linux.intel.com>,
"Yu, Ong Hock" <ong.hock.yu@intel.com>,
"Ng, Khai Wen" <khai.wen.ng@intel.com>,
Antti Laakso <antti.laakso@linux.intel.com>,
"Bajpai, Manik" <manik.bajpai@intel.com>,
Divyamani Tripathi <divyamani.tripathi@intel.com>,
"Sapre, Sarang" <sarang.sapre@intel.com>,
"Yao, Hao" <hao.yao@intel.com>
Subject: [PATCH 1/5] media: ipu6: Don't mark need_reset based on returned buffers
Date: Thu, 8 Oct 2026 11:52:43 +0300 [thread overview]
Message-ID: <20261008085247.798156-2-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <20261008085247.798156-1-sakari.ailus@linux.intel.com>
The IPU7 firmware stops streaming without PIN_DATA_READY events for the
queued buffers, unlike IPU6 firmware which does queue such events to the
host. This effectively causes the need_reset field of struct ipu6_isys to
be always true after streaming, even though there's no actual problem.
Don't set need_reset field based on still-active buffers.
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
drivers/media/pci/intel/ipu6/ipu6-isys-queue.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/drivers/media/pci/intel/ipu6/ipu6-isys-queue.c b/drivers/media/pci/intel/ipu6/ipu6-isys-queue.c
index 23d00e1f89e8..6596833e95d4 100644
--- a/drivers/media/pci/intel/ipu6/ipu6-isys-queue.c
+++ b/drivers/media/pci/intel/ipu6/ipu6-isys-queue.c
@@ -420,9 +420,7 @@ static int ipu6_isys_link_fmt_validate(struct ipu6_isys_queue *aq)
static void return_buffers(struct ipu6_isys_queue *aq,
enum vb2_buffer_state state)
{
- struct ipu6_isys_video *av = ipu6_isys_queue_to_video(aq);
struct ipu6_isys_buffer *ib;
- bool need_reset = false;
unsigned long flags;
spin_lock_irqsave(&aq->lock, flags);
@@ -458,18 +456,9 @@ static void return_buffers(struct ipu6_isys_queue *aq,
vb2_buffer_done(vb, state);
spin_lock_irqsave(&aq->lock, flags);
- need_reset = true;
}
spin_unlock_irqrestore(&aq->lock, flags);
-
- if (need_reset) {
- mutex_lock(&av->isys->mutex);
- av->isys->need_reset = true;
- mutex_unlock(&av->isys->mutex);
- dev_warn(&av->isys->adev->auxdev.dev,
- "buffer list not empty, needs isys reset\n");
- }
}
static void ipu6_isys_stream_cleanup(struct ipu6_isys_video *av)
--
2.47.3
next prev parent reply other threads:[~2026-10-08 8:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 8:52 [PATCH 0/5] IPU reset workaround changes Sakari Ailus
2026-10-08 8:52 ` Sakari Ailus [this message]
2026-10-08 8:52 ` [PATCH 2/5] media: ipu6: Tell about not being able to obtain frame descriptor Sakari Ailus
2026-10-09 11:11 ` Antti Laakso
2026-10-09 11:20 ` Sakari Ailus
2026-10-08 8:52 ` [PATCH 3/5] media: ipu6: Prevent starting streaming if ISYS needs reset Sakari Ailus
2026-10-09 10:59 ` Antti Laakso
2026-10-09 11:16 ` Sakari Ailus
2026-10-08 8:52 ` [PATCH 4/5] media: ipu6: Remove need_reset check from video device open Sakari Ailus
2026-10-08 8:52 ` [PATCH 5/5] media: ipu6: Return errors from stream stop and close Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261008085247.798156-2-sakari.ailus@linux.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=antti.laakso@linux.intel.com \
--cc=divyamani.tripathi@intel.com \
--cc=dongcheng.yan@intel.com \
--cc=hao.yao@intel.com \
--cc=khai.wen.ng@intel.com \
--cc=linux-media@vger.kernel.org \
--cc=manik.bajpai@intel.com \
--cc=mehdi.djait@linux.intel.com \
--cc=ong.hock.yu@intel.com \
--cc=sarang.sapre@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox