Re: [PATCH 3/5] media: ipu6: Prevent starting streaming if ISYS needs reset

[Sakari Ailus <sakari.ailus@linux.intel.com>]

Hi Antti,

Thanks for the review.

On Fri, Oct 09, 2026 at 01:59:04PM +0300, Antti Laakso wrote:
> On Thu, Oct 08, 2026 at 11:52:45AM +0300, Sakari Ailus wrote:
> > Fail starting streaming whenever ISYS needs to be reset to resume normal
> > operation.
> > 
> > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> > ---
> >  drivers/media/pci/intel/ipu6/ipu6-isys-queue.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/drivers/media/pci/intel/ipu6/ipu6-isys-queue.c b/drivers/media/pci/intel/ipu6/ipu6-isys-queue.c
> > index 6596833e95d4..978acbd72e63 100644
> > --- a/drivers/media/pci/intel/ipu6/ipu6-isys-queue.c
> > +++ b/drivers/media/pci/intel/ipu6/ipu6-isys-queue.c
> > @@ -481,6 +481,11 @@ static int start_streaming(struct vb2_queue *q, unsigned int count)
> >  		av->vdev.name, ipu6_isys_get_frame_width(av),
> >  		ipu6_isys_get_frame_height(av), pfmt->css_pixelformat);
> >  
> > +	scoped_guard(mutex, &av->isys->mutex) {
> > +		if (av->isys->need_reset)
> > +			return -EIO;
> 
> Shouldn't this goto out_return_buffers path as well?

Yes, I'll fix that for v2.

> 
> > +	}
> > +
> >  	remote_pad = media_pad_remote_pad_unique(&av->pad);
> >  	if (IS_ERR(remote_pad)) {
> >  		dev_dbg(dev, "failed to get remote pad\n");

-- 
Regards,

Sakari Ailus