Re: [PATCH 2/5] media: ipu6: Tell about not being able to obtain frame descriptor

[Sakari Ailus <sakari.ailus@linux.intel.com>]

Hi Antti,

On Fri, Oct 09, 2026 at 02:11:17PM +0300, Antti Laakso wrote:
> On Thu, Oct 08, 2026 at 11:52:44AM +0300, Sakari Ailus wrote:
> > Not being able to obtain a frame descriptor is a fatal error at this
> > point. The frame descriptor should be stored for the duration of the
> > streaming operation.
> > 
> > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> > ---
> >  drivers/media/pci/intel/ipu6/ipu6-isys-csi2.c | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/media/pci/intel/ipu6/ipu6-isys-csi2.c b/drivers/media/pci/intel/ipu6/ipu6-isys-csi2.c
> > index 152545427930..3e9bfda2a8b9 100644
> > --- a/drivers/media/pci/intel/ipu6/ipu6-isys-csi2.c
> > +++ b/drivers/media/pci/intel/ipu6/ipu6-isys-csi2.c
> > @@ -749,8 +749,10 @@ static int ipu6_isys_csi2_disable_streams(struct v4l2_subdev *sd,
> >  	lockdep_assert_held(&csi2->isys->stream_mutex);
> >  
> >  	ret = ipu6_isys_get_frame_desc(remote_sd, remote_pad->index, &desc);
> > -	if (ret)
> > -		return ret;
> > +	if (ret) {
> > +		dev_err(sd->dev, "cannot obtain frame descriptor\n");
> > +		return 0;
> > +	}
> 
> According to title this is about logging the failure, but now this also
> masks the error. Should this tell about the error and take the cleanup
> path?

The problem here is that there's no way to do proper cleanup without frame
descriptors. I could return an error here to leave streaming status as-is.

The frame descriptors should be moved to sub-device state so there would be
no issue obtaining them anymore.

> 
> >  
> >  	sink_streams =
> >  		v4l2_subdev_state_xlate_streams(state, pad, CSI2_PAD_SINK,

-- 
Regards,

Sakari Ailus