Linux Media Controller development
 help / color / mirror / Atom feed
From: Antti Laakso <antti.laakso@linux.intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, "Yan,
	Dongcheng" <dongcheng.yan@intel.com>,
	Mehdi Djait <mehdi.djait@linux.intel.com>,
	"Yu, Ong Hock" <ong.hock.yu@intel.com>,
	"Ng, Khai Wen" <khai.wen.ng@intel.com>,
	"Bajpai, Manik" <manik.bajpai@intel.com>,
	Divyamani Tripathi <divyamani.tripathi@intel.com>,
	"Sapre, Sarang" <sarang.sapre@intel.com>,
	"Yao, Hao" <hao.yao@intel.com>
Subject: Re: [PATCH 3/5] media: ipu6: Prevent starting streaming if ISYS needs reset
Date: Fri, 9 Oct 2026 13:59:04 +0300	[thread overview]
Message-ID: <asjI-C0a13tS567g@alaakso-desk> (raw)
In-Reply-To: <20261008085247.798156-4-sakari.ailus@linux.intel.com>

On Thu, Oct 08, 2026 at 11:52:45AM +0300, Sakari Ailus wrote:
> Fail starting streaming whenever ISYS needs to be reset to resume normal
> operation.
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
>  drivers/media/pci/intel/ipu6/ipu6-isys-queue.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/media/pci/intel/ipu6/ipu6-isys-queue.c b/drivers/media/pci/intel/ipu6/ipu6-isys-queue.c
> index 6596833e95d4..978acbd72e63 100644
> --- a/drivers/media/pci/intel/ipu6/ipu6-isys-queue.c
> +++ b/drivers/media/pci/intel/ipu6/ipu6-isys-queue.c
> @@ -481,6 +481,11 @@ static int start_streaming(struct vb2_queue *q, unsigned int count)
>  		av->vdev.name, ipu6_isys_get_frame_width(av),
>  		ipu6_isys_get_frame_height(av), pfmt->css_pixelformat);
>  
> +	scoped_guard(mutex, &av->isys->mutex) {
> +		if (av->isys->need_reset)
> +			return -EIO;

Shouldn't this goto out_return_buffers path as well?

> +	}
> +
>  	remote_pad = media_pad_remote_pad_unique(&av->pad);
>  	if (IS_ERR(remote_pad)) {
>  		dev_dbg(dev, "failed to get remote pad\n");
> -- 
> 2.47.3
> 

  reply	other threads:[~2026-10-09 10:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-08  8:52 [PATCH 0/5] IPU reset workaround changes Sakari Ailus
2026-10-08  8:52 ` [PATCH 1/5] media: ipu6: Don't mark need_reset based on returned buffers Sakari Ailus
2026-10-08  8:52 ` [PATCH 2/5] media: ipu6: Tell about not being able to obtain frame descriptor Sakari Ailus
2026-10-09 11:11   ` Antti Laakso
2026-10-09 11:20     ` Sakari Ailus
2026-10-08  8:52 ` [PATCH 3/5] media: ipu6: Prevent starting streaming if ISYS needs reset Sakari Ailus
2026-10-09 10:59   ` Antti Laakso [this message]
2026-10-09 11:16     ` Sakari Ailus
2026-10-08  8:52 ` [PATCH 4/5] media: ipu6: Remove need_reset check from video device open Sakari Ailus
2026-10-08  8:52 ` [PATCH 5/5] media: ipu6: Return errors from stream stop and close Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=asjI-C0a13tS567g@alaakso-desk \
    --to=antti.laakso@linux.intel.com \
    --cc=divyamani.tripathi@intel.com \
    --cc=dongcheng.yan@intel.com \
    --cc=hao.yao@intel.com \
    --cc=khai.wen.ng@intel.com \
    --cc=linux-media@vger.kernel.org \
    --cc=manik.bajpai@intel.com \
    --cc=mehdi.djait@linux.intel.com \
    --cc=ong.hock.yu@intel.com \
    --cc=sakari.ailus@linux.intel.com \
    --cc=sarang.sapre@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox