* [PATCH] correct formats info in s5p-mfc encoder
@ 2014-07-23 16:15 ayaka
2014-07-23 16:15 ` [PATCH] s5p-mfc: correct the formats info for encoder ayaka
0 siblings, 1 reply; 9+ messages in thread
From: ayaka @ 2014-07-23 16:15 UTC (permalink / raw)
To: linux-media; +Cc: kyungmin.park, k.debski, jtp.park, m.chehab, ayaka
I have tested it in exynos 4412.
I enable MFC and with 64MB buffer in echo bank.
ayaka (1):
s5p-mfc: correct the formats info for encoder
drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
--
1.9.3
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] s5p-mfc: correct the formats info for encoder
2014-07-23 16:15 [PATCH] correct formats info in s5p-mfc encoder ayaka
@ 2014-07-23 16:15 ` ayaka
2014-09-22 16:28 ` Kamil Debski
2014-10-22 11:46 ` Kamil Debski
0 siblings, 2 replies; 9+ messages in thread
From: ayaka @ 2014-07-23 16:15 UTC (permalink / raw)
To: linux-media; +Cc: kyungmin.park, k.debski, jtp.park, m.chehab, ayaka
The NV12M is supported by all the version of MFC, so it is better
to use it as default OUTPUT format.
MFC v5 doesn't support NV21, I have tested it, for the SEC doc
it is not supported either.
---
drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
index d26b248..4ea3796 100644
--- a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
+++ b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
@@ -32,7 +32,7 @@
#include "s5p_mfc_intr.h"
#include "s5p_mfc_opr.h"
-#define DEF_SRC_FMT_ENC V4L2_PIX_FMT_NV12MT
+#define DEF_SRC_FMT_ENC V4L2_PIX_FMT_NV12M
#define DEF_DST_FMT_ENC V4L2_PIX_FMT_H264
static struct s5p_mfc_fmt formats[] = {
@@ -67,8 +67,7 @@ static struct s5p_mfc_fmt formats[] = {
.codec_mode = S5P_MFC_CODEC_NONE,
.type = MFC_FMT_RAW,
.num_planes = 2,
- .versions = MFC_V5_BIT | MFC_V6_BIT | MFC_V7_BIT |
- MFC_V8_BIT,
+ .versions = MFC_V6_BIT | MFC_V7_BIT | MFC_V8_BIT,
},
{
.name = "H264 Encoded Stream",
--
1.9.3
^ permalink raw reply related [flat|nested] 9+ messages in thread* RE: [PATCH] s5p-mfc: correct the formats info for encoder
2014-07-23 16:15 ` [PATCH] s5p-mfc: correct the formats info for encoder ayaka
@ 2014-09-22 16:28 ` Kamil Debski
2014-09-22 16:50 ` ayaka
2014-10-22 11:46 ` Kamil Debski
1 sibling, 1 reply; 9+ messages in thread
From: Kamil Debski @ 2014-09-22 16:28 UTC (permalink / raw)
To: 'ayaka', linux-media; +Cc: kyungmin.park, jtp.park, m.chehab
Hi Ayaka,
Sorry for such a late reply - I just noticed this patch.
> From: ayaka [mailto:ayaka@soulik.info]
> Sent: Wednesday, July 23, 2014 6:15 PM
> To: linux-media@vger.kernel.org
> Cc: kyungmin.park@samsung.com; k.debski@samsung.com;
> jtp.park@samsung.com; m.chehab@samsung.com; ayaka
> Subject: [PATCH] s5p-mfc: correct the formats info for encoder
>
> The NV12M is supported by all the version of MFC, so it is better to
> use it as default OUTPUT format.
> MFC v5 doesn't support NV21, I have tested it, for the SEC doc it is
> not supported either.
A proper Sign-off is missing here.
According to the documentation of MFC v5 I have non-tiled format is
supported. Which documentation were you looking at?
>From my documentation:
++++++++++++++
ENC_MAP_FOR_CUR 0xC51C
Memory structure setting register of the current frame. R/W 0x00000000
Bits Name Description Reset Value
[31:2] RESERVED Reserved 0
[1:0] ENC_MAP_FOR_CUR Memory structure of the current frame
0 : Linear mode
3 : 64x32 tiled mode 0
++++++++++++++
Best wishes,
--
Kamil Debski
Samsung R&D Institute Poland
> ---
> drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
> b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
> index d26b248..4ea3796 100644
> --- a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
> @@ -32,7 +32,7 @@
> #include "s5p_mfc_intr.h"
> #include "s5p_mfc_opr.h"
>
> -#define DEF_SRC_FMT_ENC V4L2_PIX_FMT_NV12MT
> +#define DEF_SRC_FMT_ENC V4L2_PIX_FMT_NV12M
> #define DEF_DST_FMT_ENC V4L2_PIX_FMT_H264
>
> static struct s5p_mfc_fmt formats[] = { @@ -67,8 +67,7 @@ static
> struct s5p_mfc_fmt formats[] = {
> .codec_mode = S5P_MFC_CODEC_NONE,
> .type = MFC_FMT_RAW,
> .num_planes = 2,
> - .versions = MFC_V5_BIT | MFC_V6_BIT | MFC_V7_BIT |
> - MFC_V8_BIT,
> + .versions = MFC_V6_BIT | MFC_V7_BIT | MFC_V8_BIT,
> },
> {
> .name = "H264 Encoded Stream",
> --
> 1.9.3
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] s5p-mfc: correct the formats info for encoder
2014-09-22 16:28 ` Kamil Debski
@ 2014-09-22 16:50 ` ayaka
0 siblings, 0 replies; 9+ messages in thread
From: ayaka @ 2014-09-22 16:50 UTC (permalink / raw)
To: linux-media; +Cc: kyungmin.park, jtp.park, m.chehab
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
2014/09/23 00:28, Kamil Debski wrote:
> Hi Ayaka,
>
> Sorry for such a late reply - I just noticed this patch.
>
>> The NV12M is supported by all the version of MFC, so it is better
>> to use it as default OUTPUT format. MFC v5 doesn't support NV21,
>> I have tested it, for the SEC doc it is not supported either.
>
> A proper Sign-off is missing here.
>
Sorry to miss it again.
> According to the documentation of MFC v5 I have non-tiled format
> is supported. Which documentation were you looking at?
>
But the V4L2_PIX_FMT_NV12MT is only supported by MFC_V5_BIT from your
code, V4L2_PIX_FMT_NV12M is supported by all the version.
>> From my documentation:
> ++++++++++++++ ENC_MAP_FOR_CUR 0xC51C Memory structure setting
> register of the current frame. R/W 0x00000000
>
> Bits Name Description Reset Value [31:2] RESERVED Reserved 0 [1:0]
> ENC_MAP_FOR_CUR Memory structure of the current frame 0 : Linear
> mode 3 : 64x32 tiled mode 0 ++++++++++++++
>
In the page 2277. The same result.
I think the V4L2_PIX_FMT_NV12MT is 64x32 Tiles mode, but what I remove
for MFC v5 is V4L2_PIX_FMT_NV21M.
> Best wishes,
>
- --
ayaka
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBAgAGBQJUIFNLAAoJEPsGh4kgR4i5HcIP/2qwn7uIFq66qpSajXmtcLx3
3/wt8n26u6GhTMUnIJKZS07FGtv7qizUVqeY3WmfWQw3jLaUjZeVviVH08y3DrE8
+7Vjq2rxz57ou4bBtc4qIgTWB7z2yuVSpBOYUB94laItQ7KDap4EgLf89m4KaKTt
5nULR0byxXh+RuUOw80v0eP/TBz7SRfYZnulASV9QlGS6T3Xp6v4U6W8LbSbieR5
63PwPxYP7aDVb5R6qzaLIVXNuI53vn5VhrQ6JJUfKee5YSbkV/Ff6XK+7/P162Pn
5cVt06X+RUeZXHGqCroMNb9cdm+7JHOZL458NPn4NmTJnFcPNu6JzW9iLymHeHC8
iFmNhpDuHJBulKsW44lqKe1fHT22a5C/oJAI1ZS9c3yrH+TqHkfEkUJjglSRByzj
ptTFFZVTCdiL5VwnDlfowR4ZzrkZuoWzHIn5cGeHogvbLbxCbtV67+IFpWlXfyJu
rKnCI+DKYb5cjEiHm7kzGbAO04AfNMT79sNwrD+sPuvnaFyRiy2rjKv3ubnPFRVp
3agNRzAcCgmsW3K10P3ism4ceJUqeZtFvieCQrjiQdxj8EB7QAcgOhgn3K//zrQ1
mQP7xuVQcwpaRIOx/3jSlVWYFrkFs2+tmgS9oEn+v40gXOQXk8rML21gHvpDuCnf
qJXx0UVYQRV7Bhgv8EFW
=SNTL
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH] s5p-mfc: correct the formats info for encoder
2014-07-23 16:15 ` [PATCH] s5p-mfc: correct the formats info for encoder ayaka
2014-09-22 16:28 ` Kamil Debski
@ 2014-10-22 11:46 ` Kamil Debski
2014-10-22 14:07 ` ayaka
1 sibling, 1 reply; 9+ messages in thread
From: Kamil Debski @ 2014-10-22 11:46 UTC (permalink / raw)
To: 'ayaka', linux-media; +Cc: kyungmin.park, jtp.park, m.chehab
Hi Ayaka,
Could you resend this patch with your sign-off?
Best wishes,
--
Kamil Debski
Samsung R&D Institute Poland
> -----Original Message-----
> From: ayaka [mailto:ayaka@soulik.info]
> Sent: Wednesday, July 23, 2014 6:15 PM
> To: linux-media@vger.kernel.org
> Cc: kyungmin.park@samsung.com; k.debski@samsung.com;
> jtp.park@samsung.com; m.chehab@samsung.com; ayaka
> Subject: [PATCH] s5p-mfc: correct the formats info for encoder
>
> The NV12M is supported by all the version of MFC, so it is better to
> use it as default OUTPUT format.
> MFC v5 doesn't support NV21, I have tested it, for the SEC doc it is
> not supported either.
> ---
> drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
> b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
> index d26b248..4ea3796 100644
> --- a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
> @@ -32,7 +32,7 @@
> #include "s5p_mfc_intr.h"
> #include "s5p_mfc_opr.h"
>
> -#define DEF_SRC_FMT_ENC V4L2_PIX_FMT_NV12MT
> +#define DEF_SRC_FMT_ENC V4L2_PIX_FMT_NV12M
> #define DEF_DST_FMT_ENC V4L2_PIX_FMT_H264
>
> static struct s5p_mfc_fmt formats[] = { @@ -67,8 +67,7 @@ static
> struct s5p_mfc_fmt formats[] = {
> .codec_mode = S5P_MFC_CODEC_NONE,
> .type = MFC_FMT_RAW,
> .num_planes = 2,
> - .versions = MFC_V5_BIT | MFC_V6_BIT | MFC_V7_BIT |
> - MFC_V8_BIT,
> + .versions = MFC_V6_BIT | MFC_V7_BIT | MFC_V8_BIT,
> },
> {
> .name = "H264 Encoded Stream",
> --
> 1.9.3
^ permalink raw reply [flat|nested] 9+ messages in thread* RE: [PATCH] s5p-mfc: correct the formats info for encoder
2014-10-22 11:46 ` Kamil Debski
@ 2014-10-22 14:07 ` ayaka
2014-10-22 14:07 ` ayaka
0 siblings, 1 reply; 9+ messages in thread
From: ayaka @ 2014-10-22 14:07 UTC (permalink / raw)
To: linux-media; +Cc: k.debski, kyungmin.park, jtp.park, m.chehab, ayaka
I am very sorry to forget the Sign-off again and thank you for
reviewing.
ayaka (1):
s5p-mfc: correct the formats info for encoder
drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
--
1.9.3
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] s5p-mfc: correct the formats info for encoder
2014-10-22 14:07 ` ayaka
@ 2014-10-22 14:07 ` ayaka
0 siblings, 0 replies; 9+ messages in thread
From: ayaka @ 2014-10-22 14:07 UTC (permalink / raw)
To: linux-media; +Cc: k.debski, kyungmin.park, jtp.park, m.chehab, ayaka
The NV12M is supported by all the version of MFC, so it is better
to use it as default OUTPUT format.
MFC v5 doesn't support NV21, I have tested it, for the SEC doc
it is not supported either.
Signed-off-by: ayaka <ayaka@soulik.info>
---
drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
index d26b248..4ea3796 100644
--- a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
+++ b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
@@ -32,7 +32,7 @@
#include "s5p_mfc_intr.h"
#include "s5p_mfc_opr.h"
-#define DEF_SRC_FMT_ENC V4L2_PIX_FMT_NV12MT
+#define DEF_SRC_FMT_ENC V4L2_PIX_FMT_NV12M
#define DEF_DST_FMT_ENC V4L2_PIX_FMT_H264
static struct s5p_mfc_fmt formats[] = {
@@ -67,8 +67,7 @@ static struct s5p_mfc_fmt formats[] = {
.codec_mode = S5P_MFC_CODEC_NONE,
.type = MFC_FMT_RAW,
.num_planes = 2,
- .versions = MFC_V5_BIT | MFC_V6_BIT | MFC_V7_BIT |
- MFC_V8_BIT,
+ .versions = MFC_V6_BIT | MFC_V7_BIT | MFC_V8_BIT,
},
{
.name = "H264 Encoded Stream",
--
1.9.3
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] s5p-mfc: correct the formats info for encoder
@ 2014-10-22 18:03 ayaka
2014-10-22 18:03 ` ayaka
0 siblings, 1 reply; 9+ messages in thread
From: ayaka @ 2014-10-22 18:03 UTC (permalink / raw)
To: linux-media; +Cc: k.debski, kyungmin.park, jtp.park, m.chehab, ayaka
I am very sorry to forget the Sign-off again and thank you for
reviewing.
ayaka (1):
s5p-mfc: correct the formats info for encoder
drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
--
1.9.3
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] s5p-mfc: correct the formats info for encoder
2014-10-22 18:03 ayaka
@ 2014-10-22 18:03 ` ayaka
0 siblings, 0 replies; 9+ messages in thread
From: ayaka @ 2014-10-22 18:03 UTC (permalink / raw)
To: linux-media; +Cc: k.debski, kyungmin.park, jtp.park, m.chehab, ayaka
The NV12M is supported by all the version of MFC, so it is better
to use it as default OUTPUT format.
MFC v5 doesn't support NV21, I have tested it, for the SEC doc
it is not supported either.
Signed-off-by: ayaka <ayaka@soulik.info>
---
drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
index d26b248..4ea3796 100644
--- a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
+++ b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
@@ -32,7 +32,7 @@
#include "s5p_mfc_intr.h"
#include "s5p_mfc_opr.h"
-#define DEF_SRC_FMT_ENC V4L2_PIX_FMT_NV12MT
+#define DEF_SRC_FMT_ENC V4L2_PIX_FMT_NV12M
#define DEF_DST_FMT_ENC V4L2_PIX_FMT_H264
static struct s5p_mfc_fmt formats[] = {
@@ -67,8 +67,7 @@ static struct s5p_mfc_fmt formats[] = {
.codec_mode = S5P_MFC_CODEC_NONE,
.type = MFC_FMT_RAW,
.num_planes = 2,
- .versions = MFC_V5_BIT | MFC_V6_BIT | MFC_V7_BIT |
- MFC_V8_BIT,
+ .versions = MFC_V6_BIT | MFC_V7_BIT | MFC_V8_BIT,
},
{
.name = "H264 Encoded Stream",
--
1.9.3
^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2014-10-22 18:03 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-23 16:15 [PATCH] correct formats info in s5p-mfc encoder ayaka
2014-07-23 16:15 ` [PATCH] s5p-mfc: correct the formats info for encoder ayaka
2014-09-22 16:28 ` Kamil Debski
2014-09-22 16:50 ` ayaka
2014-10-22 11:46 ` Kamil Debski
2014-10-22 14:07 ` ayaka
2014-10-22 14:07 ` ayaka
-- strict thread matches above, loose matches on Subject: below --
2014-10-22 18:03 ayaka
2014-10-22 18:03 ` ayaka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox