Mailing patches

Mailing patches

[Ralf Baechle]

I've updated the wiki page on the mechanics of how to mail patches to
cover more modern versions of thunderbird or similar:

  http://www.linux-mips.org/wiki/Mailing-patches

I'm not a Thunderbird (or Evolution) user myself, so I'd appreciate
proofreading and comments.

  Ralf

Re: Mailing patches

[Kumba]

Ralf Baechle wrote:
> I've updated the wiki page on the mechanics of how to mail patches to
> cover more modern versions of thunderbird or similar:
> 
>   http://www.linux-mips.org/wiki/Mailing-patches
> 
> I'm not a Thunderbird (or Evolution) user myself, so I'd appreciate
> proofreading and comments.
> 
>   Ralf

What about just attaching the patches to a message?  Seems like it'll avoid most 
of the problems Tbird has with them.  I'm just not sure if that hampers 
importing them into git or not.


--Kumba

-- 
Gentoo/MIPS Team Lead

"Such is oft the course of deeds that move the wheels of the world: small hands 
do them because they must, while the eyes of the great are elsewhere."  --Elrond

Re: Mailing patches

[Kumba]

Kumba wrote:
> 
> What about just attaching the patches to a message?  Seems like it'll 
> avoid most of the problems Tbird has with them.  I'm just not sure if 
> that hampers importing them into git or not.
> 
> 
> --Kumba

Deeerrr...

> 6) No MIME, no links, no compression, no attachments.  Just plain text.


# dd if=/dev/coffee of=/proc/self/root cpc=135 count=2
2+0 cups in
2+0 cups out
270 milligrams (0.2 g) drank, 0 s, Infinity C/s




--Kumba

-- 
Gentoo/MIPS Team Lead

"Such is oft the course of deeds that move the wheels of the world: small hands 
do them because they must, while the eyes of the great are elsewhere."  --Elrond

Re: Mailing patches

[Ralf Baechle]

On Mon, Jun 04, 2007 at 11:54:35PM -0400, Kumba wrote:

> # dd if=/dev/coffee of=/proc/self/root cpc=135 count=2
> 2+0 cups in
> 2+0 cups out
> 270 milligrams (0.2 g) drank, 0 s, Infinity C/s

Good idea :-)

  Ralf

Re: Mailing patches

[Ralf Baechle]

On Mon, Jun 04, 2007 at 11:40:02PM -0400, Kumba wrote:

> What about just attaching the patches to a message?  Seems like it'll avoid 
> most of the problems Tbird has with them.  I'm just not sure if that 
> hampers importing them into git or not.

There are issues if people have the log message in the attachment as
well.  And of course there is still the prime reason why attachments
are a no-no - most mailers won't quote them so commenting on them is
hard when discussing things.

Git has some limited abilities to handle MIME messages since quite a
while though.  But quilt which is the heart of how I manage the queue
tree doesn't.

   Ralf

Re: Mailing patches

[Tian]

sorry for the mess，when git-format-patch , wo forgot the -n para
and i would like to know what command para is recommended for sending
patch on maillist?

git-send-email --no-chain-reply-to --compose --from tiansm@lemote.com 
--no-signed-off-by-cc --smtp-server <server> --subject "Lemote Loongson 
2E patch update" --suppress-from --to linux-mips@linux-mips.org 00*

--no-chain-reply-to or --chain-reply-to ?

and.....should i resend the patches?

Tian



Ralf Baechle wrote:
> On Mon, Jun 04, 2007 at 11:40:02PM -0400, Kumba wrote:
>
>   
>> What about just attaching the patches to a message?  Seems like it'll avoid 
>> most of the problems Tbird has with them.  I'm just not sure if that 
>> hampers importing them into git or not.
>>     
>
> There are issues if people have the log message in the attachment as
> well.  And of course there is still the prime reason why attachments
> are a no-no - most mailers won't quote them so commenting on them is
> hard when discussing things.
>
> Git has some limited abilities to handle MIME messages since quite a
> while though.  But quilt which is the heart of how I manage the queue
> tree doesn't.
>
>    Ralf
>
>
>
>   

Re: Mailing patches

[Franck Bui-Huu]

Hi,

On 6/6/07, Tian <tiansm@lemote.com> wrote:
>
> --no-chain-reply-to or --chain-reply-to ?

Usually "--no-chain-reply-to" is used and I think it's easier to
discuss on the patchset with this option.

>
> and.....should i resend the patches?

Does your patchset have order depedency ? if so, I think you should.

-- 
               Franck

Re: Mailing patches

[Tian]

thx for reply

and would it be better if I use --thread when git-format-patch?

Franck Bui-Huu wrote:
> Hi,
>
> On 6/6/07, Tian <tiansm@lemote.com> wrote:
>>
>> --no-chain-reply-to or --chain-reply-to ?
>
> Usually "--no-chain-reply-to" is used and I think it's easier to
> discuss on the patchset with this option.
>
>>
>> and.....should i resend the patches?
>
> Does your patchset have order depedency ? if so, I think you should.
>

Re: Mailing patches

[Franck Bui-Huu]

On 6/6/07, Tian <tiansm@lemote.com> wrote:
> thx for reply
>
> and would it be better if I use --thread when git-format-patch?
>

Well, since you're using git-send-email with "--compose" and
"--no-chain-reply-to" switches, you don't need it. Take a look at
git-send-email and git-format-patch man pages, it's well described.

-- 
               Franck

Re: Mailing patches

[Ralf Baechle]

On Wed, Jun 06, 2007 at 01:09:32PM +0800, Tian wrote:

> sorry for the mess，when git-format-patch , wo forgot the -n para
> and i would like to know what command para is recommended for sending
> patch on maillist?
> 
> git-send-email --no-chain-reply-to --compose --from tiansm@lemote.com 
> --no-signed-off-by-cc --smtp-server <server> --subject "Lemote Loongson 
> 2E patch update" --suppress-from --to linux-mips@linux-mips.org 00*
> 
> --no-chain-reply-to or --chain-reply-to ?
> 
> and.....should i resend the patches?

No, that's fine.

I don't like --no-chain-reply-to for no better reason than that looking
a bit odd in some threded mail readers.  But that's just a matter of
preference not a technical need.

The ordering of patches is guaranteed even without chain reply mode
because git-send-email will ensure the dates of each email is different
from the previous one.

  Ralf