* [PATCH] MIPS: Kconfig: CMP support needs to select SMP as well
@ 2013-09-06 9:47 Markos Chandras
2013-09-06 9:47 ` Markos Chandras
2013-09-18 11:10 ` Ralf Baechle
0 siblings, 2 replies; 6+ messages in thread
From: Markos Chandras @ 2013-09-06 9:47 UTC (permalink / raw)
To: linux-mips; +Cc: Markos Chandras
The CMP code is only designed to work with SMP configurations.
Fixes multiple build problems on certain randconfigs:
In file included from arch/mips/kernel/smp-cmp.c:34:0:
arch/mips/include/asm/smp.h:28:0:
error: "raw_smp_processor_id" redefined [-Werror]
In file included from include/linux/sched.h:30:0,
from arch/mips/kernel/smp-cmp.c:22:
include/linux/smp.h:135:0: note: this is the location of the
previous definition
In file included from arch/mips/kernel/smp-cmp.c:34:0:
arch/mips/include/asm/smp.h:57:20:
error: redefinition of 'smp_send_reschedule'
In file included from include/linux/sched.h:30:0,
from arch/mips/kernel/smp-cmp.c:22:
include/linux/smp.h:179:20: note: previous
definition of 'smp_send_reschedule' was here
In file included from arch/mips/kernel/smp-cmp.c:34:0:
arch/mips/include/asm/smp.h: In function 'smp_send_reschedule':
arch/mips/include/asm/smp.h:61:8:
error: dereferencing pointer to incomplete type
[...]
Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
---
This patch is for the upstream-sfr/mips-for-linux-next tree
---
arch/mips/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index 04bdd82..6d8082d 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -1985,6 +1985,7 @@ config MIPS_VPE_APSP_API
config MIPS_CMP
bool "MIPS CMP framework support"
depends on SYS_SUPPORTS_MIPS_CMP
+ select SMP
select SYNC_R4K
select SYS_SUPPORTS_SMP
select SYS_SUPPORTS_SCHED_SMT if SMP
--
1.8.3.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] MIPS: Kconfig: CMP support needs to select SMP as well
2013-09-06 9:47 [PATCH] MIPS: Kconfig: CMP support needs to select SMP as well Markos Chandras
@ 2013-09-06 9:47 ` Markos Chandras
2013-09-18 11:10 ` Ralf Baechle
1 sibling, 0 replies; 6+ messages in thread
From: Markos Chandras @ 2013-09-06 9:47 UTC (permalink / raw)
To: linux-mips; +Cc: Markos Chandras
The CMP code is only designed to work with SMP configurations.
Fixes multiple build problems on certain randconfigs:
In file included from arch/mips/kernel/smp-cmp.c:34:0:
arch/mips/include/asm/smp.h:28:0:
error: "raw_smp_processor_id" redefined [-Werror]
In file included from include/linux/sched.h:30:0,
from arch/mips/kernel/smp-cmp.c:22:
include/linux/smp.h:135:0: note: this is the location of the
previous definition
In file included from arch/mips/kernel/smp-cmp.c:34:0:
arch/mips/include/asm/smp.h:57:20:
error: redefinition of 'smp_send_reschedule'
In file included from include/linux/sched.h:30:0,
from arch/mips/kernel/smp-cmp.c:22:
include/linux/smp.h:179:20: note: previous
definition of 'smp_send_reschedule' was here
In file included from arch/mips/kernel/smp-cmp.c:34:0:
arch/mips/include/asm/smp.h: In function 'smp_send_reschedule':
arch/mips/include/asm/smp.h:61:8:
error: dereferencing pointer to incomplete type
[...]
Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
---
This patch is for the upstream-sfr/mips-for-linux-next tree
---
arch/mips/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index 04bdd82..6d8082d 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -1985,6 +1985,7 @@ config MIPS_VPE_APSP_API
config MIPS_CMP
bool "MIPS CMP framework support"
depends on SYS_SUPPORTS_MIPS_CMP
+ select SMP
select SYNC_R4K
select SYS_SUPPORTS_SMP
select SYS_SUPPORTS_SCHED_SMT if SMP
--
1.8.3.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] MIPS: Kconfig: CMP support needs to select SMP as well
2013-09-06 9:47 [PATCH] MIPS: Kconfig: CMP support needs to select SMP as well Markos Chandras
2013-09-06 9:47 ` Markos Chandras
@ 2013-09-18 11:10 ` Ralf Baechle
2013-09-18 11:28 ` Markos Chandras
2013-09-18 11:33 ` Ralf Baechle
1 sibling, 2 replies; 6+ messages in thread
From: Ralf Baechle @ 2013-09-18 11:10 UTC (permalink / raw)
To: Markos Chandras; +Cc: linux-mips
On Fri, Sep 06, 2013 at 10:47:26AM +0100, Markos Chandras wrote:
> The CMP code is only designed to work with SMP configurations.
> Fixes multiple build problems on certain randconfigs:
Applied - but I think the logic here may be backwards from a user's
perspective. Shouldn't a user be asked for SMP first, then for
possible platform suboptions (CMP, VSMP, SMTC) of SMP?
Ralf
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] MIPS: Kconfig: CMP support needs to select SMP as well
2013-09-18 11:10 ` Ralf Baechle
@ 2013-09-18 11:28 ` Markos Chandras
2013-09-18 11:28 ` Markos Chandras
2013-09-18 11:33 ` Ralf Baechle
1 sibling, 1 reply; 6+ messages in thread
From: Markos Chandras @ 2013-09-18 11:28 UTC (permalink / raw)
To: Ralf Baechle; +Cc: linux-mips
On 09/18/13 12:10, Ralf Baechle wrote:
> On Fri, Sep 06, 2013 at 10:47:26AM +0100, Markos Chandras wrote:
>
>> The CMP code is only designed to work with SMP configurations.
>> Fixes multiple build problems on certain randconfigs:
>
> Applied - but I think the logic here may be backwards from a user's
> perspective. Shouldn't a user be asked for SMP first, then for
> possible platform suboptions (CMP, VSMP, SMTC) of SMP?
>
> Ralf
>
Hi Ralf,
Well, for example, you can have VSMP with or without CMP so CMP is not
another SMP option but rather an "add-on". However, it might be
preferred to move the SMP option higher in the menu.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] MIPS: Kconfig: CMP support needs to select SMP as well
2013-09-18 11:28 ` Markos Chandras
@ 2013-09-18 11:28 ` Markos Chandras
0 siblings, 0 replies; 6+ messages in thread
From: Markos Chandras @ 2013-09-18 11:28 UTC (permalink / raw)
To: Ralf Baechle; +Cc: linux-mips
On 09/18/13 12:10, Ralf Baechle wrote:
> On Fri, Sep 06, 2013 at 10:47:26AM +0100, Markos Chandras wrote:
>
>> The CMP code is only designed to work with SMP configurations.
>> Fixes multiple build problems on certain randconfigs:
>
> Applied - but I think the logic here may be backwards from a user's
> perspective. Shouldn't a user be asked for SMP first, then for
> possible platform suboptions (CMP, VSMP, SMTC) of SMP?
>
> Ralf
>
Hi Ralf,
Well, for example, you can have VSMP with or without CMP so CMP is not
another SMP option but rather an "add-on". However, it might be
preferred to move the SMP option higher in the menu.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] MIPS: Kconfig: CMP support needs to select SMP as well
2013-09-18 11:10 ` Ralf Baechle
2013-09-18 11:28 ` Markos Chandras
@ 2013-09-18 11:33 ` Ralf Baechle
1 sibling, 0 replies; 6+ messages in thread
From: Ralf Baechle @ 2013-09-18 11:33 UTC (permalink / raw)
To: Markos Chandras; +Cc: linux-mips
On Wed, Sep 18, 2013 at 01:10:53PM +0200, Ralf Baechle wrote:
> > The CMP code is only designed to work with SMP configurations.
> > Fixes multiple build problems on certain randconfigs:
>
> Applied - but I think the logic here may be backwards from a user's
> perspective. Shouldn't a user be asked for SMP first, then for
> possible platform suboptions (CMP, VSMP, SMTC) of SMP?
Also the "if SMP" in Kconfig
config MIPS_CMP
bool "MIPS CMP framework support"
depends on SYS_SUPPORTS_MIPS_CMP
+ select SMP
select SYNC_R4K
select SYS_SUPPORTS_SMP
select SYS_SUPPORTS_SCHED_SMT if SMP
^^^^^^
now does look a bit silly, doesn't it? I wonder what the original intention
was, possibly CMP support but only a uniprocessor kernel, that is
MIPS_CMP=y would enable the GIC only, something like that?
Ralf
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-09-18 11:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-06 9:47 [PATCH] MIPS: Kconfig: CMP support needs to select SMP as well Markos Chandras
2013-09-06 9:47 ` Markos Chandras
2013-09-18 11:10 ` Ralf Baechle
2013-09-18 11:28 ` Markos Chandras
2013-09-18 11:28 ` Markos Chandras
2013-09-18 11:33 ` Ralf Baechle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox