Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
* Sashiko change proposal
@ 2026-10-15  8:38 David Hildenbrand (Arm)
  2026-10-15  8:46 ` Lorenzo Stoakes (ARM)
                   ` (7 more replies)
  0 siblings, 8 replies; 14+ messages in thread
From: David Hildenbrand (Arm) @ 2026-10-15  8:38 UTC (permalink / raw)
  To: linux-mm@kvack.org
  Cc: Roman Gushchin, ackerleytng, akpm, chriscli, hannes, harry, jack,
	liam, muchun.song, shakeelb, sj, ziy, Lorenzo Stoakes (Arm),
	Mike Rapoport, Vlastimil Babka, Matthew Wilcox, SeongJae Park

(CCing all people attending the mm-next call)

Hi,

After talking to Roman at MS, he just informed me that sashiko now has a new
feature combination:
- "embargo_hours": hours before review is public + emails sent
- Mechanism for signed-in maintainers to lift embargo immediately

That solves the key issue I had with sashiko: people/agents re-spinning stuff
too fast before a human at least had the chance to jump in first.

I suggest the following sashiko change for linux-mm:

diff --git a/projects/linux/mailing_lists.toml b/projects/linux/mailing_lists.toml
index a9198de..ba123da 100644
--- a/projects/linux/mailing_lists.toml
+++ b/projects/linux/mailing_lists.toml
@@ -46,7 +46,6 @@ ignored_emails = ["patchwork@emeril.freedesktop.org"]
 ["linux-integrity@vger.kernel.org"]
 ["linux-kernel@vger.kernel.org"]
 ["linux-kselftest@vger.kernel.org"]
-["linux-mm@kvack.org"]
 ["linux-nvme@lists.infradead.org"]
 ["linux-omap@vger.kernel.org"]
 ["linux-pm@vger.kernel.org"]
@@ -315,3 +314,7 @@ reply_to = ["author", "list", "recipients"]

 ["fsverity@lists.linux.dev"]
 reply_to = ["author", "list", "recipients"]
+
+["linux-mm@kvack.org"]
+reply_to = ["author", "list", "recipients"]
+embargo_hours = 24


Which means:
- Embargo 24h
- Mails sent to everybody (author, list, CC list)
- No positive-review ("looks great") mails (default)
- No other static email addresses that receive a copy (default)
- No additional ignored author email addresses (default)

I'd say we start with 24h and see how it goes.

Thoughts?

-- 
Cheers,

David



^ permalink raw reply related	[flat|nested] 14+ messages in thread

* Re: Sashiko change proposal
  2026-10-15  8:38 Sashiko change proposal David Hildenbrand (Arm)
@ 2026-10-15  8:46 ` Lorenzo Stoakes (ARM)
  2026-10-15  9:28 ` Mike Rapoport
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 14+ messages in thread
From: Lorenzo Stoakes (ARM) @ 2026-10-15  8:46 UTC (permalink / raw)
  To: David Hildenbrand (Arm)
  Cc: linux-mm@kvack.org, Roman Gushchin, ackerleytng, akpm, chriscli,
	hannes, harry, jack, liam, muchun.song, shakeelb, sj, ziy,
	Mike Rapoport, Vlastimil Babka, Matthew Wilcox

On Thu, Oct 15, 2026 at 10:38:14AM +0200, David Hildenbrand (Arm) wrote:
> (CCing all people attending the mm-next call)
>
> Hi,
>
> After talking to Roman at MS, he just informed me that sashiko now has a new
> feature combination:
> - "embargo_hours": hours before review is public + emails sent
> - Mechanism for signed-in maintainers to lift embargo immediately
>
> That solves the key issue I had with sashiko: people/agents re-spinning stuff
> too fast before a human at least had the chance to jump in first.
>
> I suggest the following sashiko change for linux-mm:
>
> diff --git a/projects/linux/mailing_lists.toml b/projects/linux/mailing_lists.toml
> index a9198de..ba123da 100644
> --- a/projects/linux/mailing_lists.toml
> +++ b/projects/linux/mailing_lists.toml
> @@ -46,7 +46,6 @@ ignored_emails = ["patchwork@emeril.freedesktop.org"]
>  ["linux-integrity@vger.kernel.org"]
>  ["linux-kernel@vger.kernel.org"]
>  ["linux-kselftest@vger.kernel.org"]
> -["linux-mm@kvack.org"]
>  ["linux-nvme@lists.infradead.org"]
>  ["linux-omap@vger.kernel.org"]
>  ["linux-pm@vger.kernel.org"]
> @@ -315,3 +314,7 @@ reply_to = ["author", "list", "recipients"]
>
>  ["fsverity@lists.linux.dev"]
>  reply_to = ["author", "list", "recipients"]
> +
> +["linux-mm@kvack.org"]
> +reply_to = ["author", "list", "recipients"]
> +embargo_hours = 24
>
>
> Which means:
> - Embargo 24h
> - Mails sent to everybody (author, list, CC list)
> - No positive-review ("looks great") mails (default)
> - No other static email addresses that receive a copy (default)
> - No additional ignored author email addresses (default)
>
> I'd say we start with 24h and see how it goes.
>
> Thoughts?

Yes, no notes :)

Reviewed-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>

--
Cheers, Lorenzo


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Sashiko change proposal
  2026-10-15  8:38 Sashiko change proposal David Hildenbrand (Arm)
  2026-10-15  8:46 ` Lorenzo Stoakes (ARM)
@ 2026-10-15  9:28 ` Mike Rapoport
  2026-10-15  9:35 ` Vlastimil Babka (SUSE)
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 14+ messages in thread
From: Mike Rapoport @ 2026-10-15  9:28 UTC (permalink / raw)
  To: David Hildenbrand (Arm)
  Cc: linux-mm@kvack.org, Roman Gushchin, ackerleytng, akpm, chriscli,
	hannes, harry, jack, liam, muchun.song, shakeelb, sj, ziy,
	Lorenzo Stoakes (Arm), Vlastimil Babka, Matthew Wilcox

On Thu, Oct 15, 2026 at 10:38:14AM +0200, David Hildenbrand (Arm) wrote:
> (CCing all people attending the mm-next call)
> 
> Hi,
> 
> After talking to Roman at MS, he just informed me that sashiko now has a new
> feature combination:
> - "embargo_hours": hours before review is public + emails sent
> - Mechanism for signed-in maintainers to lift embargo immediately
> 
> That solves the key issue I had with sashiko: people/agents re-spinning stuff
> too fast before a human at least had the chance to jump in first.
> 
> I suggest the following sashiko change for linux-mm:
> 
> diff --git a/projects/linux/mailing_lists.toml b/projects/linux/mailing_lists.toml
> index a9198de..ba123da 100644
> --- a/projects/linux/mailing_lists.toml
> +++ b/projects/linux/mailing_lists.toml
> @@ -46,7 +46,6 @@ ignored_emails = ["patchwork@emeril.freedesktop.org"]
>  ["linux-integrity@vger.kernel.org"]
>  ["linux-kernel@vger.kernel.org"]
>  ["linux-kselftest@vger.kernel.org"]
> -["linux-mm@kvack.org"]
>  ["linux-nvme@lists.infradead.org"]
>  ["linux-omap@vger.kernel.org"]
>  ["linux-pm@vger.kernel.org"]
> @@ -315,3 +314,7 @@ reply_to = ["author", "list", "recipients"]
> 
>  ["fsverity@lists.linux.dev"]
>  reply_to = ["author", "list", "recipients"]
> +
> +["linux-mm@kvack.org"]
> +reply_to = ["author", "list", "recipients"]
> +embargo_hours = 24
> 
> 
> Which means:
> - Embargo 24h
> - Mails sent to everybody (author, list, CC list)
> - No positive-review ("looks great") mails (default)
> - No other static email addresses that receive a copy (default)
> - No additional ignored author email addresses (default)
> 
> I'd say we start with 24h and see how it goes.

Sounds good!
 
> Thoughts?
> 
> -- 
> Cheers,
> 
> David
> 

-- 
Sincerely yours,
Mike.


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Sashiko change proposal
  2026-10-15  8:38 Sashiko change proposal David Hildenbrand (Arm)
  2026-10-15  8:46 ` Lorenzo Stoakes (ARM)
  2026-10-15  9:28 ` Mike Rapoport
@ 2026-10-15  9:35 ` Vlastimil Babka (SUSE)
  2026-10-15 11:23 ` Pratyush Yadav
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 14+ messages in thread
From: Vlastimil Babka (SUSE) @ 2026-10-15  9:35 UTC (permalink / raw)
  To: David Hildenbrand (Arm), linux-mm@kvack.org
  Cc: Roman Gushchin, ackerleytng, akpm, chriscli, hannes, harry, jack,
	liam, muchun.song, shakeelb, sj, ziy, Lorenzo Stoakes (Arm),
	Mike Rapoport, Matthew Wilcox

On 10/15/26 10:38, David Hildenbrand (Arm) wrote:
> (CCing all people attending the mm-next call)
> 
> Hi,
> 
> After talking to Roman at MS, he just informed me that sashiko now has a new
> feature combination:
> - "embargo_hours": hours before review is public + emails sent
> - Mechanism for signed-in maintainers to lift embargo immediately
> 
> That solves the key issue I had with sashiko: people/agents re-spinning stuff
> too fast before a human at least had the chance to jump in first.
> 
> I suggest the following sashiko change for linux-mm:
> 
> diff --git a/projects/linux/mailing_lists.toml b/projects/linux/mailing_lists.toml
> index a9198de..ba123da 100644
> --- a/projects/linux/mailing_lists.toml
> +++ b/projects/linux/mailing_lists.toml
> @@ -46,7 +46,6 @@ ignored_emails = ["patchwork@emeril.freedesktop.org"]
>  ["linux-integrity@vger.kernel.org"]
>  ["linux-kernel@vger.kernel.org"]
>  ["linux-kselftest@vger.kernel.org"]
> -["linux-mm@kvack.org"]
>  ["linux-nvme@lists.infradead.org"]
>  ["linux-omap@vger.kernel.org"]
>  ["linux-pm@vger.kernel.org"]
> @@ -315,3 +314,7 @@ reply_to = ["author", "list", "recipients"]
> 
>  ["fsverity@lists.linux.dev"]
>  reply_to = ["author", "list", "recipients"]
> +
> +["linux-mm@kvack.org"]
> +reply_to = ["author", "list", "recipients"]
> +embargo_hours = 24
> 
> 
> Which means:
> - Embargo 24h
> - Mails sent to everybody (author, list, CC list)
> - No positive-review ("looks great") mails (default)
> - No other static email addresses that receive a copy (default)
> - No additional ignored author email addresses (default)
> 
> I'd say we start with 24h and see how it goes.
> 
> Thoughts?

LGTM!



^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Sashiko change proposal
  2026-10-15  8:38 Sashiko change proposal David Hildenbrand (Arm)
                   ` (2 preceding siblings ...)
  2026-10-15  9:35 ` Vlastimil Babka (SUSE)
@ 2026-10-15 11:23 ` Pratyush Yadav
  2026-10-15 11:27   ` David Hildenbrand (Arm)
  2026-10-15 12:07 ` Harry Yoo
                   ` (3 subsequent siblings)
  7 siblings, 1 reply; 14+ messages in thread
From: Pratyush Yadav @ 2026-10-15 11:23 UTC (permalink / raw)
  To: David Hildenbrand (Arm)
  Cc: linux-mm@kvack.org, Roman Gushchin, ackerleytng, akpm, chriscli,
	hannes, harry, jack, liam, muchun.song, shakeelb, sj, ziy,
	Lorenzo Stoakes (Arm), Mike Rapoport, Vlastimil Babka,
	Matthew Wilcox

On Thu, Oct 15 2026, David Hildenbrand (Arm) wrote:

> (CCing all people attending the mm-next call)
>
> Hi,
>
> After talking to Roman at MS, he just informed me that sashiko now has a new
> feature combination:
> - "embargo_hours": hours before review is public + emails sent
> - Mechanism for signed-in maintainers to lift embargo immediately
>
> That solves the key issue I had with sashiko: people/agents re-spinning stuff
> too fast before a human at least had the chance to jump in first.

If a sender re-spins stuff too fast after a Sashiko review, that's a
pretty clear signal that it is an agent. For me, that makes it an easy
decision to ignore the sender. I'm curious, why would you want to lose
that signal? Is the goal to preserve Sashiko bandwidth and reduce
mailing list spam?

>
> I suggest the following sashiko change for linux-mm:
>
> diff --git a/projects/linux/mailing_lists.toml b/projects/linux/mailing_lists.toml
> index a9198de..ba123da 100644
> --- a/projects/linux/mailing_lists.toml
> +++ b/projects/linux/mailing_lists.toml
> @@ -46,7 +46,6 @@ ignored_emails = ["patchwork@emeril.freedesktop.org"]
>  ["linux-integrity@vger.kernel.org"]
>  ["linux-kernel@vger.kernel.org"]
>  ["linux-kselftest@vger.kernel.org"]
> -["linux-mm@kvack.org"]
>  ["linux-nvme@lists.infradead.org"]
>  ["linux-omap@vger.kernel.org"]
>  ["linux-pm@vger.kernel.org"]
> @@ -315,3 +314,7 @@ reply_to = ["author", "list", "recipients"]
>
>  ["fsverity@lists.linux.dev"]
>  reply_to = ["author", "list", "recipients"]
> +
> +["linux-mm@kvack.org"]
> +reply_to = ["author", "list", "recipients"]
> +embargo_hours = 24
>
>
> Which means:
> - Embargo 24h
> - Mails sent to everybody (author, list, CC list)
> - No positive-review ("looks great") mails (default)
> - No other static email addresses that receive a copy (default)
> - No additional ignored author email addresses (default)
>
> I'd say we start with 24h and see how it goes.
>
> Thoughts?

-- 
Regards,
Pratyush Yadav


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Sashiko change proposal
  2026-10-15 11:23 ` Pratyush Yadav
@ 2026-10-15 11:27   ` David Hildenbrand (Arm)
  0 siblings, 0 replies; 14+ messages in thread
From: David Hildenbrand (Arm) @ 2026-10-15 11:27 UTC (permalink / raw)
  To: Pratyush Yadav
  Cc: linux-mm@kvack.org, Roman Gushchin, ackerleytng, akpm, chriscli,
	hannes, harry, jack, liam, muchun.song, shakeelb, sj, ziy,
	Lorenzo Stoakes (Arm), Mike Rapoport, Vlastimil Babka,
	Matthew Wilcox

On 10/15/26 13:23, Pratyush Yadav wrote:
> On Thu, Oct 15 2026, David Hildenbrand (Arm) wrote:
> 
>> (CCing all people attending the mm-next call)
>>
>> Hi,
>>
>> After talking to Roman at MS, he just informed me that sashiko now has a new
>> feature combination:
>> - "embargo_hours": hours before review is public + emails sent
>> - Mechanism for signed-in maintainers to lift embargo immediately
>>
>> That solves the key issue I had with sashiko: people/agents re-spinning stuff
>> too fast before a human at least had the chance to jump in first.
> 
> If a sender re-spins stuff too fast after a Sashiko review, that's a
> pretty clear signal that it is an agent. 

And I know for sure that that's not always the case.

-- 
Cheers,

David


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Sashiko change proposal
  2026-10-15  8:38 Sashiko change proposal David Hildenbrand (Arm)
                   ` (3 preceding siblings ...)
  2026-10-15 11:23 ` Pratyush Yadav
@ 2026-10-15 12:07 ` Harry Yoo
  2026-10-15 12:15   ` Roman Gushchin
  2026-10-15 14:47 ` Zi Yan
                   ` (2 subsequent siblings)
  7 siblings, 1 reply; 14+ messages in thread
From: Harry Yoo @ 2026-10-15 12:07 UTC (permalink / raw)
  To: David Hildenbrand (Arm)
  Cc: linux-mm@kvack.org, Roman Gushchin, ackerleytng, akpm, chriscli,
	hannes, jack, liam, muchun.song, shakeelb, sj, ziy,
	Lorenzo Stoakes (Arm), Mike Rapoport, Vlastimil Babka,
	Matthew Wilcox

On Thu, Oct 15, 2026 at 10:38:14AM +0200, David Hildenbrand (Arm) wrote:
> (CCing all people attending the mm-next call)
> 
> Hi,
> 
> After talking to Roman at MS, he just informed me that sashiko now has a new
> feature combination:
> - "embargo_hours": hours before review is public + emails sent
> - Mechanism for signed-in maintainers to lift embargo immediately
>
> That solves the key issue I had with sashiko: people/agents re-spinning stuff
> too fast before a human at least had the chance to jump in first.
> 
> I suggest the following sashiko change for linux-mm:
> 
> diff --git a/projects/linux/mailing_lists.toml b/projects/linux/mailing_lists.toml
> index a9198de..ba123da 100644
> --- a/projects/linux/mailing_lists.toml
> +++ b/projects/linux/mailing_lists.toml
> @@ -46,7 +46,6 @@ ignored_emails = ["patchwork@emeril.freedesktop.org"]
>  ["linux-integrity@vger.kernel.org"]
>  ["linux-kernel@vger.kernel.org"]
>  ["linux-kselftest@vger.kernel.org"]
> -["linux-mm@kvack.org"]
>  ["linux-nvme@lists.infradead.org"]
>  ["linux-omap@vger.kernel.org"]
>  ["linux-pm@vger.kernel.org"]
> @@ -315,3 +314,7 @@ reply_to = ["author", "list", "recipients"]
> 
>  ["fsverity@lists.linux.dev"]
>  reply_to = ["author", "list", "recipients"]
> +
> +["linux-mm@kvack.org"]
> +reply_to = ["author", "list", "recipients"]
> +embargo_hours = 24
> 
> 
> Which means:
> - Embargo 24h
> - Mails sent to everybody (author, list, CC list)
> - No positive-review ("looks great") mails (default)
> - No other static email addresses that receive a copy (default)
> - No additional ignored author email addresses (default)
> 
> I'd say we start with 24h and see how it goes.
> 
> Thoughts?

Acked-by: Harry Yoo (Meta) <harry@kernel.org>

Quick question: when are maintainers supposed to lift embargo?

-- 
Cheers,
Harry / Hyeonggon


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Sashiko change proposal
  2026-10-15 12:07 ` Harry Yoo
@ 2026-10-15 12:15   ` Roman Gushchin
  2026-10-15 14:46     ` SJ Park
  0 siblings, 1 reply; 14+ messages in thread
From: Roman Gushchin @ 2026-10-15 12:15 UTC (permalink / raw)
  To: Harry Yoo
  Cc: David Hildenbrand, linux-mm, ackerleytng, akpm, chriscli, hannes,
	jack, liam, muchun.song, shakeelb, sj, ziy, Lorenzo Stoakes,
	Mike Rapoport, Vlastimil Babka, Matthew Wilcox

> On Oct 15, 2026, at 5:08 AM, Harry Yoo <harry@kernel.org> wrote:
> 
> On Thu, Oct 15, 2026 at 10:38:14AM +0200, David Hildenbrand (Arm) wrote:
>> (CCing all people attending the mm-next call)
>> 
>> Hi,
>> 
>> After talking to Roman at MS, he just informed me that sashiko now has a new
>> feature combination:
>> - "embargo_hours": hours before review is public + emails sent
>> - Mechanism for signed-in maintainers to lift embargo immediately
>> 
>> That solves the key issue I had with sashiko: people/agents re-spinning stuff
>> too fast before a human at least had the chance to jump in first.
>> 
>> I suggest the following sashiko change for linux-mm:
>> 
>> diff --git a/projects/linux/mailing_lists.toml b/projects/linux/mailing_lists.toml
>> index a9198de..ba123da 100644
>> --- a/projects/linux/mailing_lists.toml
>> +++ b/projects/linux/mailing_lists.toml
>> @@ -46,7 +46,6 @@ ignored_emails = ["patchwork@emeril.freedesktop.org"]
>> ["linux-integrity@vger.kernel.org"]
>> ["linux-kernel@vger.kernel.org"]
>> ["linux-kselftest@vger.kernel.org"]
>> -["linux-mm@kvack.org"]
>> ["linux-nvme@lists.infradead.org"]
>> ["linux-omap@vger.kernel.org"]
>> ["linux-pm@vger.kernel.org"]
>> @@ -315,3 +314,7 @@ reply_to = ["author", "list", "recipients"]
>> 
>> ["fsverity@lists.linux.dev"]
>> reply_to = ["author", "list", "recipients"]
>> +
>> +["linux-mm@kvack.org"]
>> +reply_to = ["author", "list", "recipients"]
>> +embargo_hours = 24
>> 
>> 
>> Which means:
>> - Embargo 24h
>> - Mails sent to everybody (author, list, CC list)
>> - No positive-review ("looks great") mails (default)
>> - No other static email addresses that receive a copy (default)
>> - No additional ignored author email addresses (default)
>> 
>> I'd say we start with 24h and see how it goes.
>> 
>> Thoughts?
> 
> Acked-by: Harry Yoo (Meta) <harry@kernel.org>
> 
> Quick question: when are maintainers supposed to lift embargo?

They don’t have to: it will be lifted automatically after 24h (or whatever is configured).
But if you as a maintainer has an immediate comment to Sashiko’s review or you’re ready to pick the change, you can lift it immediately.
And of course maintainers can see review results immediately.


Thanks

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Sashiko change proposal
  2026-10-15 12:15   ` Roman Gushchin
@ 2026-10-15 14:46     ` SJ Park
  0 siblings, 0 replies; 14+ messages in thread
From: SJ Park @ 2026-10-15 14:46 UTC (permalink / raw)
  To: Roman Gushchin
  Cc: SJ Park, Harry Yoo, David Hildenbrand, linux-mm, ackerleytng,
	akpm, chriscli, hannes, jack, liam, muchun.song, shakeelb, ziy,
	Lorenzo Stoakes, Mike Rapoport, Vlastimil Babka, Matthew Wilcox

On Thu, 15 Oct 2026 05:15:05 -0700 Roman Gushchin <roman.gushchin@linux.dev> wrote:

> > On Oct 15, 2026, at 5:08 AM, Harry Yoo <harry@kernel.org> wrote:
[...]
> > Quick question: when are maintainers supposed to lift embargo?
> 
> They don’t have to: it will be lifted automatically after 24h (or whatever is configured).
> But if you as a maintainer has an immediate comment to Sashiko’s review or you’re ready to pick the change, you can lift it immediately.
> And of course maintainers can see review results immediately.

The maintainer feature sounds cool.  I was wondering how I could do this in
detail.  This "What's New in Sashiko" [1] is kindly explaining it.

: Maintainer embargo access & early embargo release
: Signed-in maintainers can view embargoed reviews immediately without waiting
: for the timer, and use the new "Release Embargo" button on a patchset page to
: publish results early.

By the way the "What's New in Sashiko" is very helpful new feature.  I will
visit Sashiko web ui more frequently.  Thank you Roman and Sashiko team for the
great works!

[1] https://github.com/sashiko-dev/sashiko/blob/main/static/index.html#L1894


Thanks,
SJ

[...]


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Sashiko change proposal
  2026-10-15  8:38 Sashiko change proposal David Hildenbrand (Arm)
                   ` (4 preceding siblings ...)
  2026-10-15 12:07 ` Harry Yoo
@ 2026-10-15 14:47 ` Zi Yan
  2026-10-15 14:51 ` SJ Park
  2026-10-15 22:38 ` Yosry Ahmed
  7 siblings, 0 replies; 14+ messages in thread
From: Zi Yan @ 2026-10-15 14:47 UTC (permalink / raw)
  To: David Hildenbrand (Arm)
  Cc: linux-mm, Roman Gushchin, ackerleytng, akpm, chriscli, hannes,
	harry, jack, liam, muchun.song, shakeelb, sj,
	Lorenzo Stoakes (Arm), Mike Rapoport, Vlastimil Babka,
	Matthew Wilcox

On 15 Oct 2026, at 4:38, David Hildenbrand (Arm) wrote:

> (CCing all people attending the mm-next call)
>
> Hi,
>
> After talking to Roman at MS, he just informed me that sashiko now has a new
> feature combination:
> - "embargo_hours": hours before review is public + emails sent
> - Mechanism for signed-in maintainers to lift embargo immediately
>
> That solves the key issue I had with sashiko: people/agents re-spinning stuff
> too fast before a human at least had the chance to jump in first.
>
> I suggest the following sashiko change for linux-mm:
>
> diff --git a/projects/linux/mailing_lists.toml b/projects/linux/mailing_lists.toml
> index a9198de..ba123da 100644
> --- a/projects/linux/mailing_lists.toml
> +++ b/projects/linux/mailing_lists.toml
> @@ -46,7 +46,6 @@ ignored_emails = ["patchwork@emeril.freedesktop.org"]
>  ["linux-integrity@vger.kernel.org"]
>  ["linux-kernel@vger.kernel.org"]
>  ["linux-kselftest@vger.kernel.org"]
> -["linux-mm@kvack.org"]
>  ["linux-nvme@lists.infradead.org"]
>  ["linux-omap@vger.kernel.org"]
>  ["linux-pm@vger.kernel.org"]
> @@ -315,3 +314,7 @@ reply_to = ["author", "list", "recipients"]
>
>  ["fsverity@lists.linux.dev"]
>  reply_to = ["author", "list", "recipients"]
> +
> +["linux-mm@kvack.org"]
> +reply_to = ["author", "list", "recipients"]
> +embargo_hours = 24
>
>
> Which means:
> - Embargo 24h
> - Mails sent to everybody (author, list, CC list)
> - No positive-review ("looks great") mails (default)
> - No other static email addresses that receive a copy (default)
> - No additional ignored author email addresses (default)
>
> I'd say we start with 24h and see how it goes.
>
> Thoughts?

Sounds good to me.

Best Regards,
Yan, Zi


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Sashiko change proposal
  2026-10-15  8:38 Sashiko change proposal David Hildenbrand (Arm)
                   ` (5 preceding siblings ...)
  2026-10-15 14:47 ` Zi Yan
@ 2026-10-15 14:51 ` SJ Park
  2026-10-15 22:38 ` Yosry Ahmed
  7 siblings, 0 replies; 14+ messages in thread
From: SJ Park @ 2026-10-15 14:51 UTC (permalink / raw)
  To: David Hildenbrand (Arm)
  Cc: SJ Park, linux-mm@kvack.org, Roman Gushchin, ackerleytng, akpm,
	chriscli, hannes, harry, jack, liam, muchun.song, shakeelb, ziy,
	Lorenzo Stoakes (Arm), Mike Rapoport, Vlastimil Babka,
	Matthew Wilcox

On Thu, 15 Oct 2026 10:38:14 +0200 "David Hildenbrand (Arm)" <david@kernel.org> wrote:

> (CCing all people attending the mm-next call)
> 
> Hi,
> 
> After talking to Roman at MS, he just informed me that sashiko now has a new
> feature combination:
> - "embargo_hours": hours before review is public + emails sent
> - Mechanism for signed-in maintainers to lift embargo immediately

Kudos to Roman and Sashiko team for developing the features.

> 
> That solves the key issue I had with sashiko: people/agents re-spinning stuff
> too fast before a human at least had the chance to jump in first.
> 
> I suggest the following sashiko change for linux-mm:
[...]
> Which means:
> - Embargo 24h
> - Mails sent to everybody (author, list, CC list)
> - No positive-review ("looks great") mails (default)
> - No other static email addresses that receive a copy (default)
> - No additional ignored author email addresses (default)
> 
> I'd say we start with 24h and see how it goes.
> 
> Thoughts?

Sounds good to me.  Thank you for suggesting this, David.

Acked-by: SJ Park <sj@kernel.org>


Thanks,
SJ

[...]


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Sashiko change proposal
  2026-10-15  8:38 Sashiko change proposal David Hildenbrand (Arm)
                   ` (6 preceding siblings ...)
  2026-10-15 14:51 ` SJ Park
@ 2026-10-15 22:38 ` Yosry Ahmed
  2026-10-16  0:15   ` Roman Gushchin
  7 siblings, 1 reply; 14+ messages in thread
From: Yosry Ahmed @ 2026-10-15 22:38 UTC (permalink / raw)
  To: David Hildenbrand (Arm)
  Cc: linux-mm@kvack.org, Roman Gushchin, ackerleytng, akpm, chriscli,
	hannes, harry, jack, liam, muchun.song, shakeelb, ziy,
	Lorenzo Stoakes (Arm), Mike Rapoport, Vlastimil Babka,
	Matthew Wilcox, SeongJae Park

On Thu, Oct 15, 2026 at 1:38 AM David Hildenbrand (Arm)
<david@kernel.org> wrote:
>
> (CCing all people attending the mm-next call)
>
> Hi,
>
> After talking to Roman at MS, he just informed me that sashiko now has a new
> feature combination:
> - "embargo_hours": hours before review is public + emails sent
> - Mechanism for signed-in maintainers to lift embargo immediately
>
> That solves the key issue I had with sashiko: people/agents re-spinning stuff
> too fast before a human at least had the chance to jump in first.
>
> I suggest the following sashiko change for linux-mm:
>
> diff --git a/projects/linux/mailing_lists.toml b/projects/linux/mailing_lists.toml
> index a9198de..ba123da 100644
> --- a/projects/linux/mailing_lists.toml
> +++ b/projects/linux/mailing_lists.toml
> @@ -46,7 +46,6 @@ ignored_emails = ["patchwork@emeril.freedesktop.org"]
>  ["linux-integrity@vger.kernel.org"]
>  ["linux-kernel@vger.kernel.org"]
>  ["linux-kselftest@vger.kernel.org"]
> -["linux-mm@kvack.org"]
>  ["linux-nvme@lists.infradead.org"]
>  ["linux-omap@vger.kernel.org"]
>  ["linux-pm@vger.kernel.org"]
> @@ -315,3 +314,7 @@ reply_to = ["author", "list", "recipients"]
>
>  ["fsverity@lists.linux.dev"]
>  reply_to = ["author", "list", "recipients"]
> +
> +["linux-mm@kvack.org"]
> +reply_to = ["author", "list", "recipients"]
> +embargo_hours = 24
>
>
> Which means:
> - Embargo 24h
> - Mails sent to everybody (author, list, CC list)
> - No positive-review ("looks great") mails (default)
> - No other static email addresses that receive a copy (default)
> - No additional ignored author email addresses (default)
>
> I'd say we start with 24h and see how it goes.
>
> Thoughts?

Thanks for doing this, it's much more convenient to notice and respond
to the review when Sashiko replies to the patches.

FWIW, I prefer no 24hr embargo, seems to work well on the KVM side --
but I will take what I can get :P

Reviewed-by: Yosry Ahmed <yosry@kernel.org>


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Sashiko change proposal
  2026-10-15 22:38 ` Yosry Ahmed
@ 2026-10-16  0:15   ` Roman Gushchin
  2026-10-16  7:56     ` David Hildenbrand (Arm)
  0 siblings, 1 reply; 14+ messages in thread
From: Roman Gushchin @ 2026-10-16  0:15 UTC (permalink / raw)
  To: Yosry Ahmed
  Cc: David Hildenbrand (Arm), linux-mm@kvack.org, ackerleytng, akpm,
	chriscli, hannes, harry, jack, liam, muchun.song, shakeelb, ziy,
	Lorenzo Stoakes (Arm), Mike Rapoport, Vlastimil Babka,
	Matthew Wilcox, SeongJae Park

Yosry Ahmed <yosry@kernel.org> writes:

> On Thu, Oct 15, 2026 at 1:38 AM David Hildenbrand (Arm)
> <david@kernel.org> wrote:
>>
>> (CCing all people attending the mm-next call)
>>
>> Hi,
>>
>> After talking to Roman at MS, he just informed me that sashiko now has a new
>> feature combination:
>> - "embargo_hours": hours before review is public + emails sent
>> - Mechanism for signed-in maintainers to lift embargo immediately
>>
>> That solves the key issue I had with sashiko: people/agents re-spinning stuff
>> too fast before a human at least had the chance to jump in first.
>>
>> I suggest the following sashiko change for linux-mm:
>>
>> diff --git a/projects/linux/mailing_lists.toml b/projects/linux/mailing_lists.toml
>> index a9198de..ba123da 100644
>> --- a/projects/linux/mailing_lists.toml
>> +++ b/projects/linux/mailing_lists.toml
>> @@ -46,7 +46,6 @@ ignored_emails = ["patchwork@emeril.freedesktop.org"]
>>  ["linux-integrity@vger.kernel.org"]
>>  ["linux-kernel@vger.kernel.org"]
>>  ["linux-kselftest@vger.kernel.org"]
>> -["linux-mm@kvack.org"]
>>  ["linux-nvme@lists.infradead.org"]
>>  ["linux-omap@vger.kernel.org"]
>>  ["linux-pm@vger.kernel.org"]
>> @@ -315,3 +314,7 @@ reply_to = ["author", "list", "recipients"]
>>
>>  ["fsverity@lists.linux.dev"]
>>  reply_to = ["author", "list", "recipients"]
>> +
>> +["linux-mm@kvack.org"]
>> +reply_to = ["author", "list", "recipients"]
>> +embargo_hours = 24
>>
>>
>> Which means:
>> - Embargo 24h
>> - Mails sent to everybody (author, list, CC list)
>> - No positive-review ("looks great") mails (default)
>> - No other static email addresses that receive a copy (default)
>> - No additional ignored author email addresses (default)
>>
>> I'd say we start with 24h and see how it goes.
>>
>> Thoughts?
>
> Thanks for doing this, it's much more convenient to notice and respond
> to the review when Sashiko replies to the patches.
>
> FWIW, I prefer no 24hr embargo, seems to work well on the KVM side --
> but I will take what I can get :P
>
> Reviewed-by: Yosry Ahmed <yosry@kernel.org>

Is it time for me to pick up the change? David, I'll let you decide when
the discussion is done or just send me a PR, up to you.

Btw I hope to deploy the new Gemini 4 Argon model really soon and I
expect better review quality. Also a big prompts rework is in the
process with a simpler way to put in subjective things. It will be
called maintainers notes. For stuff like "don't send me typo fixes
patches" or "don't use struct page outside of X".

Thanks


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: Sashiko change proposal
  2026-10-16  0:15   ` Roman Gushchin
@ 2026-10-16  7:56     ` David Hildenbrand (Arm)
  0 siblings, 0 replies; 14+ messages in thread
From: David Hildenbrand (Arm) @ 2026-10-16  7:56 UTC (permalink / raw)
  To: Roman Gushchin, Yosry Ahmed
  Cc: linux-mm@kvack.org, ackerleytng, akpm, chriscli, hannes, harry,
	jack, liam, muchun.song, shakeelb, ziy, Lorenzo Stoakes (Arm),
	Mike Rapoport, Vlastimil Babka, Matthew Wilcox, SeongJae Park

On 10/16/26 02:15, Roman Gushchin wrote:
> Yosry Ahmed <yosry@kernel.org> writes:
> 
>> On Thu, Oct 15, 2026 at 1:38 AM David Hildenbrand (Arm)
>> <david@kernel.org> wrote:
>>>
>>> (CCing all people attending the mm-next call)
>>>
>>> Hi,
>>>
>>> After talking to Roman at MS, he just informed me that sashiko now has a new
>>> feature combination:
>>> - "embargo_hours": hours before review is public + emails sent
>>> - Mechanism for signed-in maintainers to lift embargo immediately
>>>
>>> That solves the key issue I had with sashiko: people/agents re-spinning stuff
>>> too fast before a human at least had the chance to jump in first.
>>>
>>> I suggest the following sashiko change for linux-mm:
>>>
>>> diff --git a/projects/linux/mailing_lists.toml b/projects/linux/mailing_lists.toml
>>> index a9198de..ba123da 100644
>>> --- a/projects/linux/mailing_lists.toml
>>> +++ b/projects/linux/mailing_lists.toml
>>> @@ -46,7 +46,6 @@ ignored_emails = ["patchwork@emeril.freedesktop.org"]
>>>  ["linux-integrity@vger.kernel.org"]
>>>  ["linux-kernel@vger.kernel.org"]
>>>  ["linux-kselftest@vger.kernel.org"]
>>> -["linux-mm@kvack.org"]
>>>  ["linux-nvme@lists.infradead.org"]
>>>  ["linux-omap@vger.kernel.org"]
>>>  ["linux-pm@vger.kernel.org"]
>>> @@ -315,3 +314,7 @@ reply_to = ["author", "list", "recipients"]
>>>
>>>  ["fsverity@lists.linux.dev"]
>>>  reply_to = ["author", "list", "recipients"]
>>> +
>>> +["linux-mm@kvack.org"]
>>> +reply_to = ["author", "list", "recipients"]
>>> +embargo_hours = 24
>>>
>>>
>>> Which means:
>>> - Embargo 24h
>>> - Mails sent to everybody (author, list, CC list)
>>> - No positive-review ("looks great") mails (default)
>>> - No other static email addresses that receive a copy (default)
>>> - No additional ignored author email addresses (default)
>>>
>>> I'd say we start with 24h and see how it goes.
>>>
>>> Thoughts?
>>
>> Thanks for doing this, it's much more convenient to notice and respond
>> to the review when Sashiko replies to the patches.
>>
>> FWIW, I prefer no 24hr embargo, seems to work well on the KVM side --
>> but I will take what I can get :P
>>
>> Reviewed-by: Yosry Ahmed <yosry@kernel.org>
> 
> Is it time for me to pick up the change? David, I'll let you decide when
> the discussion is done or just send me a PR, up to you.

I was under the assumption that I would have to open a PR on github, but if you
could just perform the change yourself, that would be great.

I don't think there is any pushback right now, and we can always adjust if we
realize this doesn't work the way we wanted to.

-- 
Cheers,

David


^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2026-10-16  7:56 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-15  8:38 Sashiko change proposal David Hildenbrand (Arm)
2026-10-15  8:46 ` Lorenzo Stoakes (ARM)
2026-10-15  9:28 ` Mike Rapoport
2026-10-15  9:35 ` Vlastimil Babka (SUSE)
2026-10-15 11:23 ` Pratyush Yadav
2026-10-15 11:27   ` David Hildenbrand (Arm)
2026-10-15 12:07 ` Harry Yoo
2026-10-15 12:15   ` Roman Gushchin
2026-10-15 14:46     ` SJ Park
2026-10-15 14:47 ` Zi Yan
2026-10-15 14:51 ` SJ Park
2026-10-15 22:38 ` Yosry Ahmed
2026-10-16  0:15   ` Roman Gushchin
2026-10-16  7:56     ` David Hildenbrand (Arm)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox