* [PATCH] ARM: OMAP AM35x: clockdomain data: fix resolving dependency problem
@ 2012-07-02 5:54 Kim, Milo
2012-07-02 17:41 ` Mark A. Greer
0 siblings, 1 reply; 4+ messages in thread
From: Kim, Milo @ 2012-07-02 5:54 UTC (permalink / raw)
To: tony@atomide.com
Cc: linux-omap@vger.kernel.org, mgreer@animalcreek.com,
paul@pwsan.com, linux-kernel@vger.kernel.org
In am35x board , iva2 clock domain doesn't be used.
So mpu_am35x_clkdm should be used rather than mpu_3xxx_clkdm.
OMAP3430 : mpu_3xxx_clkdm (with iva2 clkdm)
AM35x : mpu_am35x_clkdm (without iva2 clkdm)
For the compatibility with omap3430, this patch has no conflict because mpu_3xxx_clkdm was already defined in clock domains for omap3430.
So this can be removed from common clock domain.
Below error can be fixed with this patch.
[ 0.000000] AM3517 ES1.1 (l2cache sgx neon )
[ 0.000000] ------------[ cut here ]------------
[ 0.000000] WARNING: at arch/arm/mach-omap2/clockdomain.c:237 _resolve_clkdm_deps+0x68/0x108()
[ 0.000000] clockdomain: mpu_clkdm: could not find clkdm iva2_clkdm while resolving dependencies - should never happen
[ 0.000000] Modules linked in:
[ 0.000000] [<c001bd3c>] (unwind_backtrace+0x0/0xf4) from [<c0040c2c>] (warn_slowpath_common+0x4c/0x64)
[ 0.000000] [<c0040c2c>] (warn_slowpath_common+0x4c/0x64) from [<c0040cd8>] (warn_slowpath_fmt+0x30/0x40)
[ 0.000000] [<c0040cd8>] (warn_slowpath_fmt+0x30/0x40) from [<c003256c>] (_resolve_clkdm_deps+0x68/0x108)
[ 0.000000] [<c003256c>] (_resolve_clkdm_deps+0x68/0x108) from [<c0032640>] (clkdm_complete_init+0x34/0x90)
[ 0.000000] [<c0032640>] (clkdm_complete_init+0x34/0x90) from [<c06d7600>] (omap3_init_early+0x20/0x30)
[ 0.000000] [<c06d7600>] (omap3_init_early+0x20/0x30) from [<c06d3230>] (setup_arch+0x834/0x94c)
[ 0.000000] [<c06d3230>] (setup_arch+0x834/0x94c) from [<c06cf6b0>] (start_kernel+0x88/0x2fc)
[ 0.000000] [<c06cf6b0>] (start_kernel+0x88/0x2fc) from [<80008044>] (0x80008044)
Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
---
arch/arm/mach-omap2/clockdomains3xxx_data.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/clockdomains3xxx_data.c b/arch/arm/mach-omap2/clockdomains3xxx_data.c
index d625844..56089c4 100644
--- a/arch/arm/mach-omap2/clockdomains3xxx_data.c
+++ b/arch/arm/mach-omap2/clockdomains3xxx_data.c
@@ -454,7 +454,6 @@ static struct clkdm_autodep clkdm_am35x_autodeps[] = {
static struct clockdomain *clockdomains_common[] __initdata = {
&wkup_common_clkdm,
- &mpu_3xxx_clkdm,
&neon_clkdm,
&core_l3_3xxx_clkdm,
&core_l4_3xxx_clkdm,
--
1.7.2.5
Thanks & BR
Milo -
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: OMAP AM35x: clockdomain data: fix resolving dependency problem
2012-07-02 5:54 [PATCH] ARM: OMAP AM35x: clockdomain data: fix resolving dependency problem Kim, Milo
@ 2012-07-02 17:41 ` Mark A. Greer
2012-07-07 12:41 ` Ladislav Michl
0 siblings, 1 reply; 4+ messages in thread
From: Mark A. Greer @ 2012-07-02 17:41 UTC (permalink / raw)
To: Kim, Milo
Cc: tony@atomide.com, linux-omap@vger.kernel.org, paul@pwsan.com,
linux-kernel@vger.kernel.org
On Mon, Jul 02, 2012 at 05:54:57AM +0000, Kim, Milo wrote:
> In am35x board , iva2 clock domain doesn't be used.
> So mpu_am35x_clkdm should be used rather than mpu_3xxx_clkdm.
> OMAP3430 : mpu_3xxx_clkdm (with iva2 clkdm)
> AM35x : mpu_am35x_clkdm (without iva2 clkdm)
>
> For the compatibility with omap3430, this patch has no conflict because mpu_3xxx_clkdm was already defined in clock domains for omap3430.
> So this can be removed from common clock domain.
>
> Below error can be fixed with this patch.
>
> [ 0.000000] AM3517 ES1.1 (l2cache sgx neon )
> [ 0.000000] ------------[ cut here ]------------
> [ 0.000000] WARNING: at arch/arm/mach-omap2/clockdomain.c:237 _resolve_clkdm_deps+0x68/0x108()
> [ 0.000000] clockdomain: mpu_clkdm: could not find clkdm iva2_clkdm while resolving dependencies - should never happen
> [ 0.000000] Modules linked in:
> [ 0.000000] [<c001bd3c>] (unwind_backtrace+0x0/0xf4) from [<c0040c2c>] (warn_slowpath_common+0x4c/0x64)
> [ 0.000000] [<c0040c2c>] (warn_slowpath_common+0x4c/0x64) from [<c0040cd8>] (warn_slowpath_fmt+0x30/0x40)
> [ 0.000000] [<c0040cd8>] (warn_slowpath_fmt+0x30/0x40) from [<c003256c>] (_resolve_clkdm_deps+0x68/0x108)
> [ 0.000000] [<c003256c>] (_resolve_clkdm_deps+0x68/0x108) from [<c0032640>] (clkdm_complete_init+0x34/0x90)
> [ 0.000000] [<c0032640>] (clkdm_complete_init+0x34/0x90) from [<c06d7600>] (omap3_init_early+0x20/0x30)
> [ 0.000000] [<c06d7600>] (omap3_init_early+0x20/0x30) from [<c06d3230>] (setup_arch+0x834/0x94c)
> [ 0.000000] [<c06d3230>] (setup_arch+0x834/0x94c) from [<c06cf6b0>] (start_kernel+0x88/0x2fc)
> [ 0.000000] [<c06cf6b0>] (start_kernel+0x88/0x2fc) from [<80008044>] (0x80008044)
>
> Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
> ---
> arch/arm/mach-omap2/clockdomains3xxx_data.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/clockdomains3xxx_data.c b/arch/arm/mach-omap2/clockdomains3xxx_data.c
> index d625844..56089c4 100644
> --- a/arch/arm/mach-omap2/clockdomains3xxx_data.c
> +++ b/arch/arm/mach-omap2/clockdomains3xxx_data.c
> @@ -454,7 +454,6 @@ static struct clkdm_autodep clkdm_am35x_autodeps[] = {
>
> static struct clockdomain *clockdomains_common[] __initdata = {
> &wkup_common_clkdm,
> - &mpu_3xxx_clkdm,
> &neon_clkdm,
> &core_l3_3xxx_clkdm,
> &core_l4_3xxx_clkdm,
> --
> 1.7.2.5
Hi Milo.
Thanks for the patch but this issue should already be fixed in a patch
that Tony just made a pull request for
(http://www.spinics.net/lists/linux-omap/msg73080.html).
>From that email (and branch in the email), look for this patch:
> Mark A. Greer (4):
> ARM: OMAP AM35x: clockdomain data: Fix clockdomain dependencies
Please take a look as another set of eyes never hurts. :)
Mark
--
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: OMAP AM35x: clockdomain data: fix resolving dependency problem
2012-07-02 17:41 ` Mark A. Greer
@ 2012-07-07 12:41 ` Ladislav Michl
2012-07-09 16:16 ` Mark A. Greer
0 siblings, 1 reply; 4+ messages in thread
From: Ladislav Michl @ 2012-07-07 12:41 UTC (permalink / raw)
To: Mark A. Greer; +Cc: Kim, Milo, tony@atomide.com, linux-omap@vger.kernel.org
On Mon, Jul 02, 2012 at 10:41:38AM -0700, Mark A. Greer wrote:
> On Mon, Jul 02, 2012 at 05:54:57AM +0000, Kim, Milo wrote:
> > In am35x board , iva2 clock domain doesn't be used.
> > So mpu_am35x_clkdm should be used rather than mpu_3xxx_clkdm.
> > OMAP3430 : mpu_3xxx_clkdm (with iva2 clkdm)
> > AM35x : mpu_am35x_clkdm (without iva2 clkdm)
> >
> > For the compatibility with omap3430, this patch has no conflict because mpu_3xxx_clkdm was already defined in clock domains for omap3430.
> > So this can be removed from common clock domain.
> >
> > Below error can be fixed with this patch.
> >
> > [ 0.000000] AM3517 ES1.1 (l2cache sgx neon )
> > [ 0.000000] ------------[ cut here ]------------
> > [ 0.000000] WARNING: at arch/arm/mach-omap2/clockdomain.c:237 _resolve_clkdm_deps+0x68/0x108()
> > [ 0.000000] clockdomain: mpu_clkdm: could not find clkdm iva2_clkdm while resolving dependencies - should never happen
> > [ 0.000000] Modules linked in:
> > [ 0.000000] [<c001bd3c>] (unwind_backtrace+0x0/0xf4) from [<c0040c2c>] (warn_slowpath_common+0x4c/0x64)
> > [ 0.000000] [<c0040c2c>] (warn_slowpath_common+0x4c/0x64) from [<c0040cd8>] (warn_slowpath_fmt+0x30/0x40)
> > [ 0.000000] [<c0040cd8>] (warn_slowpath_fmt+0x30/0x40) from [<c003256c>] (_resolve_clkdm_deps+0x68/0x108)
> > [ 0.000000] [<c003256c>] (_resolve_clkdm_deps+0x68/0x108) from [<c0032640>] (clkdm_complete_init+0x34/0x90)
> > [ 0.000000] [<c0032640>] (clkdm_complete_init+0x34/0x90) from [<c06d7600>] (omap3_init_early+0x20/0x30)
> > [ 0.000000] [<c06d7600>] (omap3_init_early+0x20/0x30) from [<c06d3230>] (setup_arch+0x834/0x94c)
> > [ 0.000000] [<c06d3230>] (setup_arch+0x834/0x94c) from [<c06cf6b0>] (start_kernel+0x88/0x2fc)
> > [ 0.000000] [<c06cf6b0>] (start_kernel+0x88/0x2fc) from [<80008044>] (0x80008044)
> >
> > Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
> > ---
> > arch/arm/mach-omap2/clockdomains3xxx_data.c | 1 -
> > 1 files changed, 0 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap2/clockdomains3xxx_data.c b/arch/arm/mach-omap2/clockdomains3xxx_data.c
> > index d625844..56089c4 100644
> > --- a/arch/arm/mach-omap2/clockdomains3xxx_data.c
> > +++ b/arch/arm/mach-omap2/clockdomains3xxx_data.c
> > @@ -454,7 +454,6 @@ static struct clkdm_autodep clkdm_am35x_autodeps[] = {
> >
> > static struct clockdomain *clockdomains_common[] __initdata = {
> > &wkup_common_clkdm,
> > - &mpu_3xxx_clkdm,
> > &neon_clkdm,
> > &core_l3_3xxx_clkdm,
> > &core_l4_3xxx_clkdm,
> > --
> > 1.7.2.5
>
> Hi Milo.
>
> Thanks for the patch but this issue should already be fixed in a patch
> that Tony just made a pull request for
> (http://www.spinics.net/lists/linux-omap/msg73080.html).
>
> >From that email (and branch in the email), look for this patch:
>
> > Mark A. Greer (4):
>
> > ARM: OMAP AM35x: clockdomain data: Fix clockdomain dependencies
>
> Please take a look as another set of eyes never hurts. :)
Hi Mark,
just tested above patch on Technexion's TAM-3517 and it indeed fixes above
warning. Without patch, warning is generated. Tested on Tony's master branch.
ladis
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: OMAP AM35x: clockdomain data: fix resolving dependency problem
2012-07-07 12:41 ` Ladislav Michl
@ 2012-07-09 16:16 ` Mark A. Greer
0 siblings, 0 replies; 4+ messages in thread
From: Mark A. Greer @ 2012-07-09 16:16 UTC (permalink / raw)
To: Ladislav Michl; +Cc: Kim, Milo, tony@atomide.com, linux-omap@vger.kernel.org
On Sat, Jul 07, 2012 at 02:41:31PM +0200, Ladislav Michl wrote:
> On Mon, Jul 02, 2012 at 10:41:38AM -0700, Mark A. Greer wrote:
> > On Mon, Jul 02, 2012 at 05:54:57AM +0000, Kim, Milo wrote:
> > > In am35x board , iva2 clock domain doesn't be used.
> > > So mpu_am35x_clkdm should be used rather than mpu_3xxx_clkdm.
> > > OMAP3430 : mpu_3xxx_clkdm (with iva2 clkdm)
> > > AM35x : mpu_am35x_clkdm (without iva2 clkdm)
> > > diff --git a/arch/arm/mach-omap2/clockdomains3xxx_data.c b/arch/arm/mach-omap2/clockdomains3xxx_data.c
> > > index d625844..56089c4 100644
> > > --- a/arch/arm/mach-omap2/clockdomains3xxx_data.c
> > > +++ b/arch/arm/mach-omap2/clockdomains3xxx_data.c
> > > @@ -454,7 +454,6 @@ static struct clkdm_autodep clkdm_am35x_autodeps[] = {
> > >
> > > static struct clockdomain *clockdomains_common[] __initdata = {
> > > &wkup_common_clkdm,
> > > - &mpu_3xxx_clkdm,
> > > &neon_clkdm,
> > > &core_l3_3xxx_clkdm,
> > > &core_l4_3xxx_clkdm,
> > > --
> > > 1.7.2.5
> >
> > Hi Milo.
> >
> > Thanks for the patch but this issue should already be fixed in a patch
> > that Tony just made a pull request for
> > (http://www.spinics.net/lists/linux-omap/msg73080.html).
> >
> > >From that email (and branch in the email), look for this patch:
> >
> > > Mark A. Greer (4):
> >
> > > ARM: OMAP AM35x: clockdomain data: Fix clockdomain dependencies
> >
> > Please take a look as another set of eyes never hurts. :)
>
> Hi Mark,
>
> just tested above patch on Technexion's TAM-3517 and it indeed fixes above
> warning. Without patch, warning is generated. Tested on Tony's master branch.
Great, thanks for the follow up, Ladis.
Mark
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-07-09 16:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-02 5:54 [PATCH] ARM: OMAP AM35x: clockdomain data: fix resolving dependency problem Kim, Milo
2012-07-02 17:41 ` Mark A. Greer
2012-07-07 12:41 ` Ladislav Michl
2012-07-09 16:16 ` Mark A. Greer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox