Re: [PATCH v6 00/13] Fixes to pcie-tegra194 driver

[Jon Hunter <jonathanh@nvidia.com>]

On 23/02/2026 18:41, Manikanta Maddireddy wrote:
> This series[1] was originally posted by Vidya Sagar, and I have rebased
> it onto 6.19.0-rc6-next. I addressed review comments and split this into
> two series, one for fixes(current) and the other is for enhancements.
> I verified these patches on Jetson AGX Orin(Tegra234 SoC).
> 
> I added below four new patches to fix bugs, commit message of each
> patch has the details on the bug and fix.
>   - PCI: tegra194: Use HW version number
>   - PCI: tegra194: Fix CBB timeout caused by DBI access before core power-on
>   - PCI: tegra194: Disable PERST IRQ only in Endpoint mode
> 
> Rest of the patches are same as the original V3 series, just rebased them on
> 6.19.0-rc6-next.
> 
> I fixed the missing PATCH prefix in the subject in V6 and also reordered the
> patches with regard to fixes tag.
> 
> Verification details.
>   - I verified both Root port and Endpoint mode controllers on Tegra234 SoC.
>   - Basic sanity Link up, configuration space access and BAR access are verified.
>   - I verified that ASPM L1.2 capability is disabled for Endpoint mode.
>   - I verified suspend to RAM tests with Endpoint mode.
> 
> [1] https://patchwork.kernel.org/project/linux-pci/patch/20221013183854.21087-1-vidyas@nvidia.com/
> 
> Manikanta Maddireddy (3):
>    PCI: tegra194: Disable PERST IRQ only in Endpoint mode
>    PCI: tegra194: Use HW version number
>    PCI: tegra194: Fix CBB timeout caused by DBI access before core
>      power-on
> 
> Vidya Sagar (10):
>    PCI: tegra194: Fix polling delay for L2 state
>    PCI: tegra194: Refactor LTSSM state polling on surprise down
>    PCI: tegra194: Don't force the device into the D0 state before L2
>    PCI: tegra194: Use devm_gpiod_get_optional() to parse
>      "nvidia,refclk-select"
>    PCI: tegra194: Disable direct speed change for EP
>    PCI: tegra194: Set LTR message request before PCIe link up
>    PCI: tegra194: Apply pinctrl settings for both PCIe RP and EP
>    PCI: tegra194: Allow system suspend when the Endpoint link is not up
>    PCI: tegra194: Free up EP resources during remove()
>    PCI: tegra194: Free resources during controller deinitialization
> 
>   drivers/pci/controller/dwc/pcie-designware.c |   2 +-
>   drivers/pci/controller/dwc/pcie-designware.h |   2 +
>   drivers/pci/controller/dwc/pcie-tegra194.c   | 191 +++++++++----------
>   3 files changed, 95 insertions(+), 100 deletions(-)
> 

For the series ...

Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
Tested-by: Jon Hunter <jonathanh@nvidia.com>

Thanks
Jon

-- 
nvpublic