[pci:slot-reset 1/1] drivers/pci/controller/dwc/pcie-dw-rockchip.c:721:58: error: use of undeclared identifier 'PCIE_CLIENT_GENERAL_CON'

[pci:slot-reset 1/1] drivers/pci/controller/dwc/pcie-dw-rockchip.c:721:58: error: use of undeclared identifier 'PCIE_CLIENT_GENERAL_CON'

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git slot-reset
head:   ebf9d2fae99254fc37f49384b769f363e676018d
commit: ebf9d2fae99254fc37f49384b769f363e676018d [1/1] PCI: dw-rockchip: Add support for slot reset on link down event
config: arm64-randconfig-002-20250515 (https://download.01.org/0day-ci/archive/20250515/202505152337.AoKvnBmd-lkp@intel.com/config)
compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project f819f46284f2a79790038e1f6649172789734ae8)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250515/202505152337.AoKvnBmd-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505152337.AoKvnBmd-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/pci/controller/dwc/pcie-dw-rockchip.c:721:58: error: use of undeclared identifier 'PCIE_CLIENT_GENERAL_CON'
     721 |         rockchip_pcie_writel_apb(rockchip, PCIE_CLIENT_RC_MODE, PCIE_CLIENT_GENERAL_CON);
         |                                                                 ^
   1 error generated.


vim +/PCIE_CLIENT_GENERAL_CON +721 drivers/pci/controller/dwc/pcie-dw-rockchip.c

   679	
   680	static int rockchip_pcie_rc_reset_slot(struct pci_host_bridge *bridge,
   681					       struct pci_dev *pdev)
   682	{
   683		struct pci_bus *bus = bridge->bus;
   684		struct dw_pcie_rp *pp = bus->sysdata;
   685		struct dw_pcie *pci = to_dw_pcie_from_pp(pp);
   686		struct rockchip_pcie *rockchip = to_rockchip_pcie(pci);
   687		struct device *dev = rockchip->pci.dev;
   688		u32 val;
   689		int ret;
   690	
   691		dw_pcie_stop_link(pci);
   692		clk_bulk_disable_unprepare(rockchip->clk_cnt, rockchip->clks);
   693		rockchip_pcie_phy_deinit(rockchip);
   694	
   695		ret = reset_control_assert(rockchip->rst);
   696		if (ret)
   697			return ret;
   698	
   699		ret = rockchip_pcie_phy_init(rockchip);
   700		if (ret)
   701			goto disable_regulator;
   702	
   703		ret = reset_control_deassert(rockchip->rst);
   704		if (ret)
   705			goto deinit_phy;
   706	
   707		ret = rockchip_pcie_clk_init(rockchip);
   708		if (ret)
   709			goto deinit_phy;
   710	
   711		ret = pp->ops->init(pp);
   712		if (ret) {
   713			dev_err(dev, "host init failed: %d\n", ret);
   714			goto deinit_clk;
   715		}
   716	
   717		/* LTSSM enable control mode. */
   718		val = HIWORD_UPDATE_BIT(PCIE_LTSSM_ENABLE_ENHANCE);
   719		rockchip_pcie_writel_apb(rockchip, val, PCIE_CLIENT_HOT_RESET_CTRL);
   720	
 > 721		rockchip_pcie_writel_apb(rockchip, PCIE_CLIENT_RC_MODE, PCIE_CLIENT_GENERAL_CON);
   722	
   723		ret = dw_pcie_setup_rc(pp);
   724		if (ret) {
   725			dev_err(dev, "failed to setup RC: %d\n", ret);
   726			goto deinit_clk;
   727		}
   728	
   729		/* Unmask DLL up/down indicator and hot reset/link-down reset IRQ. */
   730		val = HIWORD_UPDATE(PCIE_RDLH_LINK_UP_CHGED | PCIE_LINK_REQ_RST_NOT_INT, 0);
   731		rockchip_pcie_writel_apb(rockchip, val, PCIE_CLIENT_INTR_MASK_MISC);
   732	
   733		ret = dw_pcie_start_link(pci);
   734		if (ret)
   735			goto deinit_clk;
   736	
   737		/* Ignore errors, the link may come up later. */
   738		dw_pcie_wait_for_link(pci);
   739		dev_dbg(dev, "slot reset completed\n");
   740		return ret;
   741	
   742	deinit_clk:
   743		clk_bulk_disable_unprepare(rockchip->clk_cnt, rockchip->clks);
   744	deinit_phy:
   745		rockchip_pcie_phy_deinit(rockchip);
   746	disable_regulator:
   747		if (rockchip->vpcie3v3)
   748			regulator_disable(rockchip->vpcie3v3);
   749	
   750		return ret;
   751	}
   752	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

回复: [pci:slot-reset 1/1] drivers/pci/controller/dwc/pcie-dw-rockchip.c:721:58: error: use of undeclared identifier 'PCIE_CLIENT_GENERAL_CON'

[Hans Zhang]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb2312", Size: 5097 bytes --]

Hi,

Please merge it into the following branch; otherwise, this compilation error will occur.

https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/log/?h=controller/dw-rockchip

Best regards,
Hans

-----ÓʼþÔ­¼þ-----
·¢¼þÈË: kernel test robot <lkp@intel.com> 
·¢ËÍʱ¼ä: 2025Äê5ÔÂ15ÈÕ 23:24
ÊÕ¼þÈË: Wilfred Mallawa <wilfred.mallawa@wdc.com>
³­ËÍ: llvm@lists.linux.dev; oe-kbuild-all@lists.linux.dev; linux-pci@vger.kernel.org; Krzysztof Wilczy¨½ski <kwilczynski@kernel.org>; Niklas Cassel <cassel@kernel.org>
Ö÷Ìâ: [pci:slot-reset 1/1] drivers/pci/controller/dwc/pcie-dw-rockchip.c:721:58: error: use of undeclared identifier 'PCIE_CLIENT_GENERAL_CON'

EXTERNAL EMAIL

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git slot-reset
head:   ebf9d2fae99254fc37f49384b769f363e676018d
commit: ebf9d2fae99254fc37f49384b769f363e676018d [1/1] PCI: dw-rockchip: Add support for slot reset on link down event
config: arm64-randconfig-002-20250515 (https://download.01.org/0day-ci/archive/20250515/202505152337.AoKvnBmd-lkp@intel.com/config)
compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project f819f46284f2a79790038e1f6649172789734ae8)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250515/202505152337.AoKvnBmd-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: 
| https://lore.kernel.org/oe-kbuild-all/202505152337.AoKvnBmd-lkp@intel.
| com/

All errors (new ones prefixed by >>):

>> drivers/pci/controller/dwc/pcie-dw-rockchip.c:721:58: error: use of undeclared identifier 'PCIE_CLIENT_GENERAL_CON'
     721 |         rockchip_pcie_writel_apb(rockchip, PCIE_CLIENT_RC_MODE, PCIE_CLIENT_GENERAL_CON);
         |                                                                 ^
   1 error generated.


vim +/PCIE_CLIENT_GENERAL_CON +721 drivers/pci/controller/dwc/pcie-dw-rockchip.c

   679
   680  static int rockchip_pcie_rc_reset_slot(struct pci_host_bridge *bridge,
   681                                         struct pci_dev *pdev)
   682  {
   683          struct pci_bus *bus = bridge->bus;
   684          struct dw_pcie_rp *pp = bus->sysdata;
   685          struct dw_pcie *pci = to_dw_pcie_from_pp(pp);
   686          struct rockchip_pcie *rockchip = to_rockchip_pcie(pci);
   687          struct device *dev = rockchip->pci.dev;
   688          u32 val;
   689          int ret;
   690
   691          dw_pcie_stop_link(pci);
   692          clk_bulk_disable_unprepare(rockchip->clk_cnt, rockchip->clks);
   693          rockchip_pcie_phy_deinit(rockchip);
   694
   695          ret = reset_control_assert(rockchip->rst);
   696          if (ret)
   697                  return ret;
   698
   699          ret = rockchip_pcie_phy_init(rockchip);
   700          if (ret)
   701                  goto disable_regulator;
   702
   703          ret = reset_control_deassert(rockchip->rst);
   704          if (ret)
   705                  goto deinit_phy;
   706
   707          ret = rockchip_pcie_clk_init(rockchip);
   708          if (ret)
   709                  goto deinit_phy;
   710
   711          ret = pp->ops->init(pp);
   712          if (ret) {
   713                  dev_err(dev, "host init failed: %d\n", ret);
   714                  goto deinit_clk;
   715          }
   716
   717          /* LTSSM enable control mode. */
   718          val = HIWORD_UPDATE_BIT(PCIE_LTSSM_ENABLE_ENHANCE);
   719          rockchip_pcie_writel_apb(rockchip, val, PCIE_CLIENT_HOT_RESET_CTRL);
   720
 > 721          rockchip_pcie_writel_apb(rockchip, PCIE_CLIENT_RC_MODE, PCIE_CLIENT_GENERAL_CON);
   722
   723          ret = dw_pcie_setup_rc(pp);
   724          if (ret) {
   725                  dev_err(dev, "failed to setup RC: %d\n", ret);
   726                  goto deinit_clk;
   727          }
   728
   729          /* Unmask DLL up/down indicator and hot reset/link-down reset IRQ. */
   730          val = HIWORD_UPDATE(PCIE_RDLH_LINK_UP_CHGED | PCIE_LINK_REQ_RST_NOT_INT, 0);
   731          rockchip_pcie_writel_apb(rockchip, val, PCIE_CLIENT_INTR_MASK_MISC);
   732
   733          ret = dw_pcie_start_link(pci);
   734          if (ret)
   735                  goto deinit_clk;
   736
   737          /* Ignore errors, the link may come up later. */
   738          dw_pcie_wait_for_link(pci);
   739          dev_dbg(dev, "slot reset completed\n");
   740          return ret;
   741
   742  deinit_clk:
   743          clk_bulk_disable_unprepare(rockchip->clk_cnt, rockchip->clks);
   744  deinit_phy:
   745          rockchip_pcie_phy_deinit(rockchip);
   746  disable_regulator:
   747          if (rockchip->vpcie3v3)
   748                  regulator_disable(rockchip->vpcie3v3);
   749
   750          return ret;
   751  }
   752

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: 回复: [pci:slot-reset 1/1] drivers/pci/controller/dwc/pcie-dw-rockchip.c:721:58: error: use of undeclared identifier 'PCIE_CLIENT_GENERAL_CON'

[Krzysztof Wilczy��ski]

(+Cc Mani for visibility)

Hello,

> Please merge it into the following branch; otherwise, this compilation error will occur.
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/log/?h=controller/dw-rockchip
> 
> All errors (new ones prefixed by >>):
> 
> >> drivers/pci/controller/dwc/pcie-dw-rockchip.c:721:58: error: use of undeclared identifier 'PCIE_CLIENT_GENERAL_CON'
>      721 |         rockchip_pcie_writel_apb(rockchip, PCIE_CLIENT_RC_MODE, PCIE_CLIENT_GENERAL_CON);
>          |                                                                 ^
>    1 error generated.

Sorry about this!

I moved changes from the slot-reset to the controller/dw-rockchip branch,
to make sure everything has proper dependencies now.  Hopefully, there
won't be any more issues.

Thank you!

	Krzysztof

Re: 回复: [pci:slot-reset 1/1] drivers/pci/controller/dwc/pcie-dw-rockchip.c:721:58: error: use of undeclared identifier 'PCIE_CLIENT_GENERAL_CON'

[Wilfred Mallawa]

On Fri, 2025-05-16 at 01:24 +0900, Krzysztof Wilczy��ski wrote:
> Sorry about this!
> 
> I moved changes from the slot-reset to the controller/dw-rockchip
> branch,
> to make sure everything has proper dependencies now.  Hopefully,
> there
> won't be any more issues.
> 
> Thank you!
> 
> 	Krzysztof
Great! Thanks Krzysztof!

Regards,
Wilfred

Re: 回复: [pci:slot-reset 1/1] drivers/pci/controller/dwc/pcie-dw-rockchip.c:721:58: error: use of undeclared identifier 'PCIE_CLIENT_GENERAL_CON'

[Niklas Cassel]

Hello Krzysztof,


FYI: your name appears corrupted in my inbox.

From: Krzysztof Wilczy��ski <your-email-address>

Perhaps because:
Content-Type: text/plain; charset=us-ascii

instead of UTF-8?


On Fri, May 16, 2025 at 01:24:05AM +0900, Krzysztof Wilczy��ski wrote:
> (+Cc Mani for visibility)
> 
> Hello,
> 
> > Please merge it into the following branch; otherwise, this compilation error will occur.
> > 
> > https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/log/?h=controller/dw-rockchip
> > 
> > All errors (new ones prefixed by >>):
> > 
> > >> drivers/pci/controller/dwc/pcie-dw-rockchip.c:721:58: error: use of undeclared identifier 'PCIE_CLIENT_GENERAL_CON'
> >      721 |         rockchip_pcie_writel_apb(rockchip, PCIE_CLIENT_RC_MODE, PCIE_CLIENT_GENERAL_CON);
> >          |                                                                 ^
> >    1 error generated.
> 
> Sorry about this!
> 
> I moved changes from the slot-reset to the controller/dw-rockchip branch,
> to make sure everything has proper dependencies now.  Hopefully, there
> won't be any more issues.


Comparing the commit that landed on the branch, with Wilfred's patch on the
mailing list, I did notice this diff:


diff --git a/drivers/pci/controller/dwc/pcie-dw-rockchip.c b/drivers/pci/controller/dwc/pcie-dw-rockchip.c
index 9a952871e4d0..c4bd7e0abdf0 100644
--- a/drivers/pci/controller/dwc/pcie-dw-rockchip.c
+++ b/drivers/pci/controller/dwc/pcie-dw-rockchip.c
@@ -556,7 +556,7 @@ static int rockchip_pcie_configure_rc(struct platform_device *pdev,
                return ret;
        }
 
-       /* unmask DLL up/down indicator and hot reset/link-down reset irq */
+       /* Unmask DLL up/down indicator and hot reset/link-down reset IRQ. */
        val = HIWORD_UPDATE(PCIE_RDLH_LINK_UP_CHGED | PCIE_LINK_REQ_RST_NOT_INT, 0);
        rockchip_pcie_writel_apb(rockchip, val, PCIE_CLIENT_INTR_MASK_MISC);
 
@@ -747,11 +747,11 @@ static int rockchip_pcie_rc_reset_slot(struct pci_host_bridge *bridge,
 
        ret = pp->ops->init(pp);
        if (ret) {
-               dev_err(dev, "Host init failed: %d\n", ret);
+               dev_err(dev, "host init failed: %d\n", ret);
                goto deinit_clk;
        }
 
-       /* LTSSM enable control mode */
+       /* LTSSM enable control mode. */
        val = HIWORD_UPDATE_BIT(PCIE_LTSSM_ENABLE_ENHANCE);
        rockchip_pcie_writel_apb(rockchip, val, PCIE_CLIENT_HOT_RESET_CTRL);
 
@@ -762,11 +762,11 @@ static int rockchip_pcie_rc_reset_slot(struct pci_host_bridge *bridge,
 
        ret = dw_pcie_setup_rc(pp);
        if (ret) {
-               dev_err(dev, "Failed to setup RC: %d\n", ret);
+               dev_err(dev, "failed to setup RC: %d\n", ret);
                goto deinit_clk;
        }
 
-       /* unmask DLL up/down indicator and hot reset/link-down reset irq */
+       /* Unmask DLL up/down indicator and hot reset/link-down reset IRQ. */
        val = HIWORD_UPDATE(PCIE_RDLH_LINK_UP_CHGED | PCIE_LINK_REQ_RST_NOT_INT, 0);
        rockchip_pcie_writel_apb(rockchip, val, PCIE_CLIENT_INTR_MASK_MISC);
 
@@ -774,9 +774,9 @@ static int rockchip_pcie_rc_reset_slot(struct pci_host_bridge *bridge,
        if (ret)
                goto deinit_clk;
 
-       /* Ignore errors, the link may come up later */
+       /* Ignore errors, the link may come up later. */
        dw_pcie_wait_for_link(pci);
-       dev_dbg(dev, "Slot reset completed\n");
+       dev_dbg(dev, "slot reset completed\n");
        return ret;
 
 deinit_clk:



Reviewing the diff, the changes looks fine to me, but I strongly think
that if the actual code is modified from the submission (rather than
just fixing some minor grammar in the commit message), the (unwritten?)
rule is that the person should add a:

[person: describe modifications from the original submission]

line after the Signed-off-by of the original submission, such that,
e.g. if there is a bug in one of the lines that were changed, the
original author does not unfairly get blamed for some code that he
didn't write.

When only modifying the commit log, there is no possibility that a
functional change was introduced, but as soon as the code/diff is
changed, there is a change that a functional change is introduced
(intentional or not), so there is a big difference between the cases
(in my humble opinion).


Kind regards,
Niklas

Re: 回复: [pci:slot-reset 1/1] drivers/pci/controller/dwc/pcie-dw-rockchip.c:721:58: error: use of undeclared identifier 'PCIE_CLIENT_GENERAL_CON'

[Krzysztof Wilczy��ski]

Hello,

[...]
> Comparing the commit that landed on the branch, with Wilfred's patch on the
> mailing list, I did notice this diff:

[...]
> Reviewing the diff, the changes looks fine to me, but I strongly think
> that if the actual code is modified from the submission (rather than
> just fixing some minor grammar in the commit message), the (unwritten?)
> rule is that the person should add a:
> 
> [person: describe modifications from the original submission]

Sorry about that.  I did forgot to add this.  Good catch.

That said, a single single line with a nudge or a reminder would suffice.

There is no need for a condescending tone and the lecturing and such.

You have been doing this for a while now, and if you continue doing this,
I will have no choice but to start to ignore submissions from you, I do not
have the time to deal with any forms of such passive-aggressive attitude.

Thank you!

	Krzysztof

Re: 回复: [pci:slot-reset 1/1] drivers/pci/controller/dwc/pcie-dw-rockchip.c:721:58: error: use of undeclared identifier 'PCIE_CLIENT_GENERAL_CON'

[Niklas Cassel]

Hello Krzysztof,

On Fri, May 16, 2025 at 07:36:33PM +0900, Krzysztof Wilczy��ski wrote:
> Hello,
> 
> [...]
> > Comparing the commit that landed on the branch, with Wilfred's patch on the
> > mailing list, I did notice this diff:
> 
> [...]
> > Reviewing the diff, the changes looks fine to me, but I strongly think
> > that if the actual code is modified from the submission (rather than
> > just fixing some minor grammar in the commit message), the (unwritten?)
> > rule is that the person should add a:
> > 
> > [person: describe modifications from the original submission]
> 
> Sorry about that.  I did forgot to add this.  Good catch.
> 
> That said, a single single line with a nudge or a reminder would suffice.
> 
> There is no need for a condescending tone and the lecturing and such.

I've been reading my reply multiple times, and I honestly don't understand
where this is coming from.

I was simply saying that, if the actual code is changed when applying,
then I think that it is important to either:
1) Write something in the thread (e.g. in the 'Applied' message), or
2) Add a [user: ] line after the SoB

When it comes to simply modifying the commit log, then, my personal
opinion is that 1) and/or 2) is of magnitudes less importance.

I wasn't trying to lecture, I was simply trying to explain the logic of
my opinion.


> 
> You have been doing this for a while now, and if you continue doing this,
> I will have no choice but to start to ignore submissions from you, I do not
> have the time to deal with any forms of such passive-aggressive attitude.

This is surprising to me, our only other discussion recently was about
RESEND tags, were I also stated my personal opinion.

But that was also a sensible discussion IMO.

Not being allowed to pick up tags, e.g. Reviewed-by and Tested-by, when
doing a RESEND (as long as code and commit log is unchanged) seems
counterproductive to me, as the time spent by the Tester/Reviewer would
have been for nought.


Kind regards,
Niklas