From: Lukas Wunner <lukas@wunner.de>
To: "guanghui.fgh" <guanghuifeng@linux.alibaba.com>
Cc: "Bjorn Helgaas" <helgaas@kernel.org>,
linux-pci <linux-pci@vger.kernel.org>,
kanie <kanie@linux.alibaba.com>,
alikernel-developer <alikernel-developer@linux.alibaba.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: Re: [PATCH] PCI: Fix PCIe SBR dev/link wait error
Date: Mon, 1 Dec 2025 11:03:46 +0100 [thread overview]
Message-ID: <aS1oArFHeo9FAuv-@wunner.de> (raw)
In-Reply-To: <a4a2a5ee-1f4e-4560-b8cf-c9c10ae475dd.guanghuifeng@linux.alibaba.com>
On Tue, Nov 25, 2025 at 02:20:10PM +0800, guanghui.fgh wrote:
> After __pci_reset_slot/__pci_reset_bus calls
> pci_bridge_wait_for_secondary_bus, the device will be restored via
> pci_dev_restore. However, when a multifunction PCIe device is connected,
> executing pci_bridge_wait_for_secondary_bus only guarantees the restoration
> of a random device. For other devices that are still restoring, executing
> pci_dev_restore cannot restore the device state normally, resulting in
> errors or even device offline.
PCIe is point-to-point, i.e. at the two ends of a link there's only a
single physical device. So if there are multiple pci_dev's on a bus,
they're additional functions or VFs of the same physical device.
The expectation is that if the first device on the bus is accessible,
all other functions of the same physical device are accessible as well.
That's why we only wait for the first device to become accessible.
It seems highly unusual that the different functions of the same physical
device require different delays until they're accessible. I don't think
we can accept such a sweeping change wholesale without more details,
so please share what the topology looks like (lspci -tv), what devices are
involved (lspci -vvv) and which device requires extra wait time for some
of its functions.
Thanks,
Lukas
next prev parent reply other threads:[~2025-12-01 10:03 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-24 10:45 [PATCH] PCI: Fix PCIe SBR dev/link wait error Guanghui Feng
2025-11-24 23:58 ` Bjorn Helgaas
2025-11-25 6:20 ` guanghui.fgh
2025-12-01 10:03 ` Lukas Wunner [this message]
2025-12-01 12:56 ` guanghuifeng
2025-12-01 13:26 ` Lukas Wunner
2025-12-01 14:46 ` guanghuifeng
2025-12-01 16:18 ` Lukas Wunner
2025-11-26 8:20 ` Ilpo Järvinen
2025-11-26 12:08 ` guanghui.fgh
2025-11-26 12:37 ` Ilpo Järvinen
2025-11-26 14:22 ` guanghui.fgh
2025-11-26 14:47 ` Ilpo Järvinen
2025-11-29 16:36 ` [PATCH v2] " Guanghui Feng
2025-12-01 9:21 ` Ilpo Järvinen
2025-12-01 12:21 ` guanghuifeng
2025-12-01 13:08 ` Ilpo Järvinen
2025-12-02 4:32 ` [PATCH v4 0/1] " Guanghui Feng
2025-12-02 4:32 ` [PATCH v4 v4 1/1] " Guanghui Feng
2025-12-02 16:49 ` Bjorn Helgaas
2025-12-02 16:51 ` Bjorn Helgaas
2025-12-03 14:41 ` Ilpo Järvinen
2025-11-30 5:17 ` [PATCH v3] " Guanghui Feng
2025-12-01 9:24 ` Ilpo Järvinen
2025-12-01 12:31 ` guanghuifeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aS1oArFHeo9FAuv-@wunner.de \
--to=lukas@wunner.de \
--cc=alikernel-developer@linux.alibaba.com \
--cc=guanghuifeng@linux.alibaba.com \
--cc=helgaas@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=kanie@linux.alibaba.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox