Re: [PATCH v7 02/23] tools/thermal: Fix typo

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Fixing the `CFGLAS` typo to `CFLAGS` introduces linker flags (`-Wl,-lthermal` and `-Wl,-L.`) into the C compilation phase (`CFLAGS`). This breaks the build under Clang because the unused linker arguments during the `-c` compilation step trigger a warning that is turned into a fatal error by `-Werror`. Furthermore, these flags are useless because `CFLAGS` is not even passed to the `$(CC) --shared` link step in these Makefiles.
--

commit 93498abb92499dd9b72fc403e55f192942d97b46
Author: Leo Yan <leo.yan@arm.com>

tools/thermal: Fix typo

This commit fixes a typo in the tools/thermal/lib/Makefile, changing CFGLAS
to CFLAGS for the thermal library linker flags.

> diff --git a/tools/thermal/lib/Makefile b/tools/thermal/lib/Makefile
> --- a/tools/thermal/lib/Makefile
> +++ b/tools/thermal/lib/Makefile
> @@ -60,8 +60,8 @@ override CFLAGS += $(EXTRA_WARNINGS)
>  override CFLAGS += -Werror -Wall
>  override CFLAGS += -fPIC
>  override CFLAGS += $(INCLUDES)
> -override CFGLAS += -Wl,-L.
> -override CFGLAS += -Wl,-lthermal
> +override CFLAGS += -Wl,-L.
> +override CFLAGS += -Wl,-lthermal

[Severity: Low]
Does adding these linker flags into the C compilation phase break the build
when compiling with Clang?

Since the Makefile also specifies -Werror, passing -Wl,-lthermal and -Wl,-L.
during the C compilation step might trigger a fatal unused argument warning
under Clang. 

Are these linker flags actually needed in CFLAGS, or should they be added to
LDFLAGS instead, considering CFLAGS doesn't appear to be passed to the shared
link step?

Also, does the prior commit in this series introduce this same behavior in
tools/lib/thermal/Makefile by fixing an identical typo?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260602-tools_build_fix_zero_init-v7-0-631baf679fe7@arm.com?part=2