Re: [PATCH v7 08/23] tools build: Append extra host CFLAGS for fixdep

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The link step for `fixdep` replaces `KBUILD_HOSTLDFLAGS` with `HOST_CFLAGS`, unintentionally dropping all host linker flags.
--

commit fdc8f23a99f210f1577aab161879510c7af15c47
Author: Leo Yan <leo.yan@arm.com>

tools build: Append extra host CFLAGS for fixdep

This commit introduces a local HOST_CFLAGS variable that combines
KBUILD_HOSTCFLAGS and HOST_EXTRACFLAGS, and passes it to the fixdep build
process to ensure host compiler options are included.

> diff --git a/tools/build/Makefile b/tools/build/Makefile
> index 3a5a3808ab2a1..2761f80df7611 100644
> --- a/tools/build/Makefile
> +++ b/tools/build/Makefile

[ ... ]

>  $(FIXDEP): $(FIXDEP_IN)
> -	$(QUIET_LINK)$(HOSTCC) $(FIXDEP_IN) $(KBUILD_HOSTLDFLAGS) -o $@
> +	$(QUIET_LINK)$(HOSTCC) $(FIXDEP_IN) $(HOST_CFLAGS) -o $@

[Severity: Low]
Does this unintentionally drop the host linker flags? 

By replacing KBUILD_HOSTLDFLAGS with HOST_CFLAGS during the link step for
the fixdep executable, we might be missing required linker flags like LFS
options or custom library paths. 

Should this step retain KBUILD_HOSTLDFLAGS instead of or in addition to
HOST_CFLAGS when generating the binary?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260602-tools_build_fix_zero_init-v7-0-631baf679fe7@arm.com?part=8