Re: [PATCH v7 01/23] tools: lib: thermal: Fix typo

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Fixing the 'CFGLAS' typo activates logically incorrect linker flags inside the compiler flags (CFLAGS), injecting them into the object compilation step.
--

commit 783a6df50ce2cf932c85a46af96705ee016835e4
Author: Leo Yan <leo.yan@arm.com>

tools: lib: thermal: Fix typo

This commit fixes a typo in tools/lib/thermal/Makefile by replacing
CFGLAS with CFLAGS for the linker flags.

> diff --git a/tools/lib/thermal/Makefile b/tools/lib/thermal/Makefile
> --- a/tools/lib/thermal/Makefile
> +++ b/tools/lib/thermal/Makefile
> @@ -66,8 +66,8 @@ override CFLAGS += -fPIC
>  override CFLAGS += $(NL3_CFLAGS)
>  override CFLAGS += $(INCLUDES)
>  override CFLAGS += -fvisibility=hidden
> -override CFGLAS += -Wl,-L.
> -override CFGLAS += -Wl,-lthermal
> +override CFLAGS += -Wl,-L.
> +override CFLAGS += -Wl,-lthermal

[Severity: Low]
Does this activate logically incorrect linker flags?

By fixing the typo, the linker flags -Wl,-L. and -Wl,-lthermal are now injected
into CFLAGS. Linker flags do not belong in CFLAGS, which is used for compiling
object files. Furthermore, instructing libthermal to link against itself while
it is being built is conceptually a circular dependency.

While GCC silently ignores these flags during object compilation, their
presence in CFLAGS causes Clang to emit -Wunused-command-line-argument
warnings. Because the Makefile enforces -Werror, this newly introduced logical
error breaks the build for Clang users.

Should these two lines be deleted entirely instead of renaming the variable?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260602-tools_build_fix_zero_init-v7-0-631baf679fe7@arm.com?part=1