Re: [PATCH v7 05/23] selftests/nolibc: Use a dedicated cross cc-option helper

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Renaming `cc-option` to `cross-cc-option` in `Makefile.nolibc` breaks compiler flag probing in `Makefile.include` during cross-builds with Clang.
--

commit 2287b14b38d381104f1caab4547ea009ec49cae7
Author: Leo Yan <leo.yan@arm.com>

selftests/nolibc: Use a dedicated cross cc-option helper

This commit renames the nolibc cc-option helper to cross-cc-option to ensure
CLANG_CROSS_FLAGS is used for architecture-specific flag probes. This keeps
cross-build checks explicit and avoids clashing with the common tools helper.

> diff --git a/tools/testing/selftests/nolibc/Makefile.nolibc b/tools/testing/selftests/nolibc/Makefile.nolibc
> --- a/tools/testing/selftests/nolibc/Makefile.nolibc
> +++ b/tools/testing/selftests/nolibc/Makefile.nolibc
> @@ -23,7 +23,7 @@ include $(srctree)/scripts/subarch.include
>  ARCH = $(SUBARCH)
>  endif
>  
> -cc-option = $(call __cc-option, $(CC),$(CLANG_CROSS_FLAGS),$(1),$(2))
> +cross-cc-option = $(call __cc-option, $(CC),$(CLANG_CROSS_FLAGS),$(1),$(2))

[Severity: Medium]
Does this change break compiler flag probing in Makefile.include during
cross-builds with Clang?

Since cc-option is no longer overridden to include $(CLANG_CROSS_FLAGS) here,
uses of cc-option in Makefile.include will fall back to the generic cc-option
defined in scripts/Makefile.compiler.

For example, Makefile.include evaluates:

__CFLAGS_STACKPROTECTOR = $(call cc-option,-fstack-protector-all) \
    $(call cc-option,-mstack-protector-guard=global)

Because CC is left as just clang without any target flags in this context,
the generic cc-option will probe the host compiler instead of the target
compiler. Could this discard valid target flags if the host doesn't support
them, altering test coverage and breaking feature enablement for the nolibc
test suite?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260602-tools_build_fix_zero_init-v7-0-631baf679fe7@arm.com?part=5