Re: [PATCH v7 17/23] tools: power: acpi: Append extra cflags

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] EXTRA_CFLAGS cannot override optimization and debug flags.
--

commit bdc57550350069918185456205e82edb378bafaf
Author: Leo Yan <leo.yan@arm.com>

tools: power: acpi: Append extra cflags

Append EXTRA_CFLAGS to CFLAGS so that additional flags can be applied to
the compiler.

> diff --git a/tools/power/acpi/Makefile.config b/tools/power/acpi/Makefile.config
> --- a/tools/power/acpi/Makefile.config
> +++ b/tools/power/acpi/Makefile.config
> @@ -69,6 +69,7 @@ KERNEL_INCLUDE := $(OUTPUT)include
>  ACPICA_INCLUDE := $(srctree)/../../../drivers/acpi/acpica
>  CFLAGS += -D_LINUX -I$(KERNEL_INCLUDE) -I$(ACPICA_INCLUDE)
>  CFLAGS += $(WARNINGS)
> +CFLAGS += $(EXTRA_CFLAGS)

[Severity: Low]
Will appending EXTRA_CFLAGS here prevent it from overriding the default
optimization and debug flags?

Because CFLAGS are evaluated sequentially by the compiler, any flags added
later in the file will override earlier ones. Further down in 
tools/power/acpi/Makefile.config, the optimization flags are appended:

# if DEBUG is enabled, then we do not strip or optimize
ifeq ($(strip $(DEBUG)),true)
	CFLAGS += -O1 -g -DDEBUG
	STRIPCMD = /bin/true -Since_we_are_debugging
else
	CFLAGS += $(OPTIMIZATION) -fomit-frame-pointer
	STRIPCMD = $(STRIP) -s --remove-section=.note --remove-section=.comment
endif

It appears that user-provided optimization overrides (such as passing -O0
in EXTRA_CFLAGS) will be silently overridden by these defaults. Should
EXTRA_CFLAGS be appended after the debug and optimization flags instead?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260602-tools_build_fix_zero_init-v7-0-631baf679fe7@arm.com?part=17