Re: [PATCH v10 4/5] perf test: Add inject ASLR test

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The trap and cleanup logic incorrectly clobbers the script's exit status (`$?`), preventing the temporary directory from being preserved on unexpected script failure.
--

commit c84fe24323edc3828dba95662be22cc7389443c1
Author: Ian Rogers <irogers@google.com>

perf test: Add inject ASLR test

This commit adds a new shell test suite for validating the perf inject
ASLR feature. It provides coverage for basic address remapping, pipe
mode processing, callchain normalization, and report consistency across
both user space and kernel workloads.

> diff --git a/tools/perf/tests/shell/inject_aslr.sh b/tools/perf/tests/shell/inject_aslr.sh
> new file mode 100755
> index 0000000000000..9dd0a4e5f903e
> --- /dev/null
> +++ b/tools/perf/tests/shell/inject_aslr.sh
[ ... ]
> +cleanup() {
> +  trap - EXIT TERM INT
> +  local exit_code=$?

[Severity: Medium]
Does this code accidentally clobber the exit status? The command 
trap - EXIT TERM INT will execute successfully and set $? to 0. That 0 is 
then saved into exit_code, masking the original failure status that 
triggered the cleanup.

> +  if [ "${exit_code}" -ne 0 ] || [ "${err}" -ne 0 ]; then
> +    echo "Test failed! Preserving temp directory: ${temp_dir}"
> +    return
> +  fi
> +  # Check if temp_dir is set and looks sane before removing
> +  if [[ "${temp_dir}" =~ ^/tmp/perf-test-aslr\. ]]; then
> +    rm -rf "${temp_dir}"
> +  fi
> +}
> +
> +trap_cleanup() {
> +  echo "Unexpected signal in ${FUNCNAME[1]}"
> +  cleanup

[Severity: Medium]
Similarly, does the echo command here overwrite the actual script
failure status in $? before cleanup is invoked? If so, this would
prevent the temporary directory from being preserved as intended
during an unexpected failure, making debugging test failures more
difficult.

> +  exit 1
> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260605060610.1529996-1-irogers@google.com?part=4