Re: [PATCH v11 1/5] perf maps: Add maps__mutate_mapping

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Compiler error in `maps__load_maps` due to accessing non-existent `name` field on `struct dso`.
--

commit 42ed9a7e77f954259213b06a013da93fc23180c3
Author: Ian Rogers <irogers@google.com>

perf maps: Add maps__mutate_mapping

This patch introduces maps__mutate_mapping() to safely perform field updates
under lock protection, resolving a concurrent lookup race window. It also
adds maps__load_maps() to pre-load all kernel symbol maps up front at startup
to avoid deadlocks.

> diff --git a/tools/perf/util/maps.c b/tools/perf/util/maps.c
> index 923935ee21b66..aed72c9f0a509 100644
> --- a/tools/perf/util/maps.c
> +++ b/tools/perf/util/maps.c

[ ... ]

> @@ -626,6 +669,41 @@ int maps__for_each_map(struct maps *maps, int (*cb)(struct map *map, void *data)
>  	return ret;
>  }
>  
> +int maps__load_maps(struct maps *maps)
> +{
> +	struct map **maps_copy;
> +	unsigned int nr_maps;
> +	int err = 0;

[ ... ]

> +	for (unsigned int i = 0; i < nr_maps; i++) {
> +		if (map__load(maps_copy[i]) < 0) {
> +			pr_warning("Failed to load map %s\n", map__dso(maps_copy[i])->name);

[Severity: Low]
Does this cause a build failure? It looks like struct dso does not expose
a name field directly. Should this use an accessor function like
dso__name(map__dso(maps_copy[i])) or dso__short_name() instead to retrieve
the name string?

> +			err = -1;
> +		}
> +		map__put(maps_copy[i]);
> +	}
> +	free(maps_copy);
> +	return err;
> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260605185215.2359881-1-irogers@google.com?part=1