Re: [PATCH 2/4] thermal/core: Add dedicated release callback for thermal zones

[Lukasz Luba <lukasz.luba@arm.com>]

On 5/8/26 19:05, Daniel Lezcano wrote:
> The thermal class release callback currently handles thermal zone
> cleanup by checking the device name prefix.
> 
> Move the thermal zone cleanup to a dedicated struct device release
> callback.  This avoids relying on device names to select the release
> path and keeps the thermal zone lifetime handling local to the thermal
> zone object.
> 
> Signed-off-by: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
> ---
>   drivers/thermal/thermal_core.c | 28 ++++++++++++----------------
>   1 file changed, 12 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
> index cf5d4a9c11fe..a79fc4cdb078 100644
> --- a/drivers/thermal/thermal_core.c
> +++ b/drivers/thermal/thermal_core.c
> @@ -949,24 +949,8 @@ static void thermal_unbind_cdev_from_trip(struct thermal_zone_device *tz,
>   	kfree(pos);
>   }
>   
> -static void thermal_release(struct device *dev)
> -{
> -	struct thermal_zone_device *tz;
> -
> -	if (!strncmp(dev_name(dev), "thermal_zone",
> -		     sizeof("thermal_zone") - 1)) {
> -		tz = to_thermal_zone(dev);
> -		thermal_zone_destroy_device_groups(tz);
> -		thermal_set_governor(tz, NULL);
> -		ida_destroy(&tz->ida);
> -		mutex_destroy(&tz->lock);
> -		complete(&tz->removal);
> -	}
> -}
> -
>   static const struct class thermal_class = {
>   	.name = "thermal",
> -	.dev_release = thermal_release,
>   };
>   static bool thermal_class_unavailable __ro_after_init = true;
>   
> @@ -1473,6 +1457,17 @@ static void thermal_zone_init_complete(struct thermal_zone_device *tz)
>   	__thermal_zone_device_update(tz, THERMAL_EVENT_UNSPECIFIED);
>   }
>   
> +static void thermal_zone_device_release(struct device *dev)
> +{
> +	struct thermal_zone_device *tz = to_thermal_zone(dev);
> +
> +	thermal_zone_destroy_device_groups(tz);
> +	thermal_set_governor(tz, NULL);
> +	ida_destroy(&tz->ida);
> +	mutex_destroy(&tz->lock);
> +	complete(&tz->removal);
> +}
> +
>   /**
>    * thermal_zone_device_register_with_trips() - register a new thermal zone device
>    * @type:	the thermal zone device type
> @@ -1580,6 +1575,7 @@ thermal_zone_device_register_with_trips(const char *type,
>   		tz->ops.critical = thermal_zone_device_critical;
>   
>   	tz->device.class = &thermal_class;
> +	tz->device.release = thermal_zone_device_release;
>   	tz->devdata = devdata;
>   	tz->num_trips = num_trips;
>   	for_each_trip_desc(tz, td) {

Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>