Re: [PATCH 1/2] riscv: dts: spacemit: Add i2c buses on OrangePi RV2

From: Yixun Lan <dlan@gentoo.org>
To: Iker Pedrosa <ikerpedrosam@gmail.com>
Cc: Michael Opdenacker <michael.opdenacker@rootcommit.com>,
	Johannes Erdfelt <johannes@erdfelt.com>, Yao Zi <me@ziyao.cc>,
	Dan Carpenter <dan.carpenter@linaro.org>,
	Binbin Zhou <zhoubinbin@loongson.cn>,
	linux-riscv@lists.infradead.org, spacemit@lists.linux.dev
Subject: Re: [PATCH 1/2] riscv: dts: spacemit: Add i2c buses on OrangePi RV2
Date: Fri, 19 Dec 2025 19:29:24 +0800	[thread overview]
Message-ID: <20251219112924-GYB1955339@gentoo.org> (raw)
In-Reply-To: <CABdCQ=N4eZyBNBrhOQsW7jSeJmr=xhicwW8fskOAioV1q9cC5A@mail.gmail.com>

Hi Iker,

thanks for pushing this, I have few comments

On 10:49 Thu 18 Dec     , Iker Pedrosa wrote:
> Hi Michael, Yao, Javier, Johannes,
> 
> Thanks everyone for the great discussion and the guidance.
> 
> First of all, I’d like to clarify a point regarding my previous email
> to avoid any confusion: the detailed technical breakdown and pointers
> were provided by Yao here in the thread. My mention of Javier was
> regarding a separate offline conversation we had earlier. Both
> contributions have been essential to understanding why the SD card is
> currently failing.
> 
> Given that we are all a bit tight on time, I think it would be best to
> split the work into separate tasks so we can make progress in
> parallel. Based on the feedback, here is the roadmap:
> 
> 1. Define a separate compatible string: the eMMC slot has a PHY, while
> SD/SDIO slots do not. We need to differentiate them to apply the
> correct reset logic (skipping PHY init for SD).
I agree, separate compatibles sounds more feasibile, vendor reuse macro
of MMC_CAP2_NO_{SD,SDIO,MMC} to differentiate the controller which is
kind of unmaintainable

> 2. Extend the pinctrl driver: support is needed for switching the SD
> voltage pins from 3.3V to 1.8V.
we probably could leave pinctrl for now or take a look at it later when
really necessary,  the default pin settings should work for most cases,
besides, vendor is also starting to drop two pinctrl state implementation
(the normal vs fast ..)

for 3.3v to 1.8v switch, there is one MMC1_IO_REG to control it, and
we do need to implement a _voltage_switch() function
and it's in another aib io space..

> 3. Add tuning logic: this is required at least for SDR modes.
> 
right, especially for high speed clock

> Since I’ll be focusing on the driver/reset logic (1), is there anyone
the reset logic is also needed for K3 SoC, so I'd like to get it added
early, I could get a patch for it during the weekend if you don't mind,
or can leave it to you if you will do it shortly..

> else willing to pick up the pinctrl (2) or the tuning (3)?
> 
I do want to work on SD/SDIO support, but for now I need to push
clock/pinctrl for K3 SoC first, then will have time to take a look

> Looking forward to working together on this.
> 
great!

-- 
Yixun Lan (dlan)

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv