Re: [PATCH 1/2] riscv: dts: spacemit: Add i2c buses on OrangePi RV2

[Javier Martinez Canillas <javierm@redhat.com>]

Michael Opdenacker <michael.opdenacker@rootcommit.com> writes:

Hello Michael,

> The OrangePi RV2 board exposes i2c2 and i2c8 buses
> from the Spacemit K1 SoC.
>
> This declares devices present on such buses, in particular
> the at24 eeprom to store MAC addresses and the regulators
> attached to the PMIC on i2c8.
>

As Yao explained, there is still work needed to make the MMC work on K1
based boards. I also tried the same on my Milk-V Jupiter and found issues.

I believe though that this patch has merits on its own and could land
regardless of the MMC support. That's why I also posted a similar change
for the Milk-V Jupiter board:

https://lore.kernel.org/lkml/20251206134532.1741648-1-javierm@redhat.com/

My changes are identical to the Banana Pi BPI-F3 and I see yours too, so
it seems all these boards are based on a K1 SoC reference design.

> Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
> ---
>  arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts | 166 +++++++++++++++++++++++
>  1 file changed, 166 insertions(+)
>

Personally, I would split the changes in separate patches as I did on my
series. But I guess it is also OK to have it as a single patch as you did:

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv