Re: [PATCH 1/2] riscv: dts: spacemit: Add i2c buses on OrangePi RV2

From: Javier Martinez Canillas <javierm@redhat.com>
To: Iker Pedrosa <ikerpedrosam@gmail.com>,
	Michael Opdenacker <michael.opdenacker@rootcommit.com>
Cc: Yao Zi <me@ziyao.cc>, Yixun Lan <dlan@gentoo.org>,
	Dan Carpenter <dan.carpenter@linaro.org>,
	Binbin Zhou <zhoubinbin@loongson.cn>,
	linux-riscv@lists.infradead.org, spacemit@lists.linux.dev
Subject: Re: [PATCH 1/2] riscv: dts: spacemit: Add i2c buses on OrangePi RV2
Date: Wed, 17 Dec 2025 21:25:13 +0100	[thread overview]
Message-ID: <87v7i4c0uu.fsf@ocarina.mail-host-address-is-not-set> (raw)
In-Reply-To: <CABdCQ=Orw0ULhPm43rAhS_iqqNYU4nChcPCqh8UdFhJUumVG5w@mail.gmail.com>

Iker Pedrosa <ikerpedrosam@gmail.com> writes:

Hello Iker,

> Hi Michael,
>
> Based on the discussion and Javier's feedback, to make the SD card
> work properly, we need to patch the driver to implement the following:
>

Just one correction: it was Yao who gave that feedback, not me.

> Define a separate compatible string: the eMMC slot has a PHY, while
> SD/SDIO slots do not. We need to differentiate them to apply the
> correct reset logic (skipping PHY init for SD).
> Extend the pinctrl driver: support is needed for switching the SD
> voltage pins from 3.3V to 1.8V.
> Add tuning logic: this is required at least for SDR modes.
>

I think you are correct with all of these.

> If you don't mind, I'll start working on point #1. Feel free to choose
> any other task.
>
> I'll post a patch once I have it working.
>

As Micheal said, that would be great. Please let me know if I can help in
any way since I also have a board to test (Milk-V Jupiter with a MMC slot).

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv